From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C14643EA4; Thu, 18 Apr 2024 21:22:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9F1040042; Thu, 18 Apr 2024 21:22:08 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 8477D40041 for ; Thu, 18 Apr 2024 21:22:06 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 69A982073C; Thu, 18 Apr 2024 21:22:04 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH 16/16] build: enable vla warnings on Windows built code Date: Thu, 18 Apr 2024 21:22:03 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F3BA@smartserver.smartshare.dk> In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 16/16] build: enable vla warnings on Windows built code Thread-Index: AdqRpG2awMILCCW2T4+1DdSpFnaIeAAIPB8A References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1713397319-26135-17-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F3B6@smartserver.smartshare.dk> <20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" , "Tyler Retzlaff" Cc: , "Akhil Goyal" , "Aman Singh" , "Andrew Rybchenko" , "Chengwen Feng" , "Dariusz Sosnowski" , "Dmitry Kozlyuk" , "Fan Zhang" , "Ferruh Yigit" , "Harry van Haaren" , "Honnappa Nagarahalli" , "Jiayu Hu" , "Jingjing Wu" , "Kevin Laatz" , "Konstantin Ananyev" , "Matan Azrad" , "Ori Kam" , "Pallavi Kadam" , "Reshma Pattan" , "Sameh Gobriel" , "Suanming Mou" , "Thomas Monjalon" , "Viacheslav Ovsiienko" , "Vladimir Medvedkin" , "Volodymyr Fialko" , "Yipeng Wang" , "Yuying Zhang" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Thursday, 18 April 2024 17.24 >=20 > On Thu, Apr 18, 2024 at 08:12:26AM -0700, Tyler Retzlaff wrote: > > On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Br=F8rup wrote: > > > > MSVC does not support optional C11 VLAs. When building for = Windows > > > > enable -Wvla so that mingw and clang also fail if a VLA is used. > > > > > > Minor detail, doesn't affect my Ack for the series... > > > > > > Applications built for Windows with mingw and clang might use VLAs > in > > > the application itself. > > > > > > Perhaps we should let them continue doing that for now. > > > > i guess you mean our examples or if dpdk is configured as a sub- > project? > > > > for examples i could explicitly suppress in examples with -Wno-vla = but > > that means any that use VLAs could not be built with MSVC. > > > > for sub-module and sub-project of dpdk i feel like these > > add_project_arguments are not imparted on the application with > > encapsulating project meson setup no? > > > > anyone know? Bruce? Stephen? > > > Project args are not used when building external applications - either > those using DPDK as a subproject or via pkg-config. So therefore, this > change should be safe. It will only impact built-in DPDK apps and > examples. >=20 > /Bruce Thank you for clarifying, Bruce. Then my comment was irrelevant. Sorry about the noise. ;-)