From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 04BBD44098;
	Wed, 22 May 2024 10:36:40 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DCABB4026B;
	Wed, 22 May 2024 10:36:39 +0200 (CEST)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id D1A9B4028B
 for <dev@dpdk.org>; Wed, 22 May 2024 10:36:38 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id B161220B6B;
 Wed, 22 May 2024 10:36:38 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v2] hash: provide crc32 functions based on intrinsics
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Wed, 22 May 2024 10:36:35 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F489@smartserver.smartshare.dk>
In-Reply-To: <20240521192111.3c2e9eda@hermes.local>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v2] hash: provide crc32 functions based on intrinsics
Thread-Index: Adqr7rxir7M7r7C+Tnafz2z5UEFJmQANF/tA
References: <1710970127-25938-2-git-send-email-roretzla@linux.microsoft.com>
 <1716336134-27366-1-git-send-email-roretzla@linux.microsoft.com>
 <1716336134-27366-2-git-send-email-roretzla@linux.microsoft.com>
 <20240521192111.3c2e9eda@hermes.local>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
 "Tyler Retzlaff" <roretzla@linux.microsoft.com>
Cc: <dev@dpdk.org>, "Bruce Richardson" <bruce.richardson@intel.com>,
 "Sameh Gobriel" <sameh.gobriel@intel.com>,
 "Vladimir Medvedkin" <vladimir.medvedkin@intel.com>,
 "Yipeng Wang" <yipeng1.wang@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, 22 May 2024 04.21
>=20
> On Tue, 21 May 2024 17:02:14 -0700
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
>=20
> > MSVC does not support inline asm so replace crc32 inline function
> > implementations with intrinsics compatible with all toolchains.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
>=20
> always good to remove asm since in tends not to get optimized.
>=20
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>