DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Jerin Jacob" <jerinjacobk@gmail.com>,
	"Vamsi Attunuru" <vattunuru@marvell.com>
Cc: <fengchengwen@huawei.com>, <dev@dpdk.org>,
	<kevin.laatz@intel.com>, <bruce.richardson@intel.com>,
	<jerinj@marvell.com>, <anoobj@marvell.com>
Subject: RE: [PATCH] doc: announce dmadev new capability addition
Date: Mon, 29 Jul 2024 19:17:56 +0200	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F5C4@smartserver.smartshare.dk> (raw)
In-Reply-To: <CALBAE1ORvP51OgM1Hgks39nHG-rqYYV3M5_gu=NfYE-4CAfCsg@mail.gmail.com>

> From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
> Sent: Monday, 29 July 2024 17.20
> 
> On Mon, Jul 29, 2024 at 6:19 PM Vamsi Attunuru <vattunuru@marvell.com>
> wrote:
> >
> > Announce addition of new capability flag and fields in
> > rte_dma_info and rte_dma_conf structures.
> 
> The new capability flag won't break ABI. We can mention only fields
> update rte_dma_info and rte_dma_conf structures.
> 
> Another option is new set APIs for priority enablement.  The downside
> is more code. All, opinions?

I think that this feature should be simple enough to expand the rte_dma_info and rte_dma_conf structures with a few new fields, rather than adding a new set of APIs for it.

It seems to become 1-level weighted priority scheduling of a few QoS classes, not hierarchical or anything complex enough to justify a new set of APIs. Just a simple array of per-class properties.

The max possible number of QoS classes (i.e. the array size) should be build time configurable. Considering Marvell hardware, it seems 4 would be a good default.


  reply	other threads:[~2024-07-29 17:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29 12:49 Vamsi Attunuru
2024-07-29 15:20 ` Jerin Jacob
2024-07-29 17:17   ` Morten Brørup [this message]
2024-07-31 10:24   ` Thomas Monjalon
2024-07-30 12:10 ` [PATCH v2] doc: announce changes to dma device structures Amit Prakash Shukla
2024-07-30 12:53 ` [PATCH v3] " Amit Prakash Shukla
2024-07-30 14:46   ` [PATCH v4] " Amit Prakash Shukla
2024-07-30 17:27     ` Jerin Jacob
2024-07-31 11:01       ` Thomas Monjalon
2024-07-31 16:06         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F5C4@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=anoobj@marvell.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=kevin.laatz@intel.com \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).