From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E605045777;
	Fri,  9 Aug 2024 10:33:52 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BE69B402A5;
	Fri,  9 Aug 2024 10:33:52 +0200 (CEST)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id C09BC40274
 for <dev@dpdk.org>; Fri,  9 Aug 2024 10:33:51 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id B367620EE3;
 Fri,  9 Aug 2024 10:33:50 +0200 (CEST)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH 5/5] eal: simplify eal alarm cancel by using
 LIST_FOREACH_SAFE
Date: Fri, 9 Aug 2024 10:33:49 +0200
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F60E@smartserver.smartshare.dk>
In-Reply-To: <20240808194756.167664-6-stephen@networkplumber.org>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH 5/5] eal: simplify eal alarm cancel by using
 LIST_FOREACH_SAFE
Thread-Index: Adrpy/oCvnKZE6+QRri9JELzCFfxcQAalgvQ
References: <20240808194756.167664-1-stephen@networkplumber.org>
 <20240808194756.167664-6-stephen@networkplumber.org>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
	<dev@dpdk.org>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> +++ b/lib/eal/linux/eal_alarm.c
> @@ -53,6 +53,13 @@ static struct rte_intr_handle *intr_handle;
>  static int handler_registered =3D 0;
>  static void eal_alarm_callback(void *arg);
>=20
> +#ifndef LIST_FOREACH_SAFE
> +#define LIST_FOREACH_SAFE(var, head, field, tvar)			\
> +	for ((var) =3D LIST_FIRST((head));				\
> +	    (var) && ((tvar) =3D LIST_NEXT((var), field), 1);		\
> +	    (var) =3D (tvar))
> +#endif

This macro is already defined for Windows [1]; isn't it also defined in =
some Linux/BSD standard header file already?

[1]: =
https://elixir.bootlin.com/dpdk/v24.07/source/lib/eal/windows/include/sys=
/queue.h#L515