From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DE1A457A1; Mon, 12 Aug 2024 16:10:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48870402BB; Mon, 12 Aug 2024 16:10:54 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id ED93F4014F for ; Mon, 12 Aug 2024 16:10:52 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id DE6902056A; Mon, 12 Aug 2024 16:10:50 +0200 (CEST) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [RFC PATCH] config: make queues per port a meson config option Date: Mon, 12 Aug 2024 16:10:49 +0200 X-MimeOLE: Produced By Microsoft Exchange V6.5 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F61F@smartserver.smartshare.dk> In-Reply-To: <20240812132910.162252-1-bruce.richardson@intel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [RFC PATCH] config: make queues per port a meson config option Thread-Index: Adrsu6mMv6+vOJF2T72xJGRr09WB+wAAEzYw References: <20240812132910.162252-1-bruce.richardson@intel.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Bruce Richardson" , Cc: , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Bruce Richardson [mailto:bruce.richardson@intel.com] >=20 > The default number of ethernet queues per port is currently set to > 1k which is more than enough for most applications, but still is lower > than the total number of queues which may be available on modern NICs. > Rather than increasing the max queues further, which will increase > the memory footprint (since the value is used in array dimensioning), > we can instead make the value a meson tunable option - and reduce the > default value to 256 in the process. Overall, I agree that this tunable is not very exotic, and can be = exposed as suggested. The reduction of the default value must be mentioned in the release = notes. > # set other values pulled from the build options > dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports')) > +dpdk_conf.set('RTE_MAX_QUEUES_PER_PORT', > get_option('max_queues_per_ethport')) Please rename RTE_MAX_QUEUES_PER_PORT to _PER_ETHPORT, so it resembles = MAX_ETHPORTS. For API backwards compatibility, you can add: #define RTE_MAX_QUEUES_PER_PORT RTE_MAX_QUEUES_PER_ETHPORT I wonder if it would be possible to have separate max sizes for RX and = TX queues? If it can save a non-negligible amount of memory, it might be = useful for some applications. With suggested changes (splitting RX/TX maximums not required), Acked-by: Morten Br=F8rup