From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Maxime Coquelin" <maxime.coquelin@redhat.com>
Cc: <dev@dpdk.org>, <techboard@dpdk.org>, <david.marchand@redhat.com>,
<thomas@monjalon.net>
Subject: RE: [RFC 1/3] uapi: introduce kernel uAPI headers importation
Date: Fri, 6 Sep 2024 08:46:20 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F6AC@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240905221528.1861323-2-maxime.coquelin@redhat.com>
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Friday, 6 September 2024 00.15
>
> This patch introduces uAPI headers importation into the
> DPDK repository. This import is possible thanks to Linux
> Kernel licence exception for syscalls:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENS
> ES/exceptions/Linux-syscall-note
>
> Header files are have to be explicitly imported, and
> libraries and drivers have to explicitly enable their
> inclusion.
>
> Guidelines are provided in the documentation, and a helper
> script is also provided to ensure proper importation of the
> header (unmodified content from a released Kernel version).
>
> Next version will introduce a script to check headers are
> valids.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
Excellent solution, Maxime.
Minor suggestions and typos mentioned below.
Acked-by: Morten Brørup <mb@smartsharesystems.com>
> +print_usage()
> +{
> + echo "Usage: $(basename $0) [-h] [file] [version]"
> + echo "Example of valid file is linux/vfio.h"
> + echo "Example of valid version is v6.10"
Suggest:
+ echo "Example of valid file: linux/vfio.h"
+ echo "Example of valid version: v6.10"
> +Once imported, the header files should be committed without any other change,
> +and the commit message MUST specify the imported version using ``uAPI ID:``
> +tag and title MUST be prefixed with uapi keywork. For example::
"uAPI ID:" -> "uAPI Version"
"keywork" -> "keyword"
next prev parent reply other threads:[~2024-09-06 6:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 22:15 [RFC 0/3] Import Kernel uAPI header files Maxime Coquelin
2024-09-05 22:15 ` [RFC 1/3] uapi: introduce kernel uAPI headers importation Maxime Coquelin
2024-09-06 6:46 ` Morten Brørup [this message]
2024-09-06 7:01 ` Maxime Coquelin
2024-09-06 7:13 ` David Marchand
2024-09-06 8:29 ` Maxime Coquelin
2024-09-09 0:02 ` Stephen Hemminger
2024-09-09 7:43 ` Maxime Coquelin
2024-09-05 22:15 ` [RFC 2/3] uapi: import VDUSE header Maxime Coquelin
2024-09-05 22:15 ` [RFC 3/3] vduse: use import VDUSE uAPI header Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F6AC@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).