From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Ferruh Yigit" <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>
Subject: RE: ci: version.map check
Date: Wed, 11 Sep 2024 02:08:20 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F6CA@smartserver.smartshare.dk> (raw)
In-Reply-To: <dffacd5e-13e1-448c-ba81-35884a4a3e9f@amd.com>
> From: Ferruh Yigit [mailto:ferruh.yigit@amd.com]
> Sent: Wednesday, 11 September 2024 01.48
>
> On 9/10/2024 5:56 PM, Morten Brørup wrote:
> > It would be convenient if the CI checked that the symbols in
> version.map files actually exist in the resulting code.
> >
>
> Is there instances that is not the case?
While reviewing a patch, I noticed one such instance.
A previous version of the patch contained a global variable that had since been removed, but not from the version.map file.
Specifically "rte_lcore_var" in this earlier version:
https://patchwork.dpdk.org/project/dpdk/patch/20240208181644.455233-2-mattias.ronnblom@ericsson.com/
Which in this more recent patch has been removed, but remains in version.map:
https://patchwork.dpdk.org/project/dpdk/patch/20240910070344.699183-2-mattias.ronnblom@ericsson.com/
next prev parent reply other threads:[~2024-09-11 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 16:56 Morten Brørup
2024-09-10 23:48 ` Ferruh Yigit
2024-09-11 0:08 ` Morten Brørup [this message]
2024-09-11 0:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F6CA@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).