DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
	<thomas@monjalon.net>, "Ferruh Yigit" <ferruh.yigit@amd.com>
Cc: <dev@dpdk.org>, <maxime.coquelin@redhat.com>,
	"Chenbo Xia" <chenbox@nvidia.com>
Subject: RE: virtio: RSS support capa
Date: Wed, 11 Sep 2024 14:17:05 +0200	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F6CE@smartserver.smartshare.dk> (raw)
In-Reply-To: <6a32ac92-1513-4c62-b201-3f99dacf5aab@oktetlabs.ru>

> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru]
> Sent: Sunday, 8 September 2024 10.33
> 
> On 9/7/24 23:55, Morten Brørup wrote:
> >> From: Morten Brørup [mailto:mb@smartsharesystems.com]
> >> Sent: Friday, 6 September 2024 21.38
> >>
> >> Maxime, Chenbo,
> >>
> >> If the virtio PMD supports RSS, it should be announced in its
> >> capabilities.
> >>
> >> I think this should be added to virtio_dev_info_get():
> >>
> >> 	if (host_features & (1ULL << VIRTIO_NET_F_RSS))
> >> 		dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
> >
> > Or perhaps I'm misunderstanding this capability flag.
> >
> > I thought it indicated RSS ability, i.e. multi-queue, effectively shadowing
> rte_eth_conf.rxmode.mq_mode RTE_ETH_MQ_RX_RSS_FLAG.
> > But maybe it doesn't. Maybe it indicates the ability to store the RSS hash
> value in the mbuf.
> >
> > The RTE_ETH_RX_OFFLOAD_RSS_HASH flag is completely undocumented.
> >
> > Can someone please clarify?
> >
> RTE_ETH_RX_OFFLOAD_RSS_HASH means that the driver can provide RSS hash
> value in mbuf (it makes sense if HW can provide it to the driver).

OK, thanks.

Then what indicates this ethdev capability: Use RSS to distribute packets into multiple RX queues?
I.e. what to check before setting rte_eth_conf.rxmode.mq_mode=RTE_ETH_MQ_RX_RSS_FLAG?


  reply	other threads:[~2024-09-11 12:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 19:38 Morten Brørup
2024-09-07 20:55 ` Morten Brørup
2024-09-08  8:32   ` Andrew Rybchenko
2024-09-11 12:17     ` Morten Brørup [this message]
2024-09-11 13:20       ` Thomas Monjalon
2024-09-11 14:02         ` Ferruh Yigit
2024-09-11 14:28           ` Ferruh Yigit
2024-09-11 14:59           ` Morten Brørup
2024-09-11 16:18             ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F6CE@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).