From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
"Stefan Laesser" <stefan.laesser@omicronenergy.com>
Cc: <dev@dpdk.org>
Subject: RE: [PATCH v3] net/af_packet: add timestamp offloading support
Date: Fri, 20 Sep 2024 18:09:48 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F708@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240920072946.60da2724@hermes.local>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, 20 September 2024 16.30
>
> On Fri, 20 Sep 2024 09:14:11 +0200
> Stefan Laesser <stefan.laesser@omicronenergy.com> wrote:
>
> > + *RTE_MBUF_DYNFIELD(mbuf, timestamp_dynfield_offset,
> > + rte_mbuf_timestamp_t *) =
> > + (uint64_t)ppd->tp_sec * 1000000000 + ppd-
> >tp_nsec;
>
> Maybe the should be rte_timespec_to_timestamp() inline in rte_mbuf?
Yes, when/if timestamp gets standardized to NS after UNIX origo.
And the scope of the time conversion function could be broader than mbufs, so it should reside in some time related header in EAL.
prev parent reply other threads:[~2024-09-20 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 11:43 [PATCH] " Stefan Laesser
2024-09-03 16:21 ` Stephen Hemminger
2024-09-03 21:11 ` Morten Brørup
2024-09-06 6:22 ` Stefan Lässer
2024-09-06 8:13 ` Morten Brørup
2024-09-11 5:44 ` Stefan Lässer
2024-09-11 6:59 ` Morten Brørup
2024-09-20 6:48 ` Stefan Lässer
2024-09-20 6:44 ` [PATCH v2] " Stefan Laesser
2024-09-20 7:14 ` [PATCH v3] " Stefan Laesser
2024-09-20 14:29 ` Stephen Hemminger
2024-09-20 16:09 ` Morten Brørup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F708@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=dev@dpdk.org \
--cc=stefan.laesser@omicronenergy.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).