From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 237A945AE1; Tue, 8 Oct 2024 11:33:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F30404025C; Tue, 8 Oct 2024 11:33:38 +0200 (CEST) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id C8F4A4021F for ; Tue, 8 Oct 2024 11:33:36 +0200 (CEST) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 8B69D203F3; Tue, 8 Oct 2024 11:33:36 +0200 (CEST) Content-class: urn:content-classes:message Subject: RE: [PATCH 00/10] require checking ethdev get return value MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Date: Tue, 8 Oct 2024 11:33:35 +0200 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F793@smartserver.smartshare.dk> In-Reply-To: <20241004162418.52940-1-stephen@networkplumber.org> X-MS-Has-Attach: X-MimeOLE: Produced By Microsoft Exchange V6.5 X-MS-TNEF-Correlator: Thread-Topic: [PATCH 00/10] require checking ethdev get return value Thread-Index: AdsWefEVZb7CSYGRSBqtiwkFH3NbagC6w/aQ References: <20241004162418.52940-1-stephen@networkplumber.org> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Stephen Hemminger" , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, 4 October 2024 18.22 >=20 > Several places flagged by Coverity and Codeql are from code that > calls rte_eth_dev_info_get() but does not check the return value. > If rte_eth_dev_info_get() returns an error, the device info is = garbage. >=20 > This patch series uses the function attribute to force code > to check the result or there will be a compiler warning. This is slow path, so no performance issues. For the series, Acked-by: Morten Br=F8rup