From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
"Daniel Gregory" <daniel.gregory@bytedance.com>
Cc: "Ruifeng Wang" <ruifeng.wang@arm.com>, <dev@dpdk.org>,
"Punit Agrawal" <punit.agrawal@bytedance.com>,
"Liang Ma" <liangma@bytedance.com>, <feifei.wang2@arm.com>
Subject: RE: [PATCH v2] eal/arm: replace RTE_BUILD_BUG on non-constant
Date: Tue, 8 Oct 2024 11:47:56 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F794@smartserver.smartshare.dk> (raw)
In-Reply-To: <20241004104706.35a8ebf0@hermes.local>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, 4 October 2024 19.47
>
> On Fri, 3 May 2024 19:27:30 +0100
> Daniel Gregory <daniel.gregory@bytedance.com> wrote:
>
> > Fix the compile errors by replacing the check with an assert, like in
> > the generic implementation (lib/eal/include/generic/rte_pause.h).
> > - RTE_BUILD_BUG_ON(memorder != rte_memory_order_acquire &&
> > + assert(memorder != rte_memory_order_acquire &&
> > memorder != rte_memory_order_relaxed);
> >
>
> Why not change RET_BUILD_BUG_ON() to RTE_ASSERT()?
> The one issue is that by default RTE_ENABLE_ASSERT is not enabled.
I don't like assert() either. RTE_ASSERT() should be used instead.
However, there should be no objections to doing exactly the same as in the generic implementation.
A replacement of assert() throughout the DPDK code would be a different patch.
Checkpatch could check for it too.
For this patch,
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2024-10-08 9:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 14:21 [PATCH] " Daniel Gregory
2024-05-02 16:20 ` Stephen Hemminger
2024-05-02 17:44 ` Daniel Gregory
2024-05-02 18:27 ` Stephen Hemminger
2024-05-02 21:48 ` Stephen Hemminger
2024-05-03 9:46 ` Daniel Gregory
2024-05-04 0:56 ` Stephen Hemminger
2024-05-09 11:02 ` Daniel Gregory
2024-05-03 13:32 ` David Marchand
2024-05-03 14:21 ` Daniel Gregory
2024-05-03 18:27 ` [PATCH v2] " Daniel Gregory
2024-05-03 18:30 ` Daniel Gregory
2024-05-04 0:59 ` Stephen Hemminger
2024-06-27 15:08 ` Thomas Monjalon
2024-06-28 10:05 ` Daniel Gregory
2024-06-28 15:19 ` Stephen Hemminger
2024-05-06 9:30 ` Ruifeng Wang
2024-05-11 17:00 ` Wathsala Wathawana Vithanage
2024-10-04 17:47 ` Stephen Hemminger
2024-10-08 9:47 ` Morten Brørup [this message]
2024-05-04 1:02 ` [PATCH] " Stephen Hemminger
2024-05-09 11:11 ` Daniel Gregory
2024-05-09 16:47 ` Tyler Retzlaff
2024-05-11 16:48 ` Wathsala Wathawana Vithanage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F794@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=daniel.gregory@bytedance.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=liangma@bytedance.com \
--cc=punit.agrawal@bytedance.com \
--cc=ruifeng.wang@arm.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).