* [PATCH] replace use of word segregate in comments
@ 2024-10-04 23:03 Stephen Hemminger
2024-10-08 9:53 ` Morten Brørup
2024-10-08 15:49 ` [PATCH v2] " Stephen Hemminger
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2024-10-04 23:03 UTC (permalink / raw)
To: dev
Cc: Stephen Hemminger, Yipeng Wang, Sameh Gobriel, Bruce Richardson,
Vladimir Medvedkin, Wathsala Vithanage, Vamsi Attunuru,
Konstantin Ananyev
The use of the word segregate should be avoided.
Rationale from https://inclusivenaming.org/word-lists/tier-3/segregate/
The word segregation carries strong context in regard to civil rights
movements in the US and South Africa, segregation in the US South, and
racist history.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/test_hash_readwrite_lf_perf.c | 2 +-
drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 2 +-
drivers/net/octeon_ep/cnxk_ep_rx_sse.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test/test_hash_readwrite_lf_perf.c b/app/test/test_hash_readwrite_lf_perf.c
index 4523985169..864c3059d9 100644
--- a/app/test/test_hash_readwrite_lf_perf.c
+++ b/app/test/test_hash_readwrite_lf_perf.c
@@ -397,7 +397,7 @@ generate_keys(void)
for (i = 2; i < TOTAL_INSERT; i++)
keys[i] = keys[i-1] + keys[i-2];
- /* Segregate keys into keys_no_ks and keys_ks */
+ /* Separate keys into keys_no_ks and keys_ks */
for (i = 0; i < TOTAL_INSERT; i++) {
/* Check if primary bucket has space.*/
sig = rte_hash_hash(tbl_rwc_test_param.h,
diff --git a/drivers/net/octeon_ep/cnxk_ep_rx_neon.c b/drivers/net/octeon_ep/cnxk_ep_rx_neon.c
index 4c46a7ea08..2e17f2dfec 100644
--- a/drivers/net/octeon_ep/cnxk_ep_rx_neon.c
+++ b/drivers/net/octeon_ep/cnxk_ep_rx_neon.c
@@ -61,7 +61,7 @@ cnxk_ep_process_pkts_vec_neon(struct rte_mbuf **rx_pkts, struct otx_ep_droq *dro
/* Vertical add, consolidate outside the loop. */
bytes += vaddq_u32(bytes, s01);
- /* Segregate to packet length and data length. */
+ /* Separate intto packet length and data length. */
s23 = vqtbl1q_u8(s01, mask1);
s01 = vqtbl1q_u8(s01, mask0);
diff --git a/drivers/net/octeon_ep/cnxk_ep_rx_sse.c b/drivers/net/octeon_ep/cnxk_ep_rx_sse.c
index 308c8b2288..cab26ddaf3 100644
--- a/drivers/net/octeon_ep/cnxk_ep_rx_sse.c
+++ b/drivers/net/octeon_ep/cnxk_ep_rx_sse.c
@@ -52,7 +52,7 @@ cnxk_ep_process_pkts_vec_sse(struct rte_mbuf **rx_pkts, struct otx_ep_droq *droq
s01 = _mm_shuffle_epi8(s01, bswap_mask);
/* Vertical add, consolidate outside loop */
bytes = _mm_add_epi32(bytes, s01);
- /* Segregate to packet length and data length. */
+ /* Separate intto packet length and data length. */
s23 = _mm_shuffle_epi32(s01, _MM_SHUFFLE(3, 3, 1, 1));
s01 = _mm_shuffle_epi8(s01, cpy_mask);
s23 = _mm_shuffle_epi8(s23, cpy_mask);
--
2.45.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] replace use of word segregate in comments
2024-10-04 23:03 [PATCH] replace use of word segregate in comments Stephen Hemminger
@ 2024-10-08 9:53 ` Morten Brørup
2024-10-08 15:49 ` [PATCH v2] " Stephen Hemminger
1 sibling, 0 replies; 4+ messages in thread
From: Morten Brørup @ 2024-10-08 9:53 UTC (permalink / raw)
To: Stephen Hemminger, dev
Cc: Yipeng Wang, Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin,
Wathsala Vithanage, Vamsi Attunuru, Konstantin Ananyev
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, 5 October 2024 01.03
>
> The use of the word segregate should be avoided.
> Rationale from https://inclusivenaming.org/word-lists/tier-3/segregate/
>
> The word segregation carries strong context in regard to civil rights
> movements in the US and South Africa, segregation in the US South,
> and
> racist history.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> +++ b/drivers/net/octeon_ep/cnxk_ep_rx_neon.c
> @@ -61,7 +61,7 @@ cnxk_ep_process_pkts_vec_neon(struct rte_mbuf
> **rx_pkts, struct otx_ep_droq *dro
>
> /* Vertical add, consolidate outside the loop. */
> bytes += vaddq_u32(bytes, s01);
> - /* Segregate to packet length and data length. */
> + /* Separate intto packet length and data length. */
Typo: intto -> into
> +++ b/drivers/net/octeon_ep/cnxk_ep_rx_sse.c
> @@ -52,7 +52,7 @@ cnxk_ep_process_pkts_vec_sse(struct rte_mbuf
> **rx_pkts, struct otx_ep_droq *droq
> s01 = _mm_shuffle_epi8(s01, bswap_mask);
> /* Vertical add, consolidate outside loop */
> bytes = _mm_add_epi32(bytes, s01);
> - /* Segregate to packet length and data length. */
> + /* Separate intto packet length and data length. */
Typo: intto -> into
With typos fixed,
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] replace use of word segregate in comments
2024-10-04 23:03 [PATCH] replace use of word segregate in comments Stephen Hemminger
2024-10-08 9:53 ` Morten Brørup
@ 2024-10-08 15:49 ` Stephen Hemminger
2024-10-09 0:36 ` fengchengwen
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2024-10-08 15:49 UTC (permalink / raw)
To: dev
Cc: Stephen Hemminger, Morten Brørup, Yipeng Wang,
Sameh Gobriel, Bruce Richardson, Vladimir Medvedkin,
Wathsala Vithanage, Vamsi Attunuru, Konstantin Ananyev
The use of the word segregate should be avoided.
Rationale from https://inclusivenaming.org/word-lists/tier-3/segregate/
The word segregation carries strong context in regard to civil rights
movements in the US and South Africa, segregation in the US South, and
racist history.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
app/test/test_hash_readwrite_lf_perf.c | 2 +-
drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 2 +-
drivers/net/octeon_ep/cnxk_ep_rx_sse.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test/test_hash_readwrite_lf_perf.c b/app/test/test_hash_readwrite_lf_perf.c
index 4523985169..864c3059d9 100644
--- a/app/test/test_hash_readwrite_lf_perf.c
+++ b/app/test/test_hash_readwrite_lf_perf.c
@@ -397,7 +397,7 @@ generate_keys(void)
for (i = 2; i < TOTAL_INSERT; i++)
keys[i] = keys[i-1] + keys[i-2];
- /* Segregate keys into keys_no_ks and keys_ks */
+ /* Separate keys into keys_no_ks and keys_ks */
for (i = 0; i < TOTAL_INSERT; i++) {
/* Check if primary bucket has space.*/
sig = rte_hash_hash(tbl_rwc_test_param.h,
diff --git a/drivers/net/octeon_ep/cnxk_ep_rx_neon.c b/drivers/net/octeon_ep/cnxk_ep_rx_neon.c
index 4c46a7ea08..2cb5cf4ad8 100644
--- a/drivers/net/octeon_ep/cnxk_ep_rx_neon.c
+++ b/drivers/net/octeon_ep/cnxk_ep_rx_neon.c
@@ -61,7 +61,7 @@ cnxk_ep_process_pkts_vec_neon(struct rte_mbuf **rx_pkts, struct otx_ep_droq *dro
/* Vertical add, consolidate outside the loop. */
bytes += vaddq_u32(bytes, s01);
- /* Segregate to packet length and data length. */
+ /* Separate into packet length and data length. */
s23 = vqtbl1q_u8(s01, mask1);
s01 = vqtbl1q_u8(s01, mask0);
diff --git a/drivers/net/octeon_ep/cnxk_ep_rx_sse.c b/drivers/net/octeon_ep/cnxk_ep_rx_sse.c
index 308c8b2288..fbd1f73c1e 100644
--- a/drivers/net/octeon_ep/cnxk_ep_rx_sse.c
+++ b/drivers/net/octeon_ep/cnxk_ep_rx_sse.c
@@ -52,7 +52,7 @@ cnxk_ep_process_pkts_vec_sse(struct rte_mbuf **rx_pkts, struct otx_ep_droq *droq
s01 = _mm_shuffle_epi8(s01, bswap_mask);
/* Vertical add, consolidate outside loop */
bytes = _mm_add_epi32(bytes, s01);
- /* Segregate to packet length and data length. */
+ /* Separate into packet length and data length. */
s23 = _mm_shuffle_epi32(s01, _MM_SHUFFLE(3, 3, 1, 1));
s01 = _mm_shuffle_epi8(s01, cpy_mask);
s23 = _mm_shuffle_epi8(s23, cpy_mask);
--
2.45.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] replace use of word segregate in comments
2024-10-08 15:49 ` [PATCH v2] " Stephen Hemminger
@ 2024-10-09 0:36 ` fengchengwen
0 siblings, 0 replies; 4+ messages in thread
From: fengchengwen @ 2024-10-09 0:36 UTC (permalink / raw)
To: Stephen Hemminger, dev
Cc: Morten Brørup, Yipeng Wang, Sameh Gobriel, Bruce Richardson,
Vladimir Medvedkin, Wathsala Vithanage, Vamsi Attunuru,
Konstantin Ananyev
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/10/8 23:49, Stephen Hemminger wrote:
> The use of the word segregate should be avoided.
> Rationale from https://inclusivenaming.org/word-lists/tier-3/segregate/
>
> The word segregation carries strong context in regard to civil rights
> movements in the US and South Africa, segregation in the US South, and
> racist history.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> app/test/test_hash_readwrite_lf_perf.c | 2 +-
> drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 2 +-
> drivers/net/octeon_ep/cnxk_ep_rx_sse.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-09 0:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-04 23:03 [PATCH] replace use of word segregate in comments Stephen Hemminger
2024-10-08 9:53 ` Morten Brørup
2024-10-08 15:49 ` [PATCH v2] " Stephen Hemminger
2024-10-09 0:36 ` fengchengwen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).