From: "Morten Brørup" <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: thomas@monjalon.net, bruce.richardson@intel.com,
ktraynor@redhat.com,
"Jack Bond-Preston" <jack.bond-preston@foss.arm.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: RE: [PATCH 1/3] bitops: fix build for GCC without experimental API
Date: Tue, 15 Oct 2024 14:47:35 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F7DD@smartserver.smartshare.dk> (raw)
In-Reply-To: <20241015121046.2556695-2-david.marchand@redhat.com>
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Tuesday, 15 October 2024 14.11
>
> Building OVS against current DPDK fails with following warnings:
>
> In file included from .../ovs/dpdk-dir/include/rte_memory.h:18,
> from .../ovs/dpdk-dir/include/rte_ring_core.h:29,
> from .../ovs/dpdk-dir/include/rte_ring.h:37,
> from .../ovs/dpdk-dir/include/rte_mempool.h:49,
> from .../ovs/dpdk-dir/include/rte_mbuf.h:38,
> from lib/dp-packet.h:25,
> from lib/ofp-packet.c:20:
> .../ovs/dpdk-dir/include/rte_bitops.h: In function
> ‘__rte_bit_assign32’:
> .../ovs/dpdk-dir/include/rte_bitops.h:528:1: error:
> ‘__rte_bit_set32’ is deprecated: Symbol is not yet part of
> stable ABI [-Werror=deprecated-declarations]
> ...
>
> This comes from the fact that some (experimental) inline helpers
> are calling other experimental API.
> Hide those calls.
Are you saying that the compiler warns if some experimental function calls another experimental function?
I understand the fix, so I am wondering about consistency:
Do we generally hide experimental functions if building without ALLOW_EXPERIMENTAL_API?
Or do we only do it to inline functions?
An alternative solution is copy-pasting the inlined implementations of the called experimental functions into the functions calling them.
I generally don't like copy-paste, so probably even worse.
Anyway, this is a viable fix, so
Acked-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2024-10-15 12:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 12:10 [PATCH 0/3] Enhance headers check David Marchand
2024-10-15 12:10 ` [PATCH 1/3] bitops: fix build for GCC without experimental API David Marchand
2024-10-15 12:47 ` Morten Brørup [this message]
2024-10-15 12:10 ` [PATCH 2/3] bitset: " David Marchand
2024-10-15 12:53 ` Morten Brørup
2024-10-15 14:13 ` Thomas Monjalon
2024-10-15 14:44 ` Morten Brørup
2024-10-15 19:58 ` Thomas Monjalon
2024-10-15 20:30 ` Morten Brørup
2024-10-15 12:10 ` [PATCH 3/3] buildtools/chkincs: check headers with stable API only David Marchand
2024-10-16 11:38 ` [PATCH v2 0/4] Enhance headers check David Marchand
2024-10-16 11:38 ` [PATCH v2 1/4] bitops: fix build for GCC without experimental API David Marchand
2024-10-16 11:38 ` [PATCH v2 2/4] bitset: " David Marchand
2024-10-16 14:14 ` Mattias Rönnblom
2024-10-16 15:36 ` David Marchand
2024-10-16 15:42 ` Morten Brørup
2024-10-16 16:03 ` Mattias Rönnblom
2024-10-16 16:17 ` Thomas Monjalon
2024-10-16 15:51 ` Mattias Rönnblom
2024-10-16 11:38 ` [PATCH v2 3/4] vhost: remove internal vDPA API description from public header David Marchand
2024-10-16 11:47 ` Maxime Coquelin
2024-10-16 11:38 ` [PATCH v2 4/4] buildtools/chkincs: check headers with stable API only David Marchand
2024-10-16 20:40 ` [PATCH v2 0/4] Enhance headers check David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F7DD@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jack.bond-preston@foss.arm.com \
--cc=ktraynor@redhat.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).