From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Thomas Monjalon" <thomas@monjalon.net>
Cc: <dev@dpdk.org>, "Bruce Richardson" <bruce.richardson@intel.com>
Subject: RE: [PATCH] net: improve vlan header type alignment
Date: Fri, 18 Oct 2024 01:41:23 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F7F4@smartserver.smartshare.dk> (raw)
In-Reply-To: <7686686.jRhZ6ZUK3Y@thomas>
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, 17 October 2024 22.44
>
> 13/10/2024 10:35, Morten Brørup:
> > +static_assert(sizeof(struct rte_ether_addr) == 6,
> > + "sizeof(struct rte_ether_addr) == 6");
> > +static_assert(alignof(struct rte_ether_addr) == 2,
> > + "alignof(struct rte_ether_addr) == 2");
>
> Instead of repeating the condition twice,
> it would be simpler to use RTE_BUILD_BUG_ON
RTE_BUILD_BUG_ON can only be used in code blocks, so it would need to be wrapped in some dummy function.
next prev parent reply other threads:[~2024-10-17 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 8:35 Morten Brørup
2024-10-13 8:51 ` Morten Brørup
2024-10-14 5:42 ` fengchengwen
2024-10-14 8:04 ` Bruce Richardson
2024-10-17 20:44 ` Thomas Monjalon
2024-10-17 23:41 ` Morten Brørup [this message]
2024-10-18 9:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F7F4@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).