From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9E0D545B9F;
	Tue, 22 Oct 2024 12:46:10 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8DF484029A;
	Tue, 22 Oct 2024 12:46:10 +0200 (CEST)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 4EEA040273
 for <dev@dpdk.org>; Tue, 22 Oct 2024 12:46:09 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 27812206AE;
 Tue, 22 Oct 2024 12:46:09 +0200 (CEST)
Content-class: urn:content-classes:message
Subject: RE: [PATCH v3 00/22] replace strtok with reentrant version
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 Oct 2024 12:46:07 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F803@smartserver.smartshare.dk>
X-MimeOLE: Produced By Microsoft Exchange V6.5
In-Reply-To: <20231114110006.91148-1-haijie1@huawei.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v3 00/22] replace strtok with reentrant version
Thread-Index: AdoW6xyOz4dx+MH1TVObTwQ7rWS5zENg/DHw
References: <20231113104550.2138654-1-haijie1@huawei.com>
 <20231114110006.91148-1-haijie1@huawei.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Jie Hai" <haijie1@huawei.com>,
	<dev@dpdk.org>
Cc: <lihuisong@huawei.com>,
	<fengchengwen@huawei.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Jie Hai [mailto:haijie1@huawei.com]
> Sent: Tuesday, 14 November 2023 12.00
>=20
> Multiple threads calling the same function may cause condition
> race issues, which often leads to abnormal behavior and can cause
> more serious vulnerabilities such as abnormal termination, denial
> of service, and compromised data integrity.
>=20
> This patchset replaces strtok with strtok_s in app, example, lib

Typo: strtok_s -> strtok_r

> and drivers. And adds check for use of strtok in checkpatches.sh.
>=20
> --
> v3:
> 1. fix compile error.
> 2. use strtok_r instead.
> v2:
> 1. fix commit log.
> 2. add check in checkpatches.sh.
> 3. replace strtok_r with strtok_s.
> 4. add Acked-by.
> --

+1 to doing this, also in functions that are supposed to be single =
threaded; because it allows the addition to checkpatches.

Acked-by: Morten Br=F8rup <mb@smartsharesystems.com>