From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8179B45BC0;
	Thu, 24 Oct 2024 14:25:33 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 718F840281;
	Thu, 24 Oct 2024 14:25:33 +0200 (CEST)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id 692344003C
 for <dev@dpdk.org>; Thu, 24 Oct 2024 14:25:32 +0200 (CEST)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 37CBF2027D;
 Thu, 24 Oct 2024 14:25:32 +0200 (CEST)
Content-class: urn:content-classes:message
Subject: RE: [PATCH 6/6] drivers: use bitops API instead of compiler builtins
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 24 Oct 2024 14:25:30 +0200
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F815@smartserver.smartshare.dk>
X-MimeOLE: Produced By Microsoft Exchange V6.5
In-Reply-To: <20241024120535.2722316-7-david.marchand@redhat.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH 6/6] drivers: use bitops API instead of compiler builtins
Thread-Index: AdsmDSo6HRL3cRaISlmYDnvvI9/t+gAAlGDA
References: <20241024120535.2722316-1-david.marchand@redhat.com>
 <20241024120535.2722316-7-david.marchand@redhat.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>,
	<dev@dpdk.org>
Cc: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
 <stephen@networkplumber.org>, <mattias.ronnblom@ericsson.com>,
 "Chaoyong He" <chaoyong.he@corigine.com>,
 "Chengwen Feng" <fengchengwen@huawei.com>,
 "Srikanth Yalavarthi" <syalavarthi@marvell.com>,
 "Wathsala Vithanage" <wathsala.vithanage@arm.com>,
 "Ajit Khaparde" <ajit.khaparde@broadcom.com>,
 "Somnath Kotur" <somnath.kotur@broadcom.com>,
 "Chas Williams" <chas3@att.com>, "Min Hu (Connor)" <humin29@huawei.com>,
 "Apeksha Gupta" <apeksha.gupta@nxp.com>,
 "Sachin Saxena" <sachin.saxena@nxp.com>, "Jie Hai" <haijie1@huawei.com>,
 "Jingjing Wu" <jingjing.wu@intel.com>,
 "Dariusz Sosnowski" <dsosnowski@nvidia.com>,
 "Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
 "Bing Zhao" <bingz@nvidia.com>, "Ori Kam" <orika@nvidia.com>,
 "Suanming Mou" <suanmingm@nvidia.com>, "Matan Azrad" <matan@nvidia.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Thursday, 24 October 2024 14.06
>=20
> Stop using directly __builtin_ bit operations,
> prefer existing DPDK wrappers.
>=20
> Note: this is a brute sed all over drivers (skipping base drivers)
> for __builtin_* that have a direct replacement in EAL bitops.

There could be differences between 32 and 64 bit architectures.
Simple search-replace might not cut it.
Didn't review in detail, just speculating.

> There is more work to do, like adding some missing macros inspired =
from
> kernel (FIELD_*) macros but this is left for later.
>=20
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---