DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Robin Jarry" <rjarry@redhat.com>, <dev@dpdk.org>
Cc: "David Marchand" <david.marchand@redhat.com>
Subject: RE: [PATCH dpdk] net: enforce 2-bytes alignment on IPv6 headers
Date: Tue, 5 Nov 2024 13:27:47 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F87D@smartserver.smartshare.dk> (raw)
In-Reply-To: <20241105122508.425470-2-rjarry@redhat.com>

> From: Robin Jarry [mailto:rjarry@redhat.com]
> Sent: Tuesday, 5 November 2024 13.25
> 
> IPv6 headers are always aligned on a 2-bytes grid. Reflect this in the
> structure definition.
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
>  lib/net/rte_ip6.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/net/rte_ip6.h b/lib/net/rte_ip6.h
> index 3ae38811b27c..fea7d7b0cd73 100644
> --- a/lib/net/rte_ip6.h
> +++ b/lib/net/rte_ip6.h
> @@ -460,7 +460,7 @@ rte_ether_mcast_from_ipv6(struct rte_ether_addr
> *mac, const struct rte_ipv6_addr
>  /**
>   * IPv6 Header
>   */
> -struct rte_ipv6_hdr {
> +struct __rte_aligned(2) rte_ipv6_hdr {
>  	union {
>  		rte_be32_t vtc_flow;        /**< IP version, traffic class
> & flow label. */
>  		__extension__
> @@ -507,7 +507,7 @@ static inline int rte_ipv6_check_version(const
> struct rte_ipv6_hdr *ip)
>  /**
>   * IPv6 Routing Extension Header
>   */
> -struct rte_ipv6_routing_ext {
> +struct __rte_aligned(2) rte_ipv6_routing_ext {
>  	uint8_t next_hdr;			/**< Protocol, next header. */
>  	uint8_t hdr_len;			/**< Header length. */
>  	uint8_t type;				/**< Extension header type.
> */
> @@ -751,7 +751,7 @@ rte_ipv6_udptcp_cksum_mbuf_verify(const struct
> rte_mbuf *m,
>  #define RTE_IPV6_SET_FRAG_DATA(fo, mf)	\
>  	(((fo) & RTE_IPV6_EHDR_FO_MASK) | ((mf) & RTE_IPV6_EHDR_MF_MASK))
> 
> -struct rte_ipv6_fragment_ext {
> +struct __rte_aligned(2) rte_ipv6_fragment_ext {
>  	uint8_t next_header;	/**< Next header type */
>  	uint8_t reserved;	/**< Reserved */
>  	rte_be16_t frag_data;	/**< All fragmentation data */
> --
> 2.47.0

Reviewed-by: Morten Brørup <mb@smartsharesystems.com>


  reply	other threads:[~2024-11-05 12:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 12:25 Robin Jarry
2024-11-05 12:27 ` Morten Brørup [this message]
2024-11-05 12:33   ` Morten Brørup
2024-11-05 14:12 ` [PATCH dpdk v2] " Robin Jarry
2024-11-05 14:20   ` Morten Brørup
2024-11-06 20:23     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F87D@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=rjarry@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).