From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BA23B45F65;
	Sat, 28 Dec 2024 16:13:31 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 51FB640289;
	Sat, 28 Dec 2024 16:13:31 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id BFA5440280
 for <dev@dpdk.org>; Sat, 28 Dec 2024 16:13:29 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 51B21206AA;
 Sat, 28 Dec 2024 16:13:29 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v7 01/29] devtools: check packed attributes
Date: Sat, 28 Dec 2024 16:13:28 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F978@smartserver.smartshare.dk>
In-Reply-To: <1734981122-4729-2-git-send-email-andremue@linux.microsoft.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v7 01/29] devtools: check packed attributes
Thread-Index: AdtVbpYfGYdLfX8aQ6OMKoV0V+sWFgDyK/DA
References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com>
 <1734981122-4729-1-git-send-email-andremue@linux.microsoft.com>
 <1734981122-4729-2-git-send-email-andremue@linux.microsoft.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Andre Muezerie" <andremue@linux.microsoft.com>,
 <roretzla@linux.microsoft.com>
Cc: <aman.deep.singh@intel.com>, <anatoly.burakov@intel.com>,
 <bruce.richardson@intel.com>, <byron.marohn@intel.com>,
 <conor.walsh@intel.com>, <cristian.dumitrescu@intel.com>,
 <david.hunt@intel.com>, <dev@dpdk.org>, <dsosnowski@nvidia.com>,
 <gakhil@marvell.com>, <jerinj@marvell.com>, <jingjing.wu@intel.com>,
 <kirill.rybalchenko@intel.com>, <konstantin.v.ananyev@yandex.ru>,
 <matan@nvidia.com>, <orika@nvidia.com>, <radu.nicolau@intel.com>,
 <ruifeng.wang@arm.com>, <sameh.gobriel@intel.com>,
 <sivaprasad.tummala@amd.com>, <skori@marvell.com>,
 <stephen@networkplumber.org>, <suanmingm@nvidia.com>,
 <vattunuru@marvell.com>, <viacheslavo@nvidia.com>,
 <vladimir.medvedkin@intel.com>, <yipeng1.wang@intel.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Andre Muezerie [mailto:andremue@linux.microsoft.com]
> Sent: Monday, 23 December 2024 20.12
>=20
> Ensure __rte_packed_begin and __rte_packed_end show up in pairs
> when checking patches.
>=20
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---

With GCC, __rte_packed could also be used with enums [1], to reduce =
their size.

The release notes coming with this patch series should mention that this =
is no longer possible.

Suggest that this script also checks that __rte_packed_begin is not =
preceded by "enum" (and whitespace).
(A structure packed with __rte_packed_begin might also be =
__rte_aligned(), and these two attributes may come in any order, so =
checking for "struct"+whitespace would introduce an ordering requirement =
for these two attributes.)

[1] =
https://gcc.gnu.org/onlinedocs/gcc/Common-Type-Attributes.html#index-pack=
ed-type-attribute