RE: [PATCH v12 1/3] lib/eal: add diagnostics macros to make code portable

["Morten Brørup" <mb@smartsharesystems.com>]

> +/*
> + * Macro to ignore whenever a pointer is cast so as to remove a type
> + * qualifier from the target type.
> + */

This description could be better, something like the push/pop description:
"Macro to disable compiler warnings about ..."

> +#if !defined __INTEL_COMPILER && !defined RTE_TOOLCHAIN_MSVC

Prefer defined(NAME) over defined NAME.
Same for the description of push/pop below.
(I see both in rte_common.h, so perhaps it's just my personal preference.)

> +#define __rte_diagnostic_ignored_wcast_qual \
> +		_Pragma("GCC diagnostic ignored \"-Wcast-qual\"")
> +#else
> +#define __rte_diagnostic_ignored_wcast_qual
> +#endif
> +
> +/*
> + * Macros to cause the compiler to remember the state of the diagnostics as of
> + * each push, and restore to that point at each pop.
> + */
> +#if !defined __INTEL_COMPILER && !defined RTE_TOOLCHAIN_MSVC
> +#define __rte_diagnostic_push _Pragma("GCC diagnostic push")
> +#define __rte_diagnostic_pop  _Pragma("GCC diagnostic pop")
> +#else
> +#define __rte_diagnostic_push
> +#define __rte_diagnostic_pop
> +#endif


> +#define RTE_IGNORE_CAST_QUAL(X) \
> +	((uintptr_t)(X))

A description of this macro is missing.
Rather than assign a name that refers to the name of compiler's warning, could you come up with a name that describes what the macro does to X, i.e. discards qualifiers.
And if the macro is exclusively for pointers, perhaps it should have PTR somewhere in its name.

And do we really need this macro? Can't RTE_CAST_FIELD() be used instead?

Or can we make the macro more like RTE_CAST_FIELD()?
Perhaps RTE_CAST(var, type)?

Or maybe, inspired by RTE_PTR_ADD():
#define RTE_PTR(var) ((void*)((uintptr_t)(ptr)))
#define RTE_CONST_PTR(var) ((const void*)((uintptr_t)(ptr)))