From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Andre Muezerie" <andremue@linux.microsoft.com>
Cc: <dev@dpdk.org>, <fanzhang.oss@gmail.com>, <gakhil@marvell.com>
Subject: RE: [PATCH v2 2/2] lib/hash: avoid implicit conversion to 64 bit number
Date: Mon, 27 Jan 2025 18:16:29 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F9F7@smartserver.smartshare.dk> (raw)
In-Reply-To: <1737993833-22957-2-git-send-email-andremue@linux.microsoft.com>
> From: Andre Muezerie [mailto:andremue@linux.microsoft.com]
> Sent: Monday, 27 January 2025 17.04
>
> MSVC issues the warnings below:
>
> 1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
>
> The code would be better off by using 64 bit numbers to begin with.
> That eliminates the need for a conversion to 64 bits later.
>
> 2) ../lib/hash/rte_thash.c(568): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
>
> Instead of multiplying sizeof(uint32_t) by the result of shifting
> "1", sizeof(uint32_t) can be shifted directly.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2025-01-27 17:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 1:53 [PATCH 1/2] lib/cryptodev: " Andre Muezerie
2024-11-28 1:53 ` [PATCH 2/2] lib/hash: " Andre Muezerie
2025-01-22 16:12 ` Bruce Richardson
2025-01-22 21:36 ` Andre Muezerie
2025-01-23 7:55 ` Morten Brørup
2025-01-23 17:42 ` Andre Muezerie
2025-01-25 12:56 ` Morten Brørup
2025-01-22 16:15 ` Medvedkin, Vladimir
2025-01-08 10:28 ` [EXTERNAL] [PATCH 1/2] lib/cryptodev: " Akhil Goyal
2025-01-27 16:03 ` [PATCH v2 " Andre Muezerie
2025-01-27 16:03 ` [PATCH v2 2/2] lib/hash: " Andre Muezerie
2025-01-27 17:16 ` Morten Brørup [this message]
2025-01-27 17:14 ` [PATCH v2 1/2] lib/cryptodev: " Morten Brørup
2025-01-27 19:36 ` Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 1/3] " Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 2/3] lib/hash: " Andre Muezerie
2025-01-27 19:33 ` [PATCH v3 3/3] drivers/crypto: use RTE_BIT64 in initializations of hash_algos Andre Muezerie
2025-01-28 7:45 ` Morten Brørup
2025-01-28 7:49 ` Anoob Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F9F7@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).