From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF5DA460EE; Tue, 28 Jan 2025 08:45:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BACC40150; Tue, 28 Jan 2025 08:45:48 +0100 (CET) Received: from dkmailrelay1.smartsharesystems.com (smartserver.smartsharesystems.com [77.243.40.215]) by mails.dpdk.org (Postfix) with ESMTP id 6182940144 for ; Tue, 28 Jan 2025 08:45:47 +0100 (CET) Received: from smartserver.smartsharesystems.com (smartserver.smartsharesys.local [192.168.4.10]) by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id E1FB6251D7; Tue, 28 Jan 2025 08:45:46 +0100 (CET) Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH v3 3/3] drivers/crypto: use RTE_BIT64 in initializations of hash_algos Date: Tue, 28 Jan 2025 08:45:45 +0100 Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F9F9@smartserver.smartshare.dk> X-MimeOLE: Produced By Microsoft Exchange V6.5 In-Reply-To: <1738006389-17193-3-git-send-email-andremue@linux.microsoft.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH v3 3/3] drivers/crypto: use RTE_BIT64 in initializations of hash_algos Thread-Index: Adtw8lG0b79VtwE+Q9ewhZNfAcoznAAZclpA References: <1732758837-6350-1-git-send-email-andremue@linux.microsoft.com> <1738006389-17193-1-git-send-email-andremue@linux.microsoft.com> <1738006389-17193-3-git-send-email-andremue@linux.microsoft.com> From: =?iso-8859-1?Q?Morten_Br=F8rup?= To: "Andre Muezerie" , "Kai Ji" , "Ankur Dwivedi" , "Anoob Joseph" , "Tejasree Kondoj" Cc: , , X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Andre Muezerie [mailto:andremue@linux.microsoft.com] > Sent: Monday, 27 January 2025 20.33 >=20 > This was found during code review of similar issues. >=20 > Signed-off-by: Andre Muezerie > --- Reviewed-by: Morten Br=F8rup CNXK crypto & OpenSSL crypto driver maintainers, please review/ack. > drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 4 ++-- > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c > b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c > index 4394513002..e78bc37c37 100644 > --- a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c > +++ b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c > @@ -1207,8 +1207,8 @@ static const struct rte_cryptodev_capabilities > caps_eddsa[] =3D { > {.asym =3D { > .xform_capa =3D { > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_EDDSA, > - .hash_algos =3D (1 << RTE_CRYPTO_AUTH_SHA512 | > - 1 << RTE_CRYPTO_AUTH_SHAKE_256), > + .hash_algos =3D > (RTE_BIT64(RTE_CRYPTO_AUTH_SHA512) | > + > RTE_BIT64(RTE_CRYPTO_AUTH_SHAKE_256)), > .op_types =3D ((1 << RTE_CRYPTO_ASYM_OP_SIGN) | > (1 << RTE_CRYPTO_ASYM_OP_VERIFY)) > } > diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c > b/drivers/crypto/openssl/rte_openssl_pmd_ops.c > index 18f096abfd..04e018f3df 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c > @@ -630,8 +630,8 @@ static const struct rte_cryptodev_capabilities > openssl_pmd_capabilities[] =3D { > {.asym =3D { > .xform_capa =3D { > .xform_type =3D RTE_CRYPTO_ASYM_XFORM_EDDSA, > - .hash_algos =3D (1 << RTE_CRYPTO_AUTH_SHA512 | > - 1 << RTE_CRYPTO_AUTH_SHAKE_256), > + .hash_algos =3D > (RTE_BIT64(RTE_CRYPTO_AUTH_SHA512) | > + > RTE_BIT64(RTE_CRYPTO_AUTH_SHAKE_256)), > .op_types =3D > ((1< (1 << RTE_CRYPTO_ASYM_OP_VERIFY)), > -- > 2.47.2.vfs.0.1