RE: rte_lcore_has_role() return value

["Morten Brørup" <mb@smartsharesystems.com>]

Hi Vipin,

No need. Pavan fixed it already:
https://patchwork.dpdk.org/project/dpdk/patch/20250520201726.7420-1-pbhagavatula@marvell.com/

-Morten

> From: Varghese, Vipin [mailto:Vipin.Varghese@amd.com]
> Sent: Tuesday, 3 June 2025 08.08
> 
> [Public]
> 
> Hi @Morten Brørup
> 
> Would you need me to check this under `rte_topology` pcoming patches?
> 
> > From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > Sent: Monday, May 19, 2025 7:46 PM
> >
> > Caution: This message originated from an External Source. Use proper
> caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > My bad, I got it confused with lcore topology patches.
> >
> > I will look into this.
> >
> > Thanks,
> > Pavan.
> >
> > > From: Pavan Nikhilesh Bhagavatula
> > > Sent: Monday, May 19, 2025 7:32 PM
> > >
> > > Hi Morten,
> > >
> > > Looks like this is meant for Vipin.
> > >
> > > +Vipin
> > >
> > > Thanks,
> > > Pavan.
> > >
> > > > Pavan,
> > > >
> > > > The rte_lcore_has_role() documentation says it returns bool.
> > > >
> > > > Its implementation returns a true value (-1) if given a
> > > > non-compliant
> > > lcore_id,
> > > > e.g. LCORE_ID_ANY.
> > > >
> > > > I think it should behave like rte_lcore_is_enabled(), i.e. return
> > > > false if given a non-compliant lcore_id, e.g. LCORE_ID_ANY.
> > > >
> > > > Use case:
> > > > A control thread in an application might or might not register
> > > > itself, and the registration might not succeed.
> > > >
> > > > At exit of this control thread, it should unregister itself if
> registered.
> > > >
> > > > Fixing rte_lcore_has_role() as suggested would simplify the
> > > > application from
> > > > this:
> > > >
> > > >     if (rte_lcore_id() != LCORE_ID_ANY &&
> > > >                     rte_eal_lcore_role(rte_lcore_id()) ==
> ROLE_NON_EAL)
> > > >             rte_thread_unregister();
> > > >
> > > > To this:
> > > >
> > > >     if (rte_lcore_has_role(rte_lcore_id(), ROLE_NON_EAL))
> > > >             rte_thread_unregister();
> > > >
> > > > -Morten