From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Ivan Malov" <ivan.malov@arknetworks.am>
Cc: <dev@dpdk.org>, "Thomas Monjalon" <thomas@monjalon.net>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Konstantin Ananyev" <konstantin.ananyev@huawei.com>
Subject: RE: [PATCH] ethdev: Reject conflicting TX offloads configuration
Date: Thu, 31 Jul 2025 11:34:13 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9FDD9@smartserver.smartshare.dk> (raw)
In-Reply-To: <a2542c91-6a37-94c3-98e9-c237dc0c1d5b@arknetworks.am>
> From: Ivan Malov [mailto:ivan.malov@arknetworks.am]
> Sent: Thursday, 31 July 2025 11.28
>
> Hi Morten,
>
> On Thu, 31 Jul 2025, Morten Brørup wrote:
>
> > + RTE_ETHDEV_LOG_LINE(ERR,
> > + "Ethdev port_id=%d Tx offload %s conflicts with Tx offload
> %s",
>
> Is it required to spell 'Ethdev ' at start of the line? It was my impression
> that 'ethdev' would be printed anyway by [1] (the '# t' part). Am I wrong?
>
> [1]
> https://github.com/DPDK/dpdk/blob/b222395561638f89562e4ef42e1eabf2d6db43dd/lib
> /log/rte_log.h#L334
You are right, but all the other RTE_ETHDEV_LOG_LINE() in rte_eth_dev_configure() do it, so I did it too.
next prev parent reply other threads:[~2025-07-31 9:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 9:07 Morten Brørup
2025-07-31 9:24 ` Bruce Richardson
2025-07-31 10:07 ` Andrew Rybchenko
2025-07-31 9:27 ` Ivan Malov
2025-07-31 9:34 ` Morten Brørup [this message]
2025-07-31 11:32 ` Konstantin Ananyev
2025-07-31 12:56 ` [PATCH v2 1/3] testpmd: Do not enable mbuf fast release TX offload by default Morten Brørup
2025-07-31 12:56 ` [PATCH v2 2/3] ethdev: Improve descriptions of RX and TX offloads Morten Brørup
2025-07-31 12:56 ` [PATCH v2 3/3] ethdev: Reject conflicting TX offloads configuration Morten Brørup
2025-08-01 1:09 ` zhoumin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9FDD9@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ivan.malov@arknetworks.am \
--cc=konstantin.ananyev@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).