From: "Niu, Yawei" <yawei.niu@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Harris, James R" <james.r.harris@intel.com>,
"Vanda, Sydney M" <sydney.m.vanda@intel.com>
Subject: [dpdk-dev] FW: [SPDK] Re: Potential defect in pci_unplug()
Date: Tue, 29 Sep 2020 01:15:56 +0000 [thread overview]
Message-ID: <98D9624D-F475-425B-9B06-F13CD9C4884C@intel.com> (raw)
In-Reply-To: <748FDEF7-6BB0-4D27-B630-4C991D06B6F8@intel.com>
On 2020/9/28, 11:44 PM, "Harris, James R" <james.r.harris@intel.com> wrote:
Hi Niu,
I agree, this doesn't look right. Could you file an SPDK issue for this to make sure we track it? And then try sending an e-mail to the DPDK mailing list? I'm open to submitting a patch to our DPDK submodule short-term, but only if we get agreement with DPDK community that this fix is correct.
Thanks,
Jim
On 9/28/20, 12:17 AM, "Niu, Yawei" <yawei.niu@intel.com> wrote:
Hi,
In the pci_unplug() (dpdk/drivers/bus/pci/pci_common.c), why do we call rte_devargs_remove() to remove the saved device args? That looks a defect to me, since that’ll result in the hot removed device failed to be detected when it’s plugged back (when white list option was provided), the situation is described following:
1. App starts with white list option provided, let’s suppose the device in white list is: 0000:81:00.0;
2. rte_devargs_add() is called to add this device arg on rte_eal_init();
3. Issue “echo 1 > /sys/bus/pci/devices/0000\:81\:00.0/remove” to hot remove the device;
4. pci_unplug() is called to remove the device, and rte_devargs_remove() is called, so this device arg for white list is remove too;
5. Issue “echo 1 > /sys/bus/pci/rescan” then “PCI_WHITELIST=”0000:81:00.0” spdk/script/setup.sh” to do hot plug;
6. In pci_scan_one(), new dev is generated, however, the dev->device.devargs is set NULL since the device args has been removed on device unplug;
7. rte_pci_probe() does white list scan, however, it unexpectedly skips the device because the devargs of the device is NULL now;
I don’t fully understand the DPDK code, but this rte_devargs_remove() in pci_unplug() doesn’t make sense to me (when I commented it out, seems everything will work as expected). Is this a glitch or I missed anything?
Thanks
-Niu
_______________________________________________
SPDK mailing list -- spdk@lists.01.org
To unsubscribe send an email to spdk-leave@lists.01.org
_______________________________________________
SPDK mailing list -- spdk@lists.01.org
To unsubscribe send an email to spdk-leave@lists.01.org
next parent reply other threads:[~2020-09-30 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <748FDEF7-6BB0-4D27-B630-4C991D06B6F8@intel.com>
2020-09-29 1:15 ` Niu, Yawei [this message]
2020-10-09 16:09 ` Gaëtan Rivet
2020-10-13 4:31 ` Niu, Yawei
2020-10-13 23:05 ` Harris, James R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98D9624D-F475-425B-9B06-F13CD9C4884C@intel.com \
--to=yawei.niu@intel.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
--cc=sydney.m.vanda@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).