From: Vithal Mohare <vmohare@arubanetworks.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] dev stop and buffer releases
Date: Tue, 12 Apr 2016 05:19:13 +0000 [thread overview]
Message-ID: <98DB008FA2AC6644B40AD8C766FAB271021FA2EE55@PWSN02.arubanetworks.com> (raw)
Team,
Hit a crash while vmxnet_xmit_pkts()-->vmxnet3_tq_tx_complete() API trying to release completed buffers.
As we see in the code, there are two independent paths that clean up completed buffers: 1) vmxnet3_xmit_pkts 2) vmxnet3_dev_stop. In a multi-threaded environment potentially this can cause issues since queues/buffers not guarded with any locks. Specifically, in my case, one thread handles admin messages like port shut and hence triggers vmxnet3_dev_stop. Another thread for forwarding (vmxnet3_xmit_pkts). Isn't this a candidate for introducing locks within drivers? Any other suggestions to handle it?
Thanks,
-Vithal
reply other threads:[~2016-04-12 5:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98DB008FA2AC6644B40AD8C766FAB271021FA2EE55@PWSN02.arubanetworks.com \
--to=vmohare@arubanetworks.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).