From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx02.arubanetworks.com (sjcbarracuda02.arubanetworks.com [104.36.248.60]) by dpdk.org (Postfix) with ESMTP id 164FF2E81 for ; Tue, 12 Apr 2016 07:19:16 +0200 (CEST) X-ASG-Debug-ID: 1460438354-03d13446aa45f220001-TfluYd Received: from PWSN01.arubanetworks.com ([10.44.96.51]) by mx02.arubanetworks.com with ESMTP id w38CGkOxPxnFlcaw (version=TLSv1.2 cipher=AES128-SHA256 bits=128 verify=NO) for ; Mon, 11 Apr 2016 22:19:14 -0700 (PDT) X-Barracuda-Envelope-From: vmohare@arubanetworks.com Received: from PWSN02.arubanetworks.com ([fe80::6c58:60ca:c422:ac39]) by PWSN01.arubanetworks.com ([fe80::e0ab:cda5:ff39:46c2%31]) with mapi id 14.03.0266.001; Mon, 11 Apr 2016 22:19:14 -0700 From: Vithal Mohare To: "dev@dpdk.org" Thread-Topic: dev stop and buffer releases X-ASG-Orig-Subj: dev stop and buffer releases Thread-Index: AdGUeAaHs3YeiT60RNymautRk8DrIQ== Date: Tue, 12 Apr 2016 05:19:13 +0000 Message-ID: <98DB008FA2AC6644B40AD8C766FAB271021FA2EE55@PWSN02.arubanetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.22.25] MIME-Version: 1.0 X-Barracuda-Connect: UNKNOWN[10.44.96.51] X-Barracuda-Start-Time: 1460438354 X-Barracuda-Encrypted: AES128-SHA256 X-Barracuda-URL: https://mx01.arubanetworks.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at arubanetworks.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=7.0 tests=HTML_MESSAGE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.28657 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 HTML_MESSAGE BODY: HTML included in message Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] dev stop and buffer releases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2016 05:19:16 -0000 Team, Hit a crash while vmxnet_xmit_pkts()-->vmxnet3_tq_tx_complete() API trying = to release completed buffers. As we see in the code, there are two independent paths that clean up comple= ted buffers: 1) vmxnet3_xmit_pkts 2) vmxnet3_dev_stop. In a multi-threa= ded environment potentially this can cause issues since queues/buffers not = guarded with any locks. Specifically, in my case, one thread handles admi= n messages like port shut and hence triggers vmxnet3_dev_stop. Another thr= ead for forwarding (vmxnet3_xmit_pkts). Isn't this a candidate for introd= ucing locks within drivers? Any other suggestions to handle it? Thanks, -Vithal