From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0044.outbound.protection.outlook.com [104.47.38.44]) by dpdk.org (Postfix) with ESMTP id CB21510E22 for ; Fri, 23 Dec 2016 12:35:54 +0100 (CET) Received: from BN6PR03CA0050.namprd03.prod.outlook.com (10.173.137.12) by BN6PR03MB2466.namprd03.prod.outlook.com (10.168.223.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11; Fri, 23 Dec 2016 11:35:53 +0000 Received: from BN1BFFO11FD031.protection.gbl (2a01:111:f400:7c10::1:105) by BN6PR03CA0050.outlook.office365.com (2603:10b6:404:4c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11 via Frontend Transport; Fri, 23 Dec 2016 11:35:53 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD031.mail.protection.outlook.com (10.58.144.94) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.789.10 via Frontend Transport; Fri, 23 Dec 2016 11:35:53 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uBNBZoAZ005231; Fri, 23 Dec 2016 04:35:51 -0700 To: Jan Blunck References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> <1482332986-7599-22-git-send-email-jblunck@infradead.org> <20161221120953.0282b531@xeon-e3> CC: Stephen Hemminger , , David Marchand From: Shreyansh Jain Message-ID: <98a51662-0c77-1b79-2980-8a8dfcf6f100@nxp.com> Date: Fri, 23 Dec 2016 17:09:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131269665534966172; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39450400003)(39840400002)(39850400002)(39410400002)(39380400002)(39860400002)(39400400002)(2980300002)(1109001)(1110001)(339900001)(189002)(377454003)(24454002)(199003)(31696002)(8676002)(81166006)(305945005)(8936002)(33646002)(31686004)(93886004)(2906002)(230700001)(4326007)(356003)(4001350100001)(97736004)(50466002)(189998001)(64126003)(229853002)(68736007)(38730400001)(23676002)(110136003)(47776003)(86362001)(65806001)(65956001)(104016004)(54356999)(65826007)(36756003)(81156014)(92566002)(77096006)(105606002)(85426001)(83506001)(106466001)(76176999)(5660300001)(69596002)(50986999)(6916009)(626004)(6666003)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2466; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD031; 1:HL0r2JbQmMaW+yY5XZl4uTDSn5TM7aiyDTXCfbAXklr5Kuh2qDA+MStI56FiSGaJ7dgSVt776CmwAtpY9ZfjyXvBu8ibUgftZ3Z4GmLJZcMoFVyclQzktzo/iXmJzDLavEHpTjO38JJ2EXvCoQpsPemiHc1g37fyfflq+NT9fgmQevAf5yWnKB0sMXJMJp+bOEkU02Up0BagjD10OsitTQskPReVlwWK9IQQjaQBpLPy7AfC63LAsxDfxxRT2k1ER/bZEHt4yJyKxSw3nOJsr1OBkzwDXTjxEbqvfpFfRJiDWQWulmxeWA1zoHzqhSx7RFLBh3ieZZqotkDXPCfw7SSo7GaD//qQt1e6jV03kcXB5g1N/CDr/ZEk+e/mFnZ4nq1pyydQNOwFEI5CM1ruUm6swQAhrek+lG5AluHwIF/d+9HXn7pZqXgKZef1v8vk3tARKX7JszudUi4kWf1Ep73yu6WQQ3AO+ZkpZeqvKuHsfVZmNk3+3wt/pqwD157d7UyaugITLunN8P7l9eHbRxaA0L9BsIOvo4GMouzlVQjzAFjAUllmLAk36ph03HxYPuC3CnRa0yiLnFLp1KTgYpZzVdbhhIWSZ2k3z8Lu/t8= X-MS-Office365-Filtering-Correlation-Id: 36fa6208-9564-45eb-f99c-08d42b27da75 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR03MB2466; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 3:KiD6eQeTnQg6TVGJguHNBv3vfZmpbKfMSN8SvVbPi5ji0B003hGOBMzTAR6Isxf7pl2ujh5vV7PbQF/64lUAHuXCWk86L0ieOcKBHnUUgmoRjZGHyULF0u3d8iAOUSy1R3C00BihUsUxaocUgZetKJVI6CyvmQjpGmUuuPRnPiCApYApkmWHJxC97qxLV9VwySI3/i4WkybI3xdLcP1yyc+isZaEu5liYcmWIV2Kf/N0UutrV5GoO50vMztkzmvzrphbsD1d9GFgl8mgES1fhLBPgACpQsDyzvD+WsBQu+r7WTHpdEhm1p7oQRUOZ2oHIdYVjp9iBHYdBdk+KmFna3xR5srkkr0frkRry8dQMm6DWYH49JaMM2GgWqODEnL2 X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 25:tNRmU5/+oaV0fbzxVa4PK/LfElX2mjplgFpPuiiqIs5B0LjM6LsG9nv1FUqaYu9+sHud4YYIDQcvOiobgj5xEoY5Rp6SGplOZws7GMxWtA43LAHQbGVXJjEcevQd8FlGD+LIwZ6zfns07wJBSrgn/z5tWrm0sP5ehhkzy7DvCIu1xD6tZShFUWlksDaAZ6LF6y3oaTIrv4Luqa651gaQUTdaYYQa9+1XmypKRCZG7ByEi4iu7CPQyJMihqHXmpZ/+cd4lbgtRMqGII1jiHIjAkr9b9VvqA3EweH7ycxACSv7wKSnLA/ao+xdO/Sq36J3XZ06mqPluLD2TZdp1J4Kkx+2bx/eDth4xSTuc3K0k0XuVgkZWf1cHHUjWmVTLcJENnMgTiOF65ZjnMavASoT6siGn5jvyM6be+UAMMB9wVCoijL67Qoezn7ZBXZu8QBjuyhO6IUZEfBeX+1fIoNsqyCw95iiFdrL06FizWuKoH+Q0WZJqXxPp1tU1Ao7LcnrV5FQUv2W0SKRuZCIH7c3E8kuyByTwnrUDYGPccacm79Wq+KljEBxcUWy/9DtdVCT1PDi29B1xSkzOFrfXdwJqBa9Ja1t/07JwfPhLc7+i9UconaN38BodN9A1mTRjJBL3vMLJbKFfD5QGBMXkHM7I9qVBPBmHl44l1ZaduoFu0XUMvCeuFctEecFRRUtIp1G+cY/RE++axH37pJqdr/DyPvudyy+BHWQXxNTkTVeqyq/GzdkT2OU2j5bBEwI7oOxdBBRdpyIuDRbxMnjxzgQ4Q== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 31:da7eVDwOiqVGGsGituOGZK4mpApVPY1L2XerS/3UWJ1gULwk0a4pXeDZbgnoJVKrAYdJG1Bkc5BMDrRrCiM12l/xnaomrTymjHLaH2NHL3sZJoqjfh7lmI2Ct3dM3ItOOS5y1u5Ph3TrQuFVso/YJiCBHO0XdtF5dtJTT9oYfQY3SfCyUOwIdkFIEp3qGd9gcVogS31IWdqjl4tfaBnvxk8hqB5aUwaDnWzD/4sSIx/e4LCvVD8PWuWZFeehMXy8A7ithTez0FLxOIOTkDBbZw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13023025)(13024025)(8121501046)(5005006)(13017025)(13015025)(13018025)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123556025)(20161123563025)(20161123559025)(20161123565025); SRVR:BN6PR03MB2466; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2466; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 4:XhW2xF3VMzhYEgXrPYwXTVdnxdrAujZcLIaVvr1y8bSSfan/NNawNl5X9MSEzP2CKK2i4R3Qo9jg4rhMestiHQ5jFAbYqiPfJiEFwct4kkHlPIzY7Z4n5Dp+m3lXijmW2hibywbQ4YSzGfSLoK6jawE8c2PzTNYHwrHsLs1AVYnlJskrpKddaRN8OKBKDKqLdcDx9XYrVOdqxhka0K3k3KiNZEnVUGV3eeSJt6CFIUXedpjrfe/LKFMiUEu/4VAGZZQhc5R0Fa0+pFmPofORZ1DkLr7e7uAxWmVqoonQZx5x/3gTD3FEJDrb5nOePOpnueK4kFgetYdRPEZE66u0lI8agrj7AAPdORYCs2S+3VygUiogo4b97dkgKNr9s0LHFbgU4bG8FoMWkMIIr4jRXXHtG5z6/9FX/9qvRcuK5g3p0OErgRn74bwzn5rkw6B2Xl5bSGPOBueayyW4B69kyMRjL5j2rrdBQ3fkuo9Fgn/k/7wCL6tjse+OqwjbKBqQ1iXwpgqOo0NfRszTkksrqWQUymObPAKjLPf0MtfBHMgK80EThs5L5lAIFHVX8xT8NcAtyLmwGiiSUv7jf9+u1+OldYXdUcK5MTYvL9e8uvwq9H0MmFoudpsl7UHk6HuzgM50389/P0/cfPqRXbd126PAOUXeVSzQ6LobwJet33vJ5vdkyIKe5q1E3YegrrQmbcQaxbaxV9rKCyeZE5VGZSRvY++9LFEHztXSrmmI2Lm7PvIV+ONaefIFc+ssEaYh X-Forefront-PRVS: 016572D96D X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNDY2OzIzOmtkcTdkQzR4OEdDNzlMUjk3ZEV2RE80U21l?= =?utf-8?B?T2U2OEVjYy9ZYytlNGdJTDJ3N01uM01Nd2w3TTFqRFQ1S1FFTWovNTFYUm0v?= =?utf-8?B?Ny90anBrUHhabGxFRkJ6L0M4alFUOFkwRC85bDkvbGlkeXEyVzNMZExoc0V3?= =?utf-8?B?Z21uUXdXMDg1WWYyVVBOeWJOTTFIZmQ1d0hUVHU1enQvbWJpNUZub0tMZldE?= =?utf-8?B?WHZ5cWJQMTVqbEJuQ0NmaXVsNHBtNWlEMjRTenkvbUx4RUQ0MjJyYmVqRHlz?= =?utf-8?B?aHJNOUNKeG9ON1Nzd0xlam5pOG1CRVlBODBTM2VPVVNSSU1OOXlMZ3YvQXhH?= =?utf-8?B?RlBzKzZRVlIvdHV2b2NZWlZ5NmpHaE1PSlRIM0dzUnBJVkJaeDFNV3JuNHBy?= =?utf-8?B?NDlOVFg4c21OMjJieXZ1Nkc2TGNRLzI4ZkkvSTMwZ29neURDWFlLVzI1ajls?= =?utf-8?B?RG1abFhzaWhreWQxRUdMUWw2eVZ6Qkxxd0dDTS8zRzRpUVFRT0dTbE4yU3hF?= =?utf-8?B?VEQ0djBoSTNGUE10K1NkUjFSREpMMjN4YVdVRnZYYi91MmhvWkZXNnVCZ09S?= =?utf-8?B?RFdtSDVWSEpYYWQyaXVpWnVERkF3RVNDZXNzZlMyOGhoVmY0M2NTa2VZYXFp?= =?utf-8?B?QUgwbHpHU1JoZ0ppTmFDajlreXBwa3Jad05YSmtCZ3pBYm5DWlB5R2VjVVlx?= =?utf-8?B?M3U3emVTU2RJVzY3RGRMeTJIcWlSYUprRzZYZGxUbENMNEFTK1hBQ1ZCUWlS?= =?utf-8?B?ZjN0aGJ4MVJEaWRRV0E0bmxTcVJyS1RVVi9zbDltVm1meXAyeGplRW9CVGQ3?= =?utf-8?B?M3hxREkzUy9GWS92RCtRV3NqaWM1Z08xbXpzd3o2SzhmK3B6cXhOSTd3ZEFB?= =?utf-8?B?b2pIY2UzSjBOb1hwV1R2cjBlcFN6Z1FiZkp5cVdJdXhDdlNDNmhvazV3VUFH?= =?utf-8?B?QlgvRXpGSDdRVENoZkdYNWwxcU9Sa0xUdmo3VHBaYlJFaG81MmtKNnVNZXZC?= =?utf-8?B?TTlMTzE1WWg4c3NEdmZmL2pEbVhRMUFueEtmRldRMHFxMzF4VG5QR1RtNjN1?= =?utf-8?B?clowd0NCZ0MybEpFQnBsK1JaOXFWbWFHSHpiVzlsRGZVaDNtSUY0OHMzMTBK?= =?utf-8?B?UXpLQTRjMkNDZXlJNXF0Um5RM2RSbG9Sclg2OXVaWnNmSWZOYnBhV3daRXk1?= =?utf-8?B?ODhtN2lMbzBIYW8wS2dCZ0FTSVRUTHlBNXVDWDJuSi81dllXS1VnRW1Fd2xu?= =?utf-8?B?bDFKK0VnSFN4RDAramNaRkwycHozMTNqWmxhSllNa3ErK3M3dWtaZjkwUWlY?= =?utf-8?B?TnFkTmFBalN5am8zbGFMdy9xbG84VnZjV25mTTIvMG9QVVZCelZCcWxPM25w?= =?utf-8?B?Y0xOMkFvVmkxYlozYnJBc3hTSEYwbkNIQ1c5UzcxaUFLSFAwSTBFS3ByYW83?= =?utf-8?B?TGdITEtURUFjNmZheDVSSWxZTUhWTGtTRWtIaTVZYXNadHRGRDF5eDhqUzNa?= =?utf-8?B?enBONkYxSWNJZ25MeWFsaG9HMEJudWNkOEg0YXJFYTBuTkRqNkR4UVcxQXQz?= =?utf-8?B?ZCtSbHEwQThpekRiM3lacWlPdzNSUTYrSk85WTBmc3dVbWR6dXVWOVV0cWp0?= =?utf-8?B?VjJVbklNZk9uRTFTVE1vL1dyZ1YvUlBQTEhlQ21qSWFnTXc5czJCQm9zTm81?= =?utf-8?B?WGxhZ084S1BPVmc4aGpmZytXU0prS1VWZlVBQ2dmM3FsTnZLbiswV00zaFpl?= =?utf-8?B?OGM4K3A0a2NHQzJKQlNJMmRKQmpGWmdmMllUZW43RC9tZnpJYUZwMWRGWUwx?= =?utf-8?B?V05hdFZ1bU1zZ0tMdm5lcWJuWGRrTTc4Zm9DWDU0M3doUkpXcVRhMzlHdTNv?= =?utf-8?B?R3hYN0pRdHR1THRQbTNqZ3dMUkJHM3M5cXgvUHhUY25TN2VBOWJCQkhuMnNX?= =?utf-8?B?UTg0RksyZTdJYlc1MUJNdTJEUjZhSS82ME53Yll0S1JxdFV1Z1JPemxxbEpH?= =?utf-8?B?T2I0dnZQUWVueW9GSGdDK3NKNEVVZzVYenU3NXZaU2p3MGZGZ1hyNVBjcG5q?= =?utf-8?Q?x31o=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 6:GE3SZrhjW2baBWVOYORye/kKP7RpXA1V3I3jVhtiQPIrI4spV7JRNkB0sx4PppAN4o1tTaJTCh+cIGewUx5NUFD1JXnYBHR2DI86ppN4ogCsJnivdux9NCCTSFX9G+ppUS0JbCGvrXaS8qOtZx7qJZyyLH4NCDC4ywVWFcuYT5ETp4syYEPu+KcjEYf8gUw6HQJds1vvCMcM+51GZ/9MPU5/pdczeERBACq/ns1Y1KKczLARmyJ4eOR6JOjzLTZdb6hcOszrmbMhP4bV5XllAuOtWWJBdU/OXmYLwuYurvqEl0LlZYdh2LSKPcqaWHPhcidhMaYzIs1+KUBrp/8h7QeWKKABCQ5OoAxLe7IzaifUsKrZM3If74Ocd5LB1JQotGK0vS7Xfif23tcMuFwT27f6bmcuFgjqVvOOi9r4bV/O7VMFD9gK8WqbDrR9ql5D; 5:+IFF+us/F0KJPBbhIZ4D1cejgSU524mYKzaY/9XnWthFWhVNMjI41vI8KEc+dJm7oJDSxljvGCFCzy/+vowCAROGvoqg7WQx4ve95UT/N5OCwXh5gZVFUtwIVRakjNH8cmZG8EQtNDTpZRC8Cib/crPhc+gAeYKLrwGgABWgciDKKQo5JsoaZcjtWdi6q8A6; 24:2pZ9sGRkwONFInxg9XqSgHVRnSxavi6d+B2zZrDJEevWT9KVejZ5PwpP5XVww360u78vOwpHuvKFn0cyQbcdcsbBWboMAsIXLlUUbduUCwA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 7:YydSX8DcOHOg0EaY3FY013zKqvxwnGvLHb0Pae1gQMm5H2Gk7VVGY35Mk6BxNNZ/gm0AOIqtQIEt/yKfzqyy8PRScF6Nl51b0KouWuR54sCNinVeh4XIlSGt63Pl2BrRVknF9Up37kyQNvZ4UE/6GPmINqDYL/aV6TAWAqT28FOYJTf8Agart3oZCyj9yqQ4I1sEUvipXCxJP0FWgvysIZtGayVDUphNpbdAkwZG+OgGI4VB+f6qwlxyRa/vLPSYcqlGq+52WvR9P8YhICw5JkAxO17iLKlnJ4X/9pJJpJLUQlkMVh2yLu8JckfhBugcVjsoOLRLRtQHDXw1Dm2Ygo77g4bemtPSlXVNFPAY2DW540yZVXiUVDS7wmzkFf9f0HJMfM33x4UssVj7T/sal5egr26B7AQvTpdlPQVhRcXg+1JALEUmFeFjwOunLcZG4sZqv0kDA36noKHj3QGwOQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2016 11:35:53.2002 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2466 Subject: Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 11:35:55 -0000 On Friday 23 December 2016 04:57 PM, Jan Blunck wrote: > On Fri, Dec 23, 2016 at 12:11 PM, Shreyansh Jain wrote: >> On Friday 23 December 2016 04:20 PM, Jan Blunck wrote: >>> >>> On Thu, Dec 22, 2016 at 9:11 AM, Shreyansh Jain >>> wrote: >>>> >>>> On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: >>>>> >>>>> >>>>> On Wed, 21 Dec 2016 16:09:44 +0100 >>>>> Jan Blunck wrote: >>>>> >>>>>> Only the device itself can decide its PCI or not. >>>>>> >>>>>> Signed-off-by: Jan Blunck >>>>>> Acked-by: Shreyansh Jain >>>>>> --- >>>>> >>>>> >>>>> >>>>> I would still like to kill dev_pci from the dev_info API. >>>>> >>> >>> I'm fine with that too. >>> >>>> >>>> +1. It should be rte_dev reference instead. >>>> >>> >>> Only if you can give use-cases for what users should be able to do >>> with it. If that is the case we need to clearly define what that >>> means. Do we want to enable users to control the low-level EAL device >>> directly and shortcut the ethdev driver? If that is necessary we need >>> to give control to the driver first to decide if it is safe to do so. >>> >> >> An ethernet device is not necessarily a PCI device. With planned removal of >> rte_pci_device from rte_eth_device, this will be realized. >> Similarly, the info is also not PCI device specific. >> >> With the '+1', my intention was not to say we should do it in this patch. We >> should prepare eth_dev_info in similar manner as done for pci_dev of >> rte_eth_dev (ETH_DEV_PCI_DEV() style macro, or inline). > > Which is exactly what this patch is doing. I'm moving the filling of > the PCI information out of the generic code because only the driver > could know if it is actually handling a PCI device. The generic code > can not use the ETH_DEV_PCI_DEV() macro in a safe manner. I fully agree with you and support this series. Probably I went a step further in my eagerness - I was only hinting that now info filling part is relatively free of pci-ness, we should remove eth_dev_info linkage to PCI. There is no change I am expecting in your patch in this regard. Yours is the first step to this change. > >> And now for whether we should expose lower level device details or not, I >> was of the view that keeping pci_dev linked to this structure exposes more >> lower level info than keeping rte_dev. Another view point could be to >> completely do away with pci_info within eth_dev_info - but, I am not sure of >> dependencies on it. > > If I understand Stephen correctly he questions the benefit of pushing > down the code to the drivers instead of killing that code completely. > I'll see what I can do here. > Ok. Then I read it wrong. I read it in the sense that we should remove PCI dependency of eth_info. Except, I considered that removal more as replacement with rte_device. My mistake!