From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54FADA0526; Wed, 8 Jul 2020 22:19:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 341E01DC72; Wed, 8 Jul 2020 22:19:38 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 582291DC57 for ; Wed, 8 Jul 2020 22:19:36 +0200 (CEST) IronPort-SDR: a/OyOMFZY41aq41SaP5F0vz6Q5cDEgzdafCeKJCVS8DiZLxTHPyJPGaxsuMbsLmMAqIz3hyx2E HrjoGxj1apIg== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="145990781" X-IronPort-AV: E=Sophos;i="5.75,329,1589266800"; d="scan'208";a="145990781" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 13:19:35 -0700 IronPort-SDR: eIzEdD2BqXX9nR5skeKHduT4SIKOxg9yceuZKOKYEOJaiXcFVAGUWg1SKagjmkKDtHyHVouNrg C9c2zMlTdbTw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,329,1589266800"; d="scan'208";a="306159164" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.213.247.70]) ([10.213.247.70]) by fmsmga004.fm.intel.com with ESMTP; 08 Jul 2020 13:19:33 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com References: <13626781.5Qu6SIutNE@thomas> From: "Medvedkin, Vladimir" Message-ID: <98bd00d2-f751-4a76-5442-e94bd475dc58@intel.com> Date: Wed, 8 Jul 2020 21:19:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <13626781.5Qu6SIutNE@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 4/8] fib: introduce AVX512 lookup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 06/07/2020 20:21, Thomas Monjalon wrote: > 19/05/2020 14:12, Vladimir Medvedkin: >> --- a/lib/librte_fib/meson.build >> +++ b/lib/librte_fib/meson.build >> +if dpdk_conf.has('RTE_ARCH_X86') and cc.has_argument('-mavx512f') >> + if cc.has_argument('-mavx512dq') >> + dir24_8_avx512_tmp = static_library('dir24_8_avx512_tmp', >> + 'dir24_8_avx512.c', >> + dependencies: static_rte_eal, >> + c_args: cflags + ['-mavx512f'] + ['-mavx512dq']) >> + objs += dir24_8_avx512_tmp.extract_objects('dir24_8_avx512.c') >> + cflags += '-DCC_DIR24_8_AVX512_SUPPORT' >> + endif >> +endif > > I don't want to try understanding what this hack is. > But please add comments around it, so we will understand why > compilation fails: > > In file included from ../../dpdk/lib/librte_fib/dir24_8_avx512.c:5: > ../../dpdk/lib/librte_eal/x86/include/rte_vect.h:97:18: error: expected declaration specifiers or ‘...’ before ‘(’ token > 97 | #define ZMM_SIZE (sizeof(__x86_zmm_t)) > | ^ > > I sent v4 with slightly reworked meson.build, please check compilation. > -- Regards, Vladimir