From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AABEEA0C45; Wed, 1 Sep 2021 16:20:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 317504013F; Wed, 1 Sep 2021 16:20:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A708B40041 for ; Wed, 1 Sep 2021 16:20:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630506030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0LCTb0rW5NYPYGT4qTtmFg0g2jwGMk0jC7AKtG6qf/Y=; b=Xefl+S+QsQmspGIlUEsXnl5fewAsBcgKY737a5KevCzyn+yvg/++OhEBQAo+usWkN6RfX8 ah2p+h8lH8rPlyfauqp1pI73caR2VsS9Y5bYpkOSUihetK8id1ONarvub2aaz5qyaiIR+j hYyKp/nIQU0xhZYTTDb9/uKb7GAnIHo= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-109-Nu_RI4wrPXiL1z_i-gPSkQ-1; Wed, 01 Sep 2021 10:20:29 -0400 X-MC-Unique: Nu_RI4wrPXiL1z_i-gPSkQ-1 Received: by mail-oo1-f71.google.com with SMTP id w21-20020a4ae9f5000000b0029116e62638so1484657ooc.4 for ; Wed, 01 Sep 2021 07:20:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=0LCTb0rW5NYPYGT4qTtmFg0g2jwGMk0jC7AKtG6qf/Y=; b=NKlwHUEYw5JZ9dboZwJPD7iYGSVOtzjlAjS5RVhHaVPQqUvQSCazrvrF+zmoSYSv7E TWP4SPwZgPr4H8fCjrxXcf4C40VAH8juEcb1/UP9/aVR/DFubNfOZDmC2cWJyRny4G5G 9DbO9N25jECPTJGiC8psoLNffCTKXyIgHjtc+O/+bi1v02lcRgJX4oXJHS1na1U3JNnp SB16WvCxGpheEGNZBoEYEpguwnw28INSE+RoDq7NkAMqQ/XkUdMl1ZHXRaRsbP6rHpwD iWm3+UZ5EyP7GjMxoX3vSqwdgkLGiyef+k7f2OnDsk/Zl+JNT4tG6uZFYJPZ1l6GTESC QI2Q== X-Gm-Message-State: AOAM531BVGCeqNbUMBOfM6KRbwb0sLmnY7frEh/pGF4DOzlbHcpa8Ixb yw9tAdY+7qTL0wIhtiLpcmSHf7DlyzwsII8TQs0nd+8luI/oQ7d1DsMUtuMMDI3XjrMKbsP7Vwj vHGE= X-Received: by 2002:a05:6808:10c8:: with SMTP id s8mr7477192ois.175.1630506029111; Wed, 01 Sep 2021 07:20:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCz7+7p/YvXy5wz8vTdnOL6NDDPn4zzeXdqrPkir4I4O3Y8/lnFRJfou/utitWR21utAugvg== X-Received: by 2002:a05:6808:10c8:: with SMTP id s8mr7477179ois.175.1630506028887; Wed, 01 Sep 2021 07:20:28 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id b11sm14751ooi.0.2021.09.01.07.20.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 07:20:28 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, mingshan.zhang@intel.com, arun.joshi@intel.com References: <1629407410-28822-1-git-send-email-nicolas.chautru@intel.com> <1629407410-28822-5-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: <98c827cb-ad62-6b56-5a94-275a25d845a0@redhat.com> Date: Wed, 1 Sep 2021 07:20:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1629407410-28822-5-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 4/6] baseband/acc100: add support for 4G CRC drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/19/21 2:10 PM, Nicolas Chautru wrote: > This implements in PMD the option to drop the CB CRC > after 4G decoding to help transport block concatenation. > > Signed-off-by: Nicolas Chautru > --- > doc/guides/bbdevs/acc100.rst | 1 + > doc/guides/rel_notes/release_21_11.rst | 4 ++++ > drivers/baseband/acc100/rte_acc100_pmd.c | 12 +++++++++--- > 3 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/bbdevs/acc100.rst b/doc/guides/bbdevs/acc100.rst > index ff0fa4b..9fff6ab 100644 > --- a/doc/guides/bbdevs/acc100.rst > +++ b/doc/guides/bbdevs/acc100.rst > @@ -58,6 +58,7 @@ ACC100 5G/4G FEC PMD supports the following BBDEV capabilities: > - ``RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN`` : set if negative LLR encoder i/p is supported > - ``RTE_BBDEV_TURBO_POS_LLR_1_BIT_IN`` : set if positive LLR encoder i/p is supported > - ``RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP`` : keep CRC24B bits appended while decoding > + - ``RTE_BBDEV_TURBO_DEC_CRC_24B_DROP`` : option to drop the code block CRC after decoding > - ``RTE_BBDEV_TURBO_EARLY_TERMINATION`` : set early termination feature > - ``RTE_BBDEV_TURBO_DEC_SCATTER_GATHER`` : supports scatter-gather for input/output data > - ``RTE_BBDEV_TURBO_HALF_ITERATION_EVEN`` : set half iteration granularity > diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst > index 8ca59b7..f7843bc 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -59,6 +59,10 @@ New Features > > Added support for more comprehensive CRC options. > > +* **Updated the ACC100 bbdev PMD.** > + > + Added support for more comprehensive CRC options. > + > Removed Items > ------------- > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 68ba523..891be81 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -980,6 +980,7 @@ > RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN | > RTE_BBDEV_TURBO_MAP_DEC | > RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP | > + RTE_BBDEV_TURBO_DEC_CRC_24B_DROP | > RTE_BBDEV_TURBO_DEC_SCATTER_GATHER, > .max_llr_modulus = INT8_MAX, > .num_buffers_src = > @@ -1708,8 +1709,12 @@ > } > > if ((op->turbo_dec.code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) > - && !check_bit(op->turbo_dec.op_flags, > - RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP)) > + && !check_bit(op->turbo_dec.op_flags, > + RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP)) > + crc24_overlap = 24; > + if ((op->turbo_dec.code_block_mode == RTE_BBDEV_CODE_BLOCK) These two if-statements can be combined. > + && check_bit(op->turbo_dec.op_flags, > + RTE_BBDEV_TURBO_DEC_CRC_24B_DROP)) > crc24_overlap = 24; > > /* Calculates circular buffer size. > @@ -1744,7 +1749,8 @@ > > next_triplet = acc100_dma_fill_blk_type_out( > desc, h_output, *h_out_offset, > - k >> 3, next_triplet, ACC100_DMA_BLKID_OUT_HARD); > + (k - crc24_overlap) >> 3, next_triplet, crc24_overlap had been set before this patch in the above if-statement for crc_24b_keep. so this looks like a bug. If it is a bug, it should be separated out as its own patch. Tom > + ACC100_DMA_BLKID_OUT_HARD); > if (unlikely(next_triplet < 0)) { > rte_bbdev_log(ERR, > "Mismatch between data to process and mbuf data length in bbdev_op: %p",