Re: [dpdk-dev] [PATCH 2/4] net/hns3: fix MP action register and unregister

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/2/2021 1:38 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> The multi-process has the following problems:
> 1) After a port in primary process is closed, the mp action of the process
>     is unregistered. which will cause that other device in the primary
>     process cannot respond to requests from secondary processes.
> 2) Because variable "hns3_inited" is set to true without returning an
>     initial value, the mp action cannot be registered again after it is
>     unregistered.
> 3) The mp action of primary and secondary process need to be registered
>     only once regardless of port numbers in the process. That's what
>     variable "hns3_inited" does. But the variable is difficult to
>     understand.
> 
> This patch adds a hns3_process_local_data structure to resolve above
> problems.
> 
> Fixes: 9570b1fdbdad ("net/hns3: check multi-process action register result")
> Fixes: 23d4b61fee5d ("net/hns3: support multiple process")
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

<...>

> @@ -12,7 +12,8 @@
>   #include "hns3_rxtx.h"
>   #include "hns3_mp.h"
>   
> -static bool hns3_inited;
> +/* local data for primary or secondary process. */
> +struct hns3_process_local_data process_data;
>   
I was here to complain about non-static global variable that doesn't have
driver namespace ('hns3_'), but I can see later patches are converting
this variable to a static global, so I guess it is OK to have it temporarily.