From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 039A5A2EDB
	for <public@inbox.dpdk.org>; Mon, 30 Sep 2019 16:08:50 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 47B331B948;
	Mon, 30 Sep 2019 16:08:49 +0200 (CEST)
Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32])
 by dpdk.org (Postfix) with ESMTP id EEF377CBC
 for <dev@dpdk.org>; Mon, 30 Sep 2019 16:08:47 +0200 (CEST)
Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60])
 by Forcepoint Email with ESMTP id 77DFC77706E9E21ABDC8
 for <dev@dpdk.org>; Mon, 30 Sep 2019 22:08:46 +0800 (CST)
Received: from [127.0.0.1] (10.177.29.98) by DGGEMS401-HUB.china.huawei.com
 (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Mon, 30 Sep 2019
 22:08:37 +0800
To: Ferruh Yigit <ferruh.yigit@intel.com>
CC: <dev@dpdk.org>, <xuanziyang2@huawei.com>, <shahar.belkar@huawei.com>,
 <luoxianjun@huawei.com>, <tanya.brokhman@huawei.com>,
 <zhouguoyang@huawei.com>, <wulike1@huawei.com>
References: <cover.1569421286.git.cloud.wangxiaoyun@huawei.com>
 <73ab3bffbc943123207ae0bc0c004a4ea0f037d3.1569421287.git.cloud.wangxiaoyun@huawei.com>
 <b6688b1b-a946-d96c-bb1c-2432232abaf9@intel.com>
From: "Wangxiaoyun (Cloud, Network Chip Application Development Dept)"
 <cloud.wangxiaoyun@huawei.com>
Message-ID: <98e842e2-5d9b-d588-220b-6760fb99ddf2@huawei.com>
Date: Mon, 30 Sep 2019 22:08:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <b6688b1b-a946-d96c-bb1c-2432232abaf9@intel.com>
X-Originating-IP: [10.177.29.98]
X-CFilter-Loop: Reflected
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 07/17] net/hinic: add fdir config interface
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,
      Thanks for your comments, I have fixed the patch comments with "net/hinic/base: add fdir config interface", and send a new patch V3 to you.

Best regards
Xiaoyun Wang

在 2019/9/27 2:48, Ferruh Yigit 写道:
> On 9/25/2019 3:30 PM, Xiaoyun wang wrote:
>> This patch adds fdir config operation, including set fdir filter,
>> normal filter, set and clear fdir tcam.
>>
>> Signed-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>
>> ---
>>   drivers/net/hinic/base/hinic_pmd_cmd.h    |   2 +
>>   drivers/net/hinic/base/hinic_pmd_niccfg.c | 205 ++++++++++++++++++++++++++++++
>>   drivers/net/hinic/base/hinic_pmd_niccfg.h | 134 +++++++++++++++++++
> This looks like base code update to prepare driver for rte_flow, may be better
> to use "net/hinic/base:" in the patch title.
>
>