From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 823D32617 for ; Thu, 30 Jun 2016 14:02:25 +0200 (CEST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DA84A8AE72; Thu, 30 Jun 2016 12:02:24 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-182.ams2.redhat.com [10.36.5.182]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5UC2NGU009983; Thu, 30 Jun 2016 08:02:23 -0400 To: Thomas Monjalon , Bruce Richardson References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1467217635-19766-1-git-send-email-bruce.richardson@intel.com> <1585831.LcblvschXd@xps13> Cc: dev@dpdk.org, olivier.matz@6wind.com, keith.wiles@intel.com From: Panu Matilainen Message-ID: <98f41037-a666-53b6-efce-65a73a218d29@redhat.com> Date: Thu, 30 Jun 2016 15:02:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1585831.LcblvschXd@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 30 Jun 2016 12:02:24 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] mempool: rename functions with confusing names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 12:02:25 -0000 On 06/30/2016 03:00 PM, Thomas Monjalon wrote: > 2016-06-29 17:27, Bruce Richardson: >> Fix this by introducing two new functions to replace the old ones, >> * rte_mempool_avail_count to replace rte_mempool_count >> * rte_mempool_in_use_count to replace rte_mempool_free_count > > This patch needs to be rebased please. > >> --- a/lib/librte_mempool/rte_mempool_version.map >> +++ b/lib/librte_mempool/rte_mempool_version.map >> @@ -32,5 +32,6 @@ DPDK_16.07 { >> rte_mempool_populate_virt; >> rte_mempool_register_ops; >> rte_mempool_set_ops_byname; >> + rte_mempool_avail_count; > > The "in_use_count" function is missing. Its missing because the function is static inline. If you ask me, this would be as fine time as any to remove that inlining ;) - Panu - > Please keep alphabetical order. >