From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8CA2F1B49E for ; Fri, 5 Apr 2019 12:37:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1896521B0E; Fri, 5 Apr 2019 06:37:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 05 Apr 2019 06:37:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=TWimB06wSVSvliqG7i840+10M1FDvCxrGdCjGew7Wvc=; b=N7NWBvPkZ2bn wBwYjSv4+3rHwkxbYxD5Zb4i1YQtd1ZU7zY1Sl5tlo2fTlYjHRg/2fOsdg1Wl5sN tCUdhbHjp5GSK+wKgyq9N5o8OWAR7xznGuhhCVKY0H94Cyl75oNFM+mfNmgYVVXA ZLF5fjeISpntsucwBwiwOdNepml9VnM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TWimB06wSVSvliqG7i840+10M1FDvCxrGdCjGew7W vc=; b=iTgbLJLkelivlwx4gsuReXpbTP94BTsckjfivxVAOeI01yFNoRP4b/eeJ G+IftZSCutfcj2KJhQidpIAvfwFPrfh+I+g+taLH73faeRSAWazfA9IEen/AcKaG sopz0Nzz3Jj/H0wMEN/e6PfvsyOOER7JVsAoaj1UJpUnZ/A7fXX/TWrEKudbJdYS FGm6sqCUho0o1D0Ji2nDOVN9DgfEpxWjvws96Wz6kiahrqKRVaSRvF3w2YLpzvm1 /QqKfnGRLPn2smhzu1X7Sm1CM6GpuC4/J3IBNzq6CC/kqkplXhonKBcJntp/KdmZ mkLzPq8WNs11KL4OU5C5iJAZAQbxw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdejgddvjeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A00CE40D0; Fri, 5 Apr 2019 06:37:46 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , "Ananyev, Konstantin" , "Yang, Qiming" Cc: dev@dpdk.org, "Zhang, Qi Z" , "Iremonger, Bernard" , bruce.richardson@intel.com Date: Fri, 05 Apr 2019 12:37:45 +0200 Message-ID: <9903209.CFTR2bDiz1@xps> In-Reply-To: References: <20190405090535.7604-1-qi.z.zhang@intel.com> <2601191342CEEE43887BDE71AB9772580148A936FF@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 10:37:48 -0000 Hi, Sorry for not catching it before, but I was not Cc. Please use git send-email --to-cmd devtools/get-maintainer.sh 05/04/2019 11:42, Ferruh Yigit: > On 4/5/2019 10:36 AM, Ananyev, Konstantin wrote: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > >> From: Qiming Yang > >> > >> This patch added VXLAN-GPE macro in rte_eth_tunnel_type. > >> This patch will break the ABI, RTE_TUNNEL_TYPE_MAX will have > >> problem when running with new version of the ethdev shared > >> library. > >> > >> Signed-off-by: Qiming Yang > >> --- [...] > >> --- a/lib/librte_ethdev/rte_eth_ctrl.h > >> +++ b/lib/librte_ethdev/rte_eth_ctrl.h > >> @@ -229,6 +229,7 @@ enum rte_eth_tunnel_type { > >> RTE_TUNNEL_TYPE_NVGRE, > >> RTE_TUNNEL_TYPE_IP_IN_GRE, > >> RTE_L2_TUNNEL_TYPE_E_TAG, > >> + RTE_TUNNEL_TYPE_VXLAN_GPE, > > > > Not sure, why do you consider it as an ABI breakage? > > I think it is API breakage instead of ABI. > > This changes the value of the 'RTE_TUNNEL_TYPE_MAX' > If the application is using the MAX enum item, with the new version of the > ethdev the MAX value will be different and this can break the app. > > Like: > > app_function(..) { > ret = lib_foo() > if (ret == RTE_TUNNEL_TYPE_MAX) > ret -1; > } > > lib_foo(..) { > return RTE_TUNNEL_TYPE_MAX; > } > > > When app compiled, MAX was '7' and app is comparing ret value against '7', but > with new version of DPDK, 'lib_foo()' will return '8' instead. I would vote for ABI because it is a value change. Anyway, it must be noticed in the release notes. As we are already breaking ethdev ABI in this release, and it is a very basic change, I agree to accept it in 19.05. In future, we should make sure that such addition is possible without any breakage. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 82938A0679 for ; Fri, 5 Apr 2019 12:37:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 349E71B4A1; Fri, 5 Apr 2019 12:37:50 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8CA2F1B49E for ; Fri, 5 Apr 2019 12:37:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1896521B0E; Fri, 5 Apr 2019 06:37:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 05 Apr 2019 06:37:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=TWimB06wSVSvliqG7i840+10M1FDvCxrGdCjGew7Wvc=; b=N7NWBvPkZ2bn wBwYjSv4+3rHwkxbYxD5Zb4i1YQtd1ZU7zY1Sl5tlo2fTlYjHRg/2fOsdg1Wl5sN tCUdhbHjp5GSK+wKgyq9N5o8OWAR7xznGuhhCVKY0H94Cyl75oNFM+mfNmgYVVXA ZLF5fjeISpntsucwBwiwOdNepml9VnM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TWimB06wSVSvliqG7i840+10M1FDvCxrGdCjGew7W vc=; b=iTgbLJLkelivlwx4gsuReXpbTP94BTsckjfivxVAOeI01yFNoRP4b/eeJ G+IftZSCutfcj2KJhQidpIAvfwFPrfh+I+g+taLH73faeRSAWazfA9IEen/AcKaG sopz0Nzz3Jj/H0wMEN/e6PfvsyOOER7JVsAoaj1UJpUnZ/A7fXX/TWrEKudbJdYS FGm6sqCUho0o1D0Ji2nDOVN9DgfEpxWjvws96Wz6kiahrqKRVaSRvF3w2YLpzvm1 /QqKfnGRLPn2smhzu1X7Sm1CM6GpuC4/J3IBNzq6CC/kqkplXhonKBcJntp/KdmZ mkLzPq8WNs11KL4OU5C5iJAZAQbxw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdejgddvjeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A00CE40D0; Fri, 5 Apr 2019 06:37:46 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , "Ananyev, Konstantin" , "Yang, Qiming" Cc: dev@dpdk.org, "Zhang, Qi Z" , "Iremonger, Bernard" , bruce.richardson@intel.com Date: Fri, 05 Apr 2019 12:37:45 +0200 Message-ID: <9903209.CFTR2bDiz1@xps> In-Reply-To: References: <20190405090535.7604-1-qi.z.zhang@intel.com> <2601191342CEEE43887BDE71AB9772580148A936FF@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add VXLAN-GPE macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190405103745.5wf_vASAnbVwHOB5PAdUuJRL5Uf0s_IullZjz5LnBPg@z> Hi, Sorry for not catching it before, but I was not Cc. Please use git send-email --to-cmd devtools/get-maintainer.sh 05/04/2019 11:42, Ferruh Yigit: > On 4/5/2019 10:36 AM, Ananyev, Konstantin wrote: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > >> From: Qiming Yang > >> > >> This patch added VXLAN-GPE macro in rte_eth_tunnel_type. > >> This patch will break the ABI, RTE_TUNNEL_TYPE_MAX will have > >> problem when running with new version of the ethdev shared > >> library. > >> > >> Signed-off-by: Qiming Yang > >> --- [...] > >> --- a/lib/librte_ethdev/rte_eth_ctrl.h > >> +++ b/lib/librte_ethdev/rte_eth_ctrl.h > >> @@ -229,6 +229,7 @@ enum rte_eth_tunnel_type { > >> RTE_TUNNEL_TYPE_NVGRE, > >> RTE_TUNNEL_TYPE_IP_IN_GRE, > >> RTE_L2_TUNNEL_TYPE_E_TAG, > >> + RTE_TUNNEL_TYPE_VXLAN_GPE, > > > > Not sure, why do you consider it as an ABI breakage? > > I think it is API breakage instead of ABI. > > This changes the value of the 'RTE_TUNNEL_TYPE_MAX' > If the application is using the MAX enum item, with the new version of the > ethdev the MAX value will be different and this can break the app. > > Like: > > app_function(..) { > ret = lib_foo() > if (ret == RTE_TUNNEL_TYPE_MAX) > ret -1; > } > > lib_foo(..) { > return RTE_TUNNEL_TYPE_MAX; > } > > > When app compiled, MAX was '7' and app is comparing ret value against '7', but > with new version of DPDK, 'lib_foo()' will return '8' instead. I would vote for ABI because it is a value change. Anyway, it must be noticed in the release notes. As we are already breaking ethdev ABI in this release, and it is a very basic change, I agree to accept it in 19.05. In future, we should make sure that such addition is possible without any breakage.