From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stable@dpdk.org,
"Luca Boccassi" <luca.boccassi@microsoft.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>
Subject: Re: [PATCH] drivers: fix symbol exports when map is omitted
Date: Wed, 30 Nov 2022 09:19:46 +0000 [thread overview]
Message-ID: <990497cd-dd21-604c-6444-6a77801515c7@amd.com> (raw)
In-Reply-To: <CAJFAV8yEHU=n06Sjkz2thMS0JjME+t5uQddFMyWSVpTojT=PBg@mail.gmail.com>
On 11/30/2022 8:27 AM, David Marchand wrote:
> On Wed, Nov 30, 2022 at 8:13 AM David Marchand
> <david.marchand@redhat.com> wrote:
>>> I assume this will cause warnings for ABI check scripts, how can we
>>> prevent the warnings?
>>
>> Indeed.
>>
>> Some options:
>> - add exhaustive suppression rules in devtools/libabigail.abignore,
>> - retag the v22.11 release with this fix, but we already announced it
>> and people started downloading the tarball,
>> - release a .1 version and compare ABI against it (either in the main
>> repo, or in the 22.11 stable branch, through for the ABI check in GHA,
>> it would be simpler to have the tag in the main repo..),
>
> (let's forget about my concern on GHA, we have the REF_GIT_REPO param,
> so we can point at the dpdk-stable repo, and go with a "normal"
> release in 22.11 stable branch)
>
OK to have v22.11.1 stable release with this fix.
next prev parent reply other threads:[~2022-11-30 9:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 14:00 David Marchand
2022-11-29 18:23 ` Ferruh Yigit
2022-11-30 7:13 ` David Marchand
2022-11-30 8:27 ` David Marchand
2022-11-30 9:19 ` Ferruh Yigit [this message]
2022-12-02 0:11 ` Tyler Retzlaff
2022-11-30 10:02 ` [PATCH v2] " David Marchand
2022-11-30 10:44 ` Ferruh Yigit
2022-11-30 15:02 ` David Marchand
2022-11-30 15:24 ` David Marchand
2022-11-30 15:42 ` Bruce Richardson
2022-12-01 10:11 ` David Marchand
2022-12-01 10:08 ` [PATCH v3 1/2] " David Marchand
2022-12-01 10:08 ` [PATCH v3 2/2] build: generate Windows build artefacts when needed David Marchand
2022-12-01 11:01 ` Bruce Richardson
2022-12-01 10:55 ` [PATCH v3 1/2] drivers: fix symbol exports when map is omitted Bruce Richardson
2022-12-02 10:01 ` David Marchand
2022-12-02 11:09 ` [PATCH v4 " David Marchand
2022-12-02 11:09 ` [PATCH v4 2/2] build: generate Windows build artefacts when needed David Marchand
2022-12-02 13:39 ` [PATCH v4 1/2] drivers: fix symbol exports when map is omitted Aaron Conole
2022-12-05 10:23 ` David Marchand
2022-12-05 10:43 ` [EXT] " Akhil Goyal
2022-12-05 12:36 ` David Marchand
2022-12-05 13:47 ` Akhil Goyal
2022-12-05 15:37 ` Thomas Monjalon
2022-12-05 16:26 ` Akhil Goyal
2022-12-06 10:12 ` Ferruh Yigit
2022-12-06 10:18 ` David Marchand
2022-12-06 12:25 ` Ferruh Yigit
2022-12-07 18:00 ` Patrick Robb
2022-12-08 13:22 ` Thomas Monjalon
2022-12-08 16:06 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990497cd-dd21-604c-6444-6a77801515c7@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=luca.boccassi@microsoft.com \
--cc=omer.yamac@ceng.metu.edu.tr \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).