From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BAB8A0032; Fri, 21 Oct 2022 11:59:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD48742BA6; Fri, 21 Oct 2022 11:59:55 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2053.outbound.protection.outlook.com [40.107.93.53]) by mails.dpdk.org (Postfix) with ESMTP id 74C4442BA4; Fri, 21 Oct 2022 11:59:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RNgsywTC/Y3laE3SAvWt9F5MZGKOkkD/q8XEvS6vXgOcA2sSnHrGORwMorFBI/tpAcB5eU+ZanCMXiPC+03/MG776PO2L6W6LltBxumwo//03kEMTa8Y/eUlNVqC9Z49FjyqsNdRV73Bzk+kmMWraLHkb0VRDzlCS1+yzZqALtM6vNI6Q/GpXQr6v4L4qPMOJn8IKZO2u43bJKhSU+/1kw/ahLtCOnXkjJNGl4PVndZ+rvOZyWZrbWwiwu9QKwECx9jPpXKB+afOINswIUbJBJcnGkxjiyJml3jmBklUqotVLBWAMQbGAs2rburO3sLJmPnG8c34tAnhAL4/4kXaBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/q/dU+oekkFcP+BheUfZINQP3czZSqT9U+acmiO6StI=; b=NHYDYR0q0s+Ornb9gF4KZzVksKJIY9AbzWQN6zZ7z88nP1KOLyAay0pgTI7MKKXjqqGb9iAa1sg3wJLXlWYJlHUaZhLtRZt52mU7BjNQU+jToabNr4eO+X/PaXlZwNyXAjJwpkSeuZMrvjQmPhPIuYTsKV5bVBWTHlukl4UJTCwzjTwQ5Jd6vAxb7OkCoaZzNagHyiRAZKFxGJ5OlhMAoVs2YoWkP5lYStffcwgiZecEPhbtsQs5G67Mt6ZoyVjiZkTWE/JcgC3bAiTJJ3Ux86EErlDNkcDBp7nN1R6gK3Sjkx2whUgBhoabh441NQL1Vi/Xoe0Z0F8dom6B+r6HTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/q/dU+oekkFcP+BheUfZINQP3czZSqT9U+acmiO6StI=; b=NGdDZy7axspRbRvB2TE2B3KSTLmgAtbmqwMpfHy8REzkYjw9S+0LPTQgF296tt+WJpoLmm25Nc7wWH5K4dmgnvY7N2Nzmy/z+mseD7UXq666NdbN4dfll3rwogdYyVjyY2OljeYDleXnNg90jGV1Wdn/Di1HjPx6TC21QKblDnQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by CH2PR12MB4184.namprd12.prod.outlook.com (2603:10b6:610:a7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Fri, 21 Oct 2022 09:59:53 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Fri, 21 Oct 2022 09:59:52 +0000 Message-ID: <9926fde3-46f6-0e00-b8df-688634f13ed6@amd.com> Date: Fri, 21 Oct 2022 10:59:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v2] net/nfp: ensure the MTU can work Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Peng Zhang , stable@dpdk.org References: <1665384495-24990-1-git-send-email-chaoyong.he@corigine.com> <1666333666-38183-1-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1666333666-38183-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::11) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|CH2PR12MB4184:EE_ X-MS-Office365-Filtering-Correlation-Id: d3221d3b-98f7-4249-a9bd-08dab34affd6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hrbnW7L9eJXUfp2xpXnomhCOszY8ExQqpkk1MH7jdBfqbjmH5dyULK/oaRm+IW4suxXlr8ij6xEvKAnPQ12P4J7QW8aZXNWcuGZ4JBQ+WZXT/SMmi1aFdE2WIAJ2Bcu2v5kR6sXo2gB/s/L+PwVdlMBwdseyMauw9ZYRtLTUbP0c33FNfZW63HhTP5ev8lsl9dFGVtG72/eFfZ/KsBYpXkUQunQjWliFbv9H3K5TydLJCBinOvXX1jim/TGRyvzyVrwiDRKseUEn1PBNzC7E5OK8jUWALya5bFgzjvc8y6wlaGXmWCZm8U/zHtV7eDEz5tcSsToEHrr0vxlUodyyUj00DhXGzU2SSEuwjqxmU0bfAsUfCMMuLb0fx3d+oeDI+zstRZChi3UISS9oAAe9UDBJclSL8I5rEGmay99MnBJr24n8F9NFKyMJDDKCkMLfeZGzIdhB99T/B0LEIFWrtNvtNKZlAQbojaCaRSJTphQMiewxGWw1wOzsxzrR7xLRnuiIlMnSMAc5uW3XdLkzOZvwE2FNwqQuHV3bDnBBweQ0vXbgp3y/aQnDGSPmMvhk/giiW8LIrOMCE1RC2u0K19HuAL4y1/hMvig5sTdDczOub3un4Km2R3/2us5kIBSxXtCrFI3aL6nCS9yK21IvfE1qUuV5dcI3AI4jPnbotlVhtla/kknAJqqRIEHPggczdVLvnE5BEZJ4sQum1mwumv8r1zoScm7FWGuCgTEV6T0ln0jyVBzMX9QKeHqwtmfuYqM9+s2lfkRUvkAbA6FoTL8bIo/wHO/uoFlMn2Qao8U= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(451199015)(36756003)(86362001)(478600001)(4744005)(5660300002)(2616005)(6506007)(6486002)(44832011)(53546011)(6666004)(4326008)(31696002)(66946007)(8676002)(66476007)(8936002)(6512007)(66556008)(41300700001)(31686004)(26005)(38100700002)(316002)(186003)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aG12NnhyVC9KMUJNN05ucEVkWTdwdXBUcjRKYkIrOUltWVpTdHpsMmNRbWwr?= =?utf-8?B?dHNwc3hiZmVQYXA3bHc1a29TVC91U1pEbGhMeTBFcXgvc0l2NlR3T0lqL1Rh?= =?utf-8?B?VUJhcG8wdFhabEV1enM0bFA5bWdPblAvc29DYWF3azdtRlh1d3JEL2E0V0Qy?= =?utf-8?B?cVdSTUIwaDBTcnJqeERZWm1hWFo2VmJQUWE0SjhraUVHVnl0c3oxUXp6eXBy?= =?utf-8?B?REVHZ2R3N29XQ05SaW5JOFhtNE5EWU5JVjRDUEVjZ1dWdjBIUkxrdnFHZnpQ?= =?utf-8?B?eWkrVHBKR0FVc1lHQWlZTGc0OUFjSWhTcDlCNWJvWnVDWElZRzZrL1N6TGJo?= =?utf-8?B?UW1leUkxMjJzZ0lJMkthVmI0cmdHb0I3OVR5Z2x6WU9rMGhHeG9oMDRyWjR4?= =?utf-8?B?SStvdnJKK3daTjZKRnMwbGNWZ2pWMWt6SGIrcFg5NkwyanF2Rkt4TTlERmpq?= =?utf-8?B?cFd1eWd0OUtZb3gvL1ZlTFM4Vlp5WEFBVlhxenEwOVM0N1k5TU1NZjlCZ0VN?= =?utf-8?B?b0djQUFYbjMxcjZTcHpLR2pBM3czZUZENGRLa0srdkFVRitnOW5BQXB2S1ky?= =?utf-8?B?SVc4UkVFZDloVzduOU1QZlFseHhHZUIwaHpnUXRiSU1YU0tBY2hWRWNWVmIy?= =?utf-8?B?ZGhPM0YvZ0Z2QkU0VjFBZGk3QmZBc1RsVnVVTDRvUmd6UFFZRVhLZVlhOG5U?= =?utf-8?B?dGVMcS9NNDFsd25vd2xmTzFmcTV6cTRYT1JmR1JGTW1pZFZobkhsZ09WWXZ0?= =?utf-8?B?VkVuWlkwSWNnbkJlbS8xQ3ZTcEo1Ny9mOHMrTTk5aHZhV0I1SG1oM2gzVVh4?= =?utf-8?B?Rmw5UVhLTzVZMUNuUUJWbVlCbTh2UUE4alo1NUZmTVBDNjZMMUwxVE5VRWxq?= =?utf-8?B?N3lQNFV5NnJMbHRKMUtYazkxOVg3aXBEbkhNSzlQYmZSUVNYd2xzaXdRWm1S?= =?utf-8?B?U2E1cG0vTjRTaW05bzVyUFdLSVljUS9XblRWWWJ1dmZVbzlqOGpKWXRQQnY2?= =?utf-8?B?Mnc2SjZXMzUzbkJpZnM4VFF1aDdBclZKTHZ5TU5Fc3ZRMFM1MURjK1NtSUI0?= =?utf-8?B?K2hVOFBWRW1WTWNoWm94YUhqNVNPWTkxQk9iRTcwQ3ozellqOTN5bzIxTXhP?= =?utf-8?B?bVJNemx5c0lVWmxrSEJGNFVmL2NBUkEyVi9WMWNFVmtHRVpBckIwU0IwaVg5?= =?utf-8?B?R3dUdHc5dEdJZDVQSU1Qd0liNzBIYyszSEs3U1dhamtUNFlvYkU1Vm1mMXdH?= =?utf-8?B?YUFmTDBoeUJuL2ljcFZiZXlncENscTZUekhIczJzWFpwdG5Xc2hBbTdleXQ1?= =?utf-8?B?NEZ0NWE0M25zQ1E3c1hPaVZPV0JxUndZT3dOZlp2a1B3UUI2elZwTVhRRXZN?= =?utf-8?B?QXNJb0ZIVXkwOVFBU0ZKQ3BWKzFUeVZPWkNDQlRKa2ZPQTlMcXhsanFTSnJz?= =?utf-8?B?NUllMk1jSWdRR0ZuRjJEc1NzL3lCUFJ3dmpySWpuNVR4NzFBdXcvOFFqZEZx?= =?utf-8?B?V3FPd29kdlpmMm4yakI5bEh3cnZMVWw1ZHFXejcrWDA5c05YSVVlWHQ2RThT?= =?utf-8?B?ZHAwYkpHY0M2OHFlL1dJeTZiaVVsVnJsbVYyd1hzMGx0WGU5d0t5bFZXbVVq?= =?utf-8?B?RjRTTzhaektzK3ZFYzNoaFBFTzJtNld4QXlUdWowd245OTYvY3o5eG9sVzdz?= =?utf-8?B?KzhybnpUcTUvSXJWK1ZDS2lFc2NjZlJDenBTSjhhZzczVkprcmxIVjZHYU00?= =?utf-8?B?MW1WRXRBb1AyUFBhMjZQNFFMQXV1NXBqUXRjdnRyWi9XSEFsRCt0NzJwSEN4?= =?utf-8?B?ZU5jaEFCVWFkTHhUQU1MTnE3Z3ZVQkppMHZoR3dUOXNqWXBPa1lqbUFieTRp?= =?utf-8?B?WGFQV3JiWnRVMlhYVDBMbkVHY0R0bnZVV1piQlRQZkJzSkJYYXJ1dHVlM2g2?= =?utf-8?B?dE1RaUh6RE9tRnpxeCtLS0ZITG5WTy9rTlVsTldKaWlXaXE2SFBZZ3lKZVAw?= =?utf-8?B?VlgvSW1jbkVsQkI3S1BBczUxRlZHZ3M3ZVk0Uk1BSEFoeEl5dTFYSWRsUzBw?= =?utf-8?B?b0pPZlJFcDZvenFnZzEvN3NveS9kdDRFRzZsbTl0SWxBVEtuU0NaUzZyNVBY?= =?utf-8?Q?12wUHWuJXYfllxXpekU5hq4/P?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3221d3b-98f7-4249-a9bd-08dab34affd6 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 09:59:52.9431 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hkotTQu6pIMsVCAicMm7XxrasHh0Uq8bza2B/Rh9Cxkr3ARZEAV9m9wr6GG6m6Rs X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4184 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/21/2022 7:27 AM, Chaoyong He wrote: > From: Peng Zhang > > When MTU is bigger than hw->flbufsz, it can't work. hw->flbufsz is set in > the nfp_net_rx_queue_setup(). > > At first, in the nfp_net_configure(), the hw->flbufsz isn't set the value, > it just judge the initialized value and MTU, it is unreasonable. > > Now, it just check the MTU can't be more than the NFP_FRAME_SIZE_MAX in > the nfp_net_configure(), when hw->flbufsz is set the value, in the > nfp_net_start(), judge the hw->flbufsz and MTU. > > Fixes: 5c305e218f15 ("net/nfp: fix initialization") > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > Applied to dpdk-next-net/main, thanks.