From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93229A0545; Mon, 20 Jun 2022 19:42:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 206314069C; Mon, 20 Jun 2022 19:42:34 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 973C840151 for ; Mon, 20 Jun 2022 19:42:32 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 97D9D32009AC; Mon, 20 Jun 2022 13:42:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 20 Jun 2022 13:42:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1655746947; x= 1655833347; bh=tZlQ1pf+0r+Wyyi/cIF0fcbT/lOs65MBlbqSCiSU14M=; b=t EeaM2nXmdEb4+XxD67I/ZZ0WClzFxv9yGd60KYZAtWDW8Of40pQKfivEjd5IKvtF 6IQeRJBEoFt4VCgjrtfdW86p6vLq1ztAt1qeKxq7BLVBIw3umOE0sCRJQocB2wLM ZaIbGLjEMR5x5xvKK5AOHNCapKcR5GRWh0H9AzWWZ2tuHKThEsV6+O09cpvGKXwS At9q9D5JjWpv7T3JmpOdF14ZRidaKSOSu3eDDsYJ7j3bjjnlWQzT1dxfXhOS3oQE XGTKUDjf6Vcv/9AIfA9u103uQQ0G33B+31+IwH/Jd6JSGnvCSjEpIH5Vr9u+exD3 Da2ljfpgB/+zrS+mB+tuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655746947; x= 1655833347; bh=tZlQ1pf+0r+Wyyi/cIF0fcbT/lOs65MBlbqSCiSU14M=; b=l hyJWdEuls5NDtMmlevv067th0n4O+fi2mZgh9YRhK1SHRh8B1GT3wOwj7GTvEn19 hdkVrcDbfS0rCcDxbJ75Y1pNreAEBpJGG+qGMR8PzN2NqGF2NdTF1U1MUFg13J4b CRy/SjU6VZ/1zJJJgQT/r54+aiDwPfQOYQA8DDS+POtiiJUPy134ixDWGNfrZ4HW oJLeR8GkTEgMuwcW/1H/uOzOjaMQlwPM+/jQ+C+G32+2oXrc8JcEoJX3E2egF4j0 gNAFxCicb+zGRd3/WejnfOUPxvi6CgZlQgfD6OFDbL1w+RWw8JD/NctzIpoLn1/9 K3nzjtrUqjqUWSFz86dPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefuddgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Jun 2022 13:42:25 -0400 (EDT) From: Thomas Monjalon To: Chengwen Feng Cc: ferruh.yigit@xilinx.com, dev@dpdk.org, kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com, ajit.khaparde@broadcom.com, mdr@ashroe.eu, Andrew.Rybchenko@oktetlabs.ru Subject: Re: [PATCH v8 1/4] ethdev: support device error recovery notification Date: Mon, 20 Jun 2022 19:42:23 +0200 Message-ID: <9930820.VV5PYv0bhD@thomas> In-Reply-To: <20220616094122.1909-2-fengchengwen@huawei.com> References: <20220128124830.427-1-kalesh-anakkur.purayil@broadcom.com> <20220616094122.1909-1-fengchengwen@huawei.com> <20220616094122.1909-2-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/06/2022 11:41, Chengwen Feng: > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3928,6 +3928,12 @@ enum rte_eth_event_type { > * @see rte_eth_rx_avail_thresh_set() > */ > RTE_ETH_EVENT_RX_AVAIL_THRESH, > + /** Port recovering from a hardware or firmware error */ > + RTE_ETH_EVENT_ERR_RECOVERING, > + /** Port recovers successful from the error */ > + RTE_ETH_EVENT_RECOVER_SUCCESS, > + /** Port recovers failed from the error */ > + RTE_ETH_EVENT_RECOVER_FAILED, > RTE_ETH_EVENT_MAX /**< max value of this enum */ > }; The descriptions here are not enough. We cannot understand what has changed on the port, and which action must be taken. Note: I believe that's the same problem from the beginning: we need a generic handling which is described in details.