From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9F2401B294; Thu, 18 Jan 2018 12:30:14 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1948220C89; Thu, 18 Jan 2018 06:30:14 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 18 Jan 2018 06:30:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Ct91ybTLwM0u0rMYM6ZVM9wqYb qNdEO/e151uDw4mpM=; b=GPDIAWSAz4LGa7MYPRFjucQciuNdG57DocvPE0BgWy KDiyZ3zXNf2PWW9PIknZbQhbOqVACBP23BVoKf2ZNj99T+n2tPMMH/Lv3TBLl4Fs 8Lzkkk5Hlze9b86iy+N9ZCyNd8jy9nbCATniCk/LBDhiGYaG2RsS/oyiPc2Toxks A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Ct91yb TLwM0u0rMYM6ZVM9wqYbqNdEO/e151uDw4mpM=; b=fljtvXyT1FXwPA3pyiFTAh kWDLWfSq2okrw4DeDzxgEkAuUBeV0gfTaNCNZd6jf8U/G8H0Vyea3kBkyhCugvh2 gxmofxc2GsadGBXOESgXkpFE+MQz0WSfLdCrrGhjFBUZ4Mbh5k4g9l7Pt9dc932c zEsQ8ehmp+N3TIsXNn+OPCNqNx8DWAsPI4CQ22wIL8wC0u+VInoSB/N2uTJ11v1P CE5qRGS8uVv2TBSH89ubOOlS7WA5NG52l2xUUbbt8oCVD3V39ctUiw2Y1NrXucz0 J2AuTNn6Cenr3/2pvIYxQ3MsxMnKZ64Wz6Iz292abspcf6OmeyshENxnz8qrX6uA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B3E077E1A2; Thu, 18 Jan 2018 06:30:13 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org, declan.doherty@intel.com, Boris Pismenny , Aviad Yehezkel , Radu Nicolau Date: Thu, 18 Jan 2018 12:29:40 +0100 Message-ID: <9933117.qs9VA5frF5@xps> In-Reply-To: References: <20180109162317.18183-1-ferruh.yigit@intel.com> <2341214.iScQkZ5rM7@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: fix port id storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 11:30:14 -0000 18/01/2018 11:15, Ferruh Yigit: > On 1/17/2018 10:19 PM, Thomas Monjalon wrote: > > 17/01/2018 23:09, Thomas Monjalon: > >> 17/01/2018 22:57, Ferruh Yigit: > >>> port_id is now 16bits, update function parameter according. > >>> > >>> Fixes: 4c270218aa26 ("ethdev: support security APIs") > >>> Cc: stable@dpdk.org > >>> Cc: declan.doherty@intel.com > >>> > >>> Signed-off-by: Ferruh Yigit > >>> Acked-by: Hemant Agrawal > >> > >> Obviously, > >> Acked-by: Thomas Monjalon > > > > Not so obvious actually. > > It is a good fix, but an API change. > > It is more like API fix. > While whole library is using 16bits for port_id, I think we shouldn't deliver > release with this specific API uses 8bits. > > I am for getting this because what it does is wrong. > > > This function was not declared experimental. > > It must wait 18.05. I really want to keep API stable in 18.02. We have to keep this mistake for one more release.