DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] app/testpmd: fix PPPOES flow API
@ 2020-03-27  8:19 Xiao Zhang
  2020-03-29  6:27 ` Ori Kam
  2020-03-31 13:29 ` [dpdk-dev] [v2] " Xiao Zhang
  0 siblings, 2 replies; 18+ messages in thread
From: Xiao Zhang @ 2020-03-27  8:19 UTC (permalink / raw)
  To: dev; +Cc: orika, ying.a.wang, qi.z.zhang, wei.zhao1, Xiao Zhang, stable

The command line to create RTE flow for specific proto_id of PPPOES is
not correct. This patch is to fix this issue.

Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API")
Cc: stable@dpdk.org

Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
---
 app/test-pmd/cmdline_flow.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index a78154502..c25a2598d 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -768,7 +768,6 @@ static const enum index next_item[] = {
 	ITEM_GTP_PSC,
 	ITEM_PPPOES,
 	ITEM_PPPOED,
-	ITEM_PPPOE_PROTO_ID,
 	ITEM_HIGIG2,
 	ITEM_TAG,
 	ITEM_L2TPV3OIP,
@@ -1030,11 +1029,6 @@ static const enum index item_pppoed[] = {
 
 static const enum index item_pppoes[] = {
 	ITEM_PPPOE_SEID,
-	ITEM_NEXT,
-	ZERO,
-};
-
-static const enum index item_pppoe_proto_id[] = {
 	ITEM_PPPOE_PROTO_ID,
 	ITEM_NEXT,
 	ZERO,
@@ -2643,10 +2637,9 @@ static const struct token token_list[] = {
 	[ITEM_PPPOE_PROTO_ID] = {
 		.name = "proto_id",
 		.help = "match PPPoE session protocol identifier",
-		.priv = PRIV_ITEM(PPPOE_PROTO_ID,
-				sizeof(struct rte_flow_item_pppoe_proto_id)),
-		.next = NEXT(item_pppoe_proto_id),
-		.call = parse_vc,
+		.next = NEXT(item_pppoes, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON
+			     (struct rte_flow_item_pppoe_proto_id, proto_id)),
 	},
 	[ITEM_HIGIG2] = {
 		.name = "higig2",
-- 
2.17.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2020-04-08 14:44 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-27  8:19 [dpdk-dev] app/testpmd: fix PPPOES flow API Xiao Zhang
2020-03-29  6:27 ` Ori Kam
2020-03-29  9:06   ` Zhang, Xiao
2020-03-29 10:18     ` Ori Kam
2020-03-29 12:00       ` Zhang, Xiao
2020-03-29 12:45         ` Ori Kam
2020-03-30  2:08           ` Zhang, Xiao
2020-03-30  7:42             ` Ori Kam
2020-03-30  8:49               ` Zhao1, Wei
2020-03-30  8:57                 ` Ori Kam
2020-03-30 14:22                   ` Zhang, Xiao
2020-03-31  6:55                     ` Ori Kam
2020-03-31  8:13                       ` Zhang, Xiao
2020-03-31  9:05                         ` Ori Kam
2020-03-31 13:04                           ` Zhang, Xiao
2020-03-31 13:29 ` [dpdk-dev] [v2] " Xiao Zhang
2020-04-05 15:12   ` Ori Kam
2020-04-08 14:44     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).