From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id BFFAC9436 for ; Mon, 7 Dec 2015 03:50:15 +0100 (CET) Received: by wmec201 with SMTP id c201so145901414wme.0 for ; Sun, 06 Dec 2015 18:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=E7uHVxKqEvdeVrqTIgQeqjFl0nqgTmUnS7aoK/K8UPY=; b=iwNTLhVa7pjhybqACF7hXE7q3LRyJcL+zI/6kdSPaxpkVkXN5XbAVC43E3eJuJGZgf krQgSt+JCBEMWh5Gxvy9ynbzPgjQreysegARlFKgOkuIeUZt7TpQtT3C42lc+04sUht1 knK64Wku+Y9dL8xw8Lj8dFuOf8fgGK0J96oFI1VgTinB3/23dPH+7hiFNGP1MEpj1pB4 xhDtSyA9Yhb+gT2FXV7y/0p8yJ5aFao4L5xCHRA5ECkhir83BLOy1By23Lz0t+sYzfZ2 E7pYjsUxvXhLK9jpoyde2X6AfgdxiGb7P3WnMfyVxcVznV0SM34tWG0tr3xykxG+aXy8 uP0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=E7uHVxKqEvdeVrqTIgQeqjFl0nqgTmUnS7aoK/K8UPY=; b=E0trp02+8yzRbBps0DQt4HLJH6QaPK2A1PN5jEGNo5k128I9yqqzPLmi76fok3VERh JlSigC4EdBVPeg5FC/rIX76a77EuhSagyLXhA9fuT9LcbScwLOG6e5D/7/FGN/MrcHQm A2+hVONSi1NJs27wDNJtCdIDaijU/im2WF/HM+hDcF1eRI1QITD85wOP/JqKGy/6+uVD RiQziVW1NlqS6thitTx1Hy5s2QJmKk5GRe05hxi+yR+AwMeD6p0a66RjkOtEujNH1bPb w3fryP93sfk4gCOdVsBtrKXHEtRSaOsmGE6u6xgOHXA3NqZ20C/X5k2lgHNmYLKpBzXe oXmA== X-Gm-Message-State: ALoCoQkDiB7X3cs5jAB/Ojon5aHh+CAyqTfeUdeDz6HqWH9icFPq3u5p/o/yL0UqTm33gozHs9IF X-Received: by 10.194.203.228 with SMTP id kt4mr30435706wjc.58.1449456615608; Sun, 06 Dec 2015 18:50:15 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id bg10sm22943943wjb.46.2015.12.06.18.50.14 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Dec 2015 18:50:15 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Date: Mon, 07 Dec 2015 03:49:03 +0100 Message-ID: <9938135.oiXrlPQS2m@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151207021843.GF29571@yliu-dev.sh.intel.com> References: <1449027793-30975-1-git-send-email-yuanhan.liu@linux.intel.com> <1717599.oECOgsfiks@xps13> <20151207021843.GF29571@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Victor Kaplansky , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH 1/4] vhost: handle VHOST_USER_SET_LOG_BASE request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 02:50:15 -0000 2015-12-07 10:18, Yuanhan Liu: > On Mon, Dec 07, 2015 at 03:03:24AM +0100, Thomas Monjalon wrote: > > 2015-12-07 10:00, Yuanhan Liu: > > > On Mon, Dec 07, 2015 at 12:07:28AM +0100, Thomas Monjalon wrote: > > > > 2015-12-02 15:53, Panu Matilainen: > > > > > This (and other changes in patch 2 breaks the librte_vhost ABI again, so > > > > > you'd need to at least add a deprecation note to 2.2 to be able to do it > > > > > in 2.3 at all according to the ABI policy. > > > > > > > > > > Perhaps a better option would be adding some padding to the structs now > > > > > for 2.2 since the vhost ABI is broken there anyway. That would at least > > > > > give a chance to keep it compatible from 2.2 to 2.3. > > > > > > > > Please could you point where the vhost ABI is broken in 2.2? > > > > > > Thomas, here are the changes to rte_virtio_net.h: > > > > > > > > > $ git diff 381316f6a225139d22d39b5ab8d50c40607924ca..19d4d7ef2a216b5418d8edb5b004d1a58bba3cc1 \ > > > -- lib/librte_vhost/rte_virtio_net.h > > > [...] > > > > The problem is that the changes are not noticed in the release notes > > and the LIBABIVER is still 1. > > Yeah, my bad. Firstly, I was not aware of it's an ABI change. Secondly, > I was landed to this team in the middle of v2.2 release, so that I have > limited experience of how those works in DPDK community. > > Anyway, it's my fault. I should have realized that in the first time. No it's not your fault, and it does not matter who is responsible. > Should I send a patch to update LIBABIVER to 2 and update release note > now? Yes today or tomorrow please.