From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3210A04B5; Tue, 27 Oct 2020 13:03:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E73132BDB; Tue, 27 Oct 2020 13:03:42 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E88432B9D for ; Tue, 27 Oct 2020 13:03:40 +0100 (CET) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.64]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 67CA36007A; Tue, 27 Oct 2020 12:03:39 +0000 (UTC) Received: from us4-mdac16-7.ut7.mdlocal (unknown [10.7.65.75]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 67274200AC; Tue, 27 Oct 2020 12:03:39 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.42]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id E3F72220052; Tue, 27 Oct 2020 12:03:38 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 675F8A40080; Tue, 27 Oct 2020 12:03:38 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Oct 2020 12:03:32 +0000 To: Ferruh Yigit , Ali Alnubani , "dev@dpdk.org" CC: Ivan Malov , David Marchand References: <1603183709-23420-1-git-send-email-arybchenko@solarflare.com> <1603185222-14831-1-git-send-email-arybchenko@solarflare.com> <1603185222-14831-15-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <9938bd7e-0566-6421-7c63-0cb2c22c675f@solarflare.com> Date: Tue, 27 Oct 2020 15:03:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25750.003 X-TM-AS-Result: No-0.912100-8.000000-10 X-TMASE-MatchedRID: L8tZF6zWW2rmLzc6AOD8DfHkpkyUphL9iRPU6vvejXLxtAAGoNJEICzr MMF3CEtHG7skt8lHRSeTH1CW/TkdqhHQbVLgwnYMboe6sMfg+k+qVvDKgPdBtVdZsJXctXRjEDq +ylzry5spuP6IRokm32Byrgx8giaexUKm1JGa16cBH+82q4Lh/EloPruIq9jTzVgwP7ZMYf9Lzd 6AIpnJzrrayfVfLsmBZ9+yP53+C/fMdO/aI0cjouNI3Mct2lzaamKrgqy61cKbKItl61J/ycnjL TA/UDoAoTCA5Efyn8CNo+PRbWqfRMZW5ai5WKlyZz+LRsIljww1Eouta9x0ye6bSf3WKXlrmL/d RXk1pAfN/gZhpBR4hsNx7JVNm7NkwRNIe6NwlcZXfRhnfJgLwEEU+9wPaA+KhXICXPkDTMLvGya LyWJvBWLqcdF40kDywzhVZiqhieFqbamnjuWv4A== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.912100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25750.003 X-MDID: 1603800219-0--4DQBxqXNe X-PPE-DISP: 1603800219;0--4DQBxqXNe Subject: Re: [dpdk-dev] [PATCH v2 14/62] common/sfc_efx/base: add action set spec init/fini APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/20 2:39 PM, Ferruh Yigit wrote: > On 10/27/2020 9:13 AM, Ali Alnubani wrote: >> Hi, >> Sent my report to v1 the first time by mistake. >> >>> -----Original Message----- >>> From: dev On Behalf Of Andrew Rybchenko >>> Sent: Tuesday, October 20, 2020 12:13 PM >>> To: dev@dpdk.org >>> Cc: Ivan Malov >>> Subject: [dpdk-dev] [PATCH v2 14/62] common/sfc_efx/base: add action >>> set >>> spec init/fini APIs >>> >>> From: Ivan Malov >>> >>> The engine is only able to carry out chosen actions on matching >>> packets in a >>> strict order. No MCDI exists to identify supported actions and the >>> order. >>> Still, the definition of the latter is available from the FW >>> documentation. >>> >>> The general idea is to define an action specification structure and >>> supply a >>> client driver with APIs for adding actions individually, >>> order-dependent. >>> A client driver is supposed to invoke an API on every action passed >>> by the >>> application, and if an out-of-order action follows, the API will >>> reject it. >>> >>> Add an action set specification stub and supply initialise / >>> finalise APIs. >>> >>> Signed-off-by: Ivan Malov >>> Signed-off-by: Andrew Rybchenko >>> Reviewed-by: Andy Moreton >>> --- >> >> This patch is causing the following build failure on CentOS 7 with >> clang 3.4.2: >> >> """ >> In file included from drivers/common/sfc_efx/base/efx_crc32.c:8: >> drivers/common/sfc_efx/base/efx_impl.h:1703:3: error: redefinition of >> typedef 'efx_mae_actions_t' is a C11 feature >> [-Werror,-Wtypedef-redefinition] } efx_mae_actions_t; >> drivers/common/sfc_efx/base/efx.h:4101:34: note: previous definition >> is here typedef struct efx_mae_actions_s efx_mae_actions_t; >> """ >> > > Hi Andrew, > > Are you working on this? Hi Ferruh, Yes, I have a patch. I will send it shortly. Andrew.