From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07297A0C41; Thu, 30 Sep 2021 14:51:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A30D40DDA; Thu, 30 Sep 2021 14:51:49 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 12F734067E for ; Thu, 30 Sep 2021 14:51:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="247716587" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="247716587" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 05:51:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="539418386" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga004.fm.intel.com with ESMTP; 30 Sep 2021 05:51:47 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 05:51:46 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 05:51:46 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 05:51:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2PQAWMaEg2LBRhNYLB1IubgpgdKGb1NwRoy/3ADBxsxnN6i9qiKPsecFApBw5c9tgJLYHzXM+310YtzmzwirasQhjzgac/wgjx+Msc/CzNdPUiyJOgzGBDLE4cop6xrPD8Fq0G8bE48Ytu7/altdvSjSTISoVZGAK8X4e32FlQGrxs2smPBZykkoCJZzRZwlAMfgU5/rpZ1wf7ZToRe8Rj72v7LYYPdzJ44uvVkYUU+hPF7w0CzeZuB+Sft8nrG0z+qWdH/oKj8tpNdZ7P1LXbwALE2xEwNwrbleVq+VPYj2VfODYzbbP35N64erCiOv5dV8JncW+q22MEfcBENgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nG/87Icmtyp7o7HRchsoq6Lk4ttWW+Nv12nNDcBv/ZQ=; b=UVQZ4pLSxexi5V39OwGprmBeOqsrqqifGb8xonWXgeg3b2tTeyF1Z5+4UnoBnv8FztuTLQRL3p7p16wUN69RD2CYDu+ZiTOjo+es3Do0QQeqL2yWNA9l5qpQz7a6Sa2830NOD0/T6vPCCDxkNVyXW1Th1BD9pCJHoSS3CodzF15/1fzHB6MJg9i68aiEau3EtjLlOUkm7dhp4/5BNbHJdQ5S5MEsP+2Pkw8raT3Nap3jsfl4Qp7fWjCbI5pOSfcctHmjy+9/ejcuBD4AtfADzAGVsFubxmFelejoq6OinUc7EBj9OaHi+mPzeiO/jjqEZgdvnXeNcM2LMiNhNgaMhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nG/87Icmtyp7o7HRchsoq6Lk4ttWW+Nv12nNDcBv/ZQ=; b=N2lsymSuSWZ2F3qTs27M/N1cLP4/IhfQ6joPH/vHhLXZVaypCI6ZRmEyLIqBa/oBav0ybfgfQlZsBhu0qZ0HsC0Sw5C+HgFARBwpb+OCPtvlQMfDQFpe/YlO8vibR82ZNBI9Awm6Jb83fnvHUYTbL60QgW97XfgxWnxRb9mU2BI= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from CY4PR11MB1367.namprd11.prod.outlook.com (2603:10b6:903:2d::16) by CY4PR1101MB2326.namprd11.prod.outlook.com (2603:10b6:903:b3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Thu, 30 Sep 2021 12:51:42 +0000 Received: from CY4PR11MB1367.namprd11.prod.outlook.com ([fe80::a00b:3347:5cd4:d190]) by CY4PR11MB1367.namprd11.prod.outlook.com ([fe80::a00b:3347:5cd4:d190%2]) with mapi id 15.20.4544.022; Thu, 30 Sep 2021 12:51:42 +0000 To: Andrew Rybchenko , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , "Beilei Xing" , Qiming Yang , Qi Zhang , Haiyue Wang , Matan Azrad , Viacheslav Ovsiienko , "Thomas Monjalon" , Ferruh Yigit CC: , Viacheslav Galaktionov References: <20210712161747.958019-1-andrew.rybchenko@oktetlabs.ru> <20210913112633.2836730-1-andrew.rybchenko@oktetlabs.ru> <2ddbed3f-6a65-6a6f-462a-4753860c9b2f@intel.com> <7d87e008-6493-075d-cd09-98a3aef399f7@oktetlabs.ru> From: "Singh, Aman Deep" Message-ID: <99404cce-3571-b73e-6736-4723ff067af8@intel.com> Date: Thu, 30 Sep 2021 18:21:27 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <7d87e008-6493-075d-cd09-98a3aef399f7@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: BM1PR01CA0155.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::25) To CY4PR11MB1367.namprd11.prod.outlook.com (2603:10b6:903:2d::16) MIME-Version: 1.0 Received: from [192.168.1.18] (223.178.212.150) by BM1PR01CA0155.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Thu, 30 Sep 2021 12:51:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c38a8f87-eb7f-46aa-4963-08d984110ce4 X-MS-TrafficTypeDiagnostic: CY4PR1101MB2326: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mb8TaBzcLvtsdzwoLVRKgAoijVf7SQtL3sQ+t52YAU+iDBuJ6uty6HBDYJx6psi403i1jPGzO9URPZ0vqF5m9FcUClchIiD0cekUdhedH8H5AATPZSUyEhcYHcAr1MUn+Zyxe7CpoqlT5kckBzA3X+VWunoHEwofDW97aUwSMX9obWz1eaWfr5Jb1ytk1wx9E+nTobJCX7sH3c32X8jeWML0Q1GS5P5+J6ZascdZBm1DeNtETgwsGICyQXJ1yz6qpaXZ4uVFruL+Gk1Zy719vzHNCfP52bdm2CzFB20HDy/FlRVI8YmSsCQq8/S08zA8ydwHv8H2wdyzhpci9YjlVeqPPhrxs3TsGh1X9OiTsPh96RBF4ZonPBc9VX0UJVN9qL0ie/m7+19gydyatTX04E3cgOELwdakcIfxAtZuWVtX3mUqEVhcfk0D/GlyKyz3Jzf2F9JBuGRW5Gl0dbE/EX++LIBcQNsNBB1nuyfxjEY6IuhFjUQqCGHAvQRDRJ6OSefMUSYQjD17eWFO0U2vXUXK+a3r2pDb8EiYLi5Z5D6cbDWvtyWmT2uhcz4QBZLEroHww8/jYgpOaIyu9CIFVG/dLPH6d1Wqj1ov97uU+m0ol3BKgOW2SQgczogzDKuKTgeWyxyklF6RXAG3s/zZK6B9LwTwNYIy/0VSS+h49aNoZ0OJ9iEJ6eoOG/uaBV1PM8x8qeedp0/h/57gHRxlpEKxtONVvqaNkRdL7kad9OW+pOLnOgWDPy2epjgng6+UmZnorYPQTGoJHfCO9LfcA363Rf9/pjVkm5X3KHL13Es/QuGC9OhL9qMy4DRDLUVSSc9DNle1KvYtU7wNijCxvQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1367.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(8936002)(186003)(6666004)(4326008)(2616005)(956004)(36756003)(31686004)(966005)(508600001)(53546011)(8676002)(921005)(2906002)(86362001)(5660300002)(83380400001)(38100700002)(66946007)(6636002)(6486002)(110136005)(66476007)(16576012)(31696002)(66556008)(316002)(7416002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODNRakMzczJScWtKYkdLMU9qNTNESUVTeVRTM3RzNGExL2VBeWtLR3l1Q1p3?= =?utf-8?B?VTVpQlBGNEhVQUdpL2FFMWZydHpwanN2MThEbDg2c1N4WVVyREFXdklWcW9I?= =?utf-8?B?VzdYU2JrZ2hXMS9xZUhpTEs4WnlPTVhJRDd6elM3MWNNWjJ6SHpqVDdTQ1ND?= =?utf-8?B?SUJEVEpnenI5QXZ0Q20wMmt0bDY4TG5wQVllbUhNbGY4ZWZtd2ZpQyttSk91?= =?utf-8?B?UTRKSnNXcGEzTXo1TFl6eVVrVlFIS1Q0MUl0VEZRVExqMktVWWRaNGp0K3I3?= =?utf-8?B?Q3VLK1Y3K0tEU05jLzZtRWZaOWpVOUdGMUdhaHRBdHg1RnZ3eVp1UlF4elkz?= =?utf-8?B?UEJsQmR0TC92Y1BZWitsOEp4MCtXTm1ibmdtb3YrdVFIZUlVUUNQVHBUWktG?= =?utf-8?B?WUQ4ZXVrYWM0WjVQYTJTbUJrYjlmMmxMYldwdFFhbTJNQmZTY3JuaFRkTzEx?= =?utf-8?B?MEU3Z2R2alNqdXZYeEY5NGxxaUw5QlEvcnFaZlpEV3p5V011R3VwU2VRSkFQ?= =?utf-8?B?RTF2SHpmTXp1bm11NDBVU2JuY0hxZGpmZmI0ZFlTcmpOeFBic0ZNcXdEcko5?= =?utf-8?B?ZnVQY3RoOWtMRGhPSWRJVm1XZjNkdzlRd2o3UXoyWkZ1Sm1GaHNLRk9sR09B?= =?utf-8?B?NkJCZUI5LzNYSGl4VTQrVWlQR0VJVmRwSURDbDRmS1VSeG9TRzduc3lhdEdv?= =?utf-8?B?L2RaNDRBOU52UnovWWFOSmc4SVNoRTNqUEp0SlZYbnVSU2lrYStmQkZSWDBu?= =?utf-8?B?cEYwZEZoK2dsMUttRTVLQnVyaEdKSGc4K2ZvS2xHY2FBRGVZVkgzVGE5YzU4?= =?utf-8?B?eU1wWGpreDlsazhZSW5zd0F0bjkwZTZoRDhxRjU3Sjd2QWNCSEphWnFOTXF1?= =?utf-8?B?K1VxSVRZOHErUEVrdEtzL0Q5VlVXQnd6T1U5R2xJYzg5dFJhTzVDd00yN0tJ?= =?utf-8?B?WGxjdUJEN29KWk1Dc0owU2dOeEpGeElWWVpCdS9pNVQ4NDMrYUJzMUMyYTFy?= =?utf-8?B?bytFZTJtMDk3TkxpK1FyZVd6SnZUYVVBUlpYTVlxT1NyLzZjMGZOZHRjS0Rq?= =?utf-8?B?bEM1cjZvQkY2djlqRktSMGozd3JMVVV4ZmY1TW1OQmhRTTh0RXVHc2l3dWtH?= =?utf-8?B?MFMybHpFRVBoRldCYWF0VEdjRlZqR0lMcjIyeVkvTGk5Y2E1YjNvN0lGeStk?= =?utf-8?B?aGt2MlhiOHZKc2N2SFROSll2MzZ2eDEzVEEyaDRpakgySjVwZjJXUkJyeUFH?= =?utf-8?B?eTRETzZmdlBzVGFVZU10bWhoV3pvQUFiY01HRE9pbFhSL1NGMEdHS1VBbEpl?= =?utf-8?B?R1pyNG5TS3ZrQSsrNkJhVDBjeEo0QTJQMS9zUy9lbzAxVUNmSEJlRi9aWlcx?= =?utf-8?B?V083TDEwbWU2TXZyQU9QRU5BWFB3MlpSdi9FdlNJS3NGK3pVdTlIOVRZNWtM?= =?utf-8?B?VXpmWU4xQ2NsRUFRVk9obFp5eDNEVURuYUhoU0JDN0RraG5LdWRpTlFWajhh?= =?utf-8?B?QVpYS2dObkVrVzUvT0JhZ3BjdC9hMGdQdUxIRUVTWG1wU1RkaTgwY1lHMnVC?= =?utf-8?B?SkxxZERNWHdWcEpqVDc4aFNTWGNnRVV4SUF1eWJHREphSzR0OTRXb1lwRzdS?= =?utf-8?B?QW5FdVAvY3Y1Q0tuWUFKc0xXSjlxdGUyTHFBNmw4a1JWSHJqb2NZOUczczdh?= =?utf-8?B?aXdhUkp2cWdweHVWUU40T3NIdkt1NVNvN2xwQ2hYcEljVVNld1AydytvRmJi?= =?utf-8?Q?EppsjNu2zIvP2dtaJJQz7FKMROyIeDF4CLYtb7L?= X-MS-Exchange-CrossTenant-Network-Message-Id: c38a8f87-eb7f-46aa-4963-08d984110ce4 X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1367.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 12:51:41.6993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bnWhu17eSFJ4CkcfuRrmTWl7N3m9RH0mi0epOobRI1SsB5HGrW/rzBUK7ryhqWHYMbLyhyJQkxmpuu7QWwhTafK4yiKR432YQw9n8b23dOA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2326 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/30/2021 5:33 PM, Andrew Rybchenko wrote: > On 9/29/21 2:13 PM, Singh, Aman Deep wrote: >> On 9/13/2021 4:56 PM, Andrew Rybchenko wrote: >>> From: Viacheslav Galaktionov >>> >>> Getting a list of representors from a representor does not make sense. >>> Instead, a parent device should be used. >>> >>> To this end, extend the rte_eth_dev_data structure to include the port ID >>> of the backing device for representors. >>> >>> Signed-off-by: Viacheslav Galaktionov >>> >>> Signed-off-by: Andrew Rybchenko >>> Acked-by: Haiyue Wang >>> Acked-by: Beilei Xing >>> --- >>> The new field is added into the hole in rte_eth_dev_data structure. >>> The patch does not change ABI, but extra care is required since ABI >>> check is disabled for the structure because of the libabigail bug [1]. >>> It should not be a problem anyway since 21.11 is a ABI breaking release. >>> >>> Potentially it is bad for out-of-tree drivers which implement >>> representors but do not fill in a new parert_port_id field in >>> rte_eth_dev_data structure. Get ID by name will not work. >> Did we change name of new field from parert_port_id to backer_port_id. > Yes, see v5 changelog below. > It is done to address review notes from Ferruh on v4. Maybe I did not put it clearly, my bad. Just wanted, in above lines also the usage of "parert_port_id" should be changed. > >>> mlx5 changes should be reviwed by maintainers very carefully, since >>> we are not sure if we patch it correctly. >>> >>> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=28060 >>> >>> v5: >>>      - try to improve name: backer_port_id instead of parent_port_id >>>      - init new field to RTE_MAX_ETHPORTS on allocation to avoid >>>        zero port usage by default >>> >>> v4: >>>      - apply mlx5 review notes: remove fallback from generic ethdev >>>        code and add fallback to mlx5 code to handle legacy usecase >>> >>> v3: >>>      - fix mlx5 build breakage >>> >>> v2: >>>      - fix mlx5 review notes >>>      - try device port ID first before parent in order to address >>>        backward compatibility issue > [snip] >