From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 066B746D7E; Thu, 21 Aug 2025 05:26:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90C2640292; Thu, 21 Aug 2025 05:26:03 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 23F9E4026C for ; Thu, 21 Aug 2025 05:26:01 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4c6pYT1kM0z2DcCK; Thu, 21 Aug 2025 11:23:09 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id CF4F21400CA; Thu, 21 Aug 2025 11:25:58 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 21 Aug 2025 11:25:58 +0800 Message-ID: <9940b2eb-f56c-4e8c-8d16-828fea5d8439@huawei.com> Date: Thu, 21 Aug 2025 11:25:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [V5 05/18] net/hinic3: add NIC event module To: Feifei Wang , CC: Xin Wang , Yi Chen , Feifei Wang References: <20250418090621.9638-1-wff_light@vip.163.com> <20250702020953.599-1-wff_light@vip.163.com> <20250702020953.599-6-wff_light@vip.163.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20250702020953.599-6-wff_light@vip.163.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: kwepems500002.china.huawei.com (7.221.188.17) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/2/2025 10:09 AM, Feifei Wang wrote: > From: Xin Wang > > > Currently, there are two types of events: pf/vf connection status > > and port information printing. This patch contains related data > > structures and function codes. > > > > Signed-off-by: Xin Wang > > Reviewed-by: Yi Chen > > Reviewed-by: Feifei Wang > > --- > > drivers/net/hinic3/base/hinic3_nic_event.c | 433 +++++++++++++++++++++ > > drivers/net/hinic3/base/hinic3_nic_event.h | 39 ++ > > 2 files changed, 472 insertions(+) > > create mode 100644 drivers/net/hinic3/base/hinic3_nic_event.c > > create mode 100644 drivers/net/hinic3/base/hinic3_nic_event.h > > > > diff --git a/drivers/net/hinic3/base/hinic3_nic_event.c b/drivers/net/hinic3/base/hinic3_nic_event.c > > new file mode 100644 > > index 0000000000..fb779fcf25 > > --- /dev/null > > +++ b/drivers/net/hinic3/base/hinic3_nic_event.c > > @@ -0,0 +1,433 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2025 Huawei Technologies Co., Ltd > > + */ > > + > > +#include "hinic3_compat.h" > > +#include "hinic3_cmd.h" > > +#include "hinic3_hwif.h" > > +#include "hinic3_nic_cfg.h" > > +#include "hinic3_hwdev.h" > > +#include "hinic3_nic_event.h" > > +#include "hinic3_ethdev.h" > > + > > +static const char *g_hw_to_char_fec[HILINK_FEC_MAX_TYPE] = { > > + "not set", "rsfec", "basefec", "nofec", "llrsfec", > > +}; > > +static const char *g_hw_to_speed_info[PORT_SPEED_UNKNOWN] = { > > + "not set", "10MB", "100MB", "1GB", "10GB", > > + "25GB", "40GB", "50GB", "100GB", "200GB", > > +}; > > +static const char *g_hw_to_an_state_info[PORT_CFG_AN_OFF + 1] = { > > + "not set", > > + "on", > > + "off", > > +}; > > + > > +struct port_type_table { > > + u32 port_type; > > + const char *port_type_name; > > +}; > > + > > +void > > +get_port_info(struct hinic3_hwdev *hwdev, u8 link_state, > > + struct rte_eth_link *link) > > +{ > > + uint32_t port_speed[LINK_SPEED_LEVELS] = { > > + RTE_ETH_SPEED_NUM_NONE, RTE_ETH_SPEED_NUM_10M, > > + RTE_ETH_SPEED_NUM_100M, RTE_ETH_SPEED_NUM_1G, > > + RTE_ETH_SPEED_NUM_10G, RTE_ETH_SPEED_NUM_25G, > > + RTE_ETH_SPEED_NUM_40G, RTE_ETH_SPEED_NUM_50G, > > + RTE_ETH_SPEED_NUM_100G, RTE_ETH_SPEED_NUM_200G, > > + }; > > + struct nic_port_info port_info = {0}; > > + int err; > > + > > + if (!link_state) { > > + link->link_status = RTE_ETH_LINK_DOWN; > > + link->link_speed = RTE_ETH_SPEED_NUM_NONE; > > + link->link_duplex = RTE_ETH_LINK_HALF_DUPLEX; > > + link->link_autoneg = RTE_ETH_LINK_FIXED; > > + } else { > > + link->link_status = RTE_ETH_LINK_UP; > > + > > + err = hinic3_get_port_info(hwdev, &port_info); > > + if (err) { > > + link->link_speed = RTE_ETH_SPEED_NUM_NONE; > > + link->link_duplex = RTE_ETH_LINK_FULL_DUPLEX; > > + link->link_autoneg = RTE_ETH_LINK_FIXED; > > + } else { > > + link->link_speed = > > + port_speed[port_info.speed % LINK_SPEED_LEVELS]; > > + link->link_duplex = port_info.duplex; > > + link->link_autoneg = port_info.autoneg_state; > > + } > > + } > > +} > > + > > +static void > > +hinic3_link_event_stats(void *dev, u8 link) > > +{ > > + struct hinic3_hwdev *hwdev = dev; > > + > > + if (link) > > + rte_atomic_fetch_add_explicit(&hwdev->hw_stats.link_event_stats.link_up_stats, > > + 1, rte_memory_order_seq_cst); > > + else > > + rte_atomic_fetch_add_explicit(&hwdev->hw_stats.link_event_stats.link_down_stats, > > + 1, rte_memory_order_seq_cst); > > +} > > + > > +static void > > +hinic3_set_vport_state(struct hinic3_hwdev *hwdev, > > + struct hinic3_cmd_link_state *link_state) > > +{ > > + struct hinic3_nic_dev *nic_dev = NULL; > > + int err = 0; > > + > > + nic_dev = HINIC3_ETH_DEV_TO_PRIVATE_NIC_DEV((struct rte_eth_dev *)(hwdev->eth_dev)); > > + > > + if (link_state->state) { > > + if (hinic3_get_bit(HINIC3_DEV_START, &nic_dev->dev_status)) > > + err = hinic3_set_vport_enable(hwdev, true); > > + } else { > > + err = hinic3_set_vport_enable(hwdev, false); > > + } > > + > > + if (err) > > + PMD_DRV_LOG(ERR, "Set vport status failed"); > > +} > > + > > +static void > > +link_status_event_handler(void *hwdev, void *buf_in, __rte_unused u16 in_size, > > + __rte_unused void *buf_out, > > + __rte_unused u16 *out_size) > > +{ > > + struct hinic3_cmd_link_state *link_status = NULL; > > + struct rte_eth_link link; > > + struct hinic3_hwdev *dev = hwdev; > > + int err; > > + > > + link_status = buf_in; > > + PMD_DRV_LOG(INFO, > > + "Link status report received, func_id: %d, status: %d(%s)", > > + hinic3_global_func_id(hwdev), link_status->state, > > + link_status->state ? "UP" : "DOWN"); > > + > > + hinic3_link_event_stats(hwdev, link_status->state); > > + > > + hinic3_set_vport_state(dev, link_status); > > + > > + /* Link event reported only after set vport enable. */ > > + get_port_info(dev, link_status->state, &link); > > + err = rte_eth_linkstatus_set((struct rte_eth_dev *)(dev->eth_dev), > > + &link); > > + if (!err) > > + rte_eth_dev_callback_process(dev->eth_dev, > > + RTE_ETH_EVENT_INTR_LSC, NULL); Please report lsc event when dev->data->dev_conf.intr_conf.lsc = 1 > > +} > > + > > +static const char * > > +get_port_type_name(u32 type) > > +{ > > + int i; > > + const struct port_type_table port_optical_type_table_s[] = { > > + {LINK_PORT_UNKNOWN, "UNKNOWN"}, > > + {LINK_PORT_OPTICAL_MM, "optical_sr"}, > > + {LINK_PORT_OPTICAL_SM, "optical_lr"}, > > + {LINK_PORT_PAS_COPPER, "copper"}, > > + {LINK_PORT_ACC, "ACC"}, > > + {LINK_PORT_BASET, "baset"}, > > + {LINK_PORT_AOC, "AOC"}, > > + {LINK_PORT_ELECTRIC, "electric"}, > > + {LINK_PORT_BACKBOARD_INTERFACE, "interface"}, > > + }; > > + > > + for (i = 0; i < ARRAY_LEN(port_optical_type_table_s); i++) { > > + if (type == port_optical_type_table_s[i].port_type) > > + return port_optical_type_table_s[i].port_type_name; > > + } > > + return "UNKNOWN TYPE"; > > +} > > + > > +static void > > +get_port_type(struct mag_cmd_event_port_info *port_info, const char **port_type) > > +{ > > + if (port_info->port_type <= LINK_PORT_BACKBOARD_INTERFACE) > > + *port_type = get_port_type_name(port_info->port_type); > > + else > > + PMD_DRV_LOG(INFO, "Unknown port type: %u", > > + port_info->port_type); No need to break the lines. suggest cleanup because too much such case. And how about set an default return value for port_type > > +} > > + > > +static int > > +get_port_temperature_power(struct mag_cmd_event_port_info *info, char *str) > > +{ > > + char arr[CAP_INFO_MAX_LEN]; > > + > > + snprintf(arr, CAP_INFO_MAX_LEN - 1, "%s, %s, Temperature: %u", str, > > + info->sfp_type ? "QSFP" : "SFP", info->cable_temp); > > + if (info->sfp_type) > > + snprintf(str, CAP_INFO_MAX_LEN - 1, > > + "%s, rx power: %uuw %uuW %uuW %uuW", arr, > > + info->power[0x0], info->power[0x1], info->power[0x2], > > + info->power[0x3]); > > + else > > + snprintf(str, CAP_INFO_MAX_LEN - 1, > > + "%s, rx power: %uuW, tx power: %uuW", arr, > > + info->power[0x0], info->power[0x1]); > > + > > + return 0; > > +} > > + > > +static void > > +print_cable_info(struct mag_cmd_event_port_info *port_info) > > +{ > > + char tmp_str[CAP_INFO_MAX_LEN] = {0}; > > + char tmp_vendor[VENDOR_MAX_LEN] = {0}; how about just char str[] and vendor[] > > + const char *port_type = "Unknown port type"; > > + int i; > > + int err = 0; > > + if (port_info->gpio_insert) { > > + PMD_DRV_LOG(INFO, "Cable unpresent"); > > + return; > > + } > > + > > + get_port_type(port_info, &port_type); > > + > > + for (i = (int)sizeof(port_info->vendor_name) - 1; i >= 0; i--) { > > + if (port_info->vendor_name[i] == ' ') > > + port_info->vendor_name[i] = '\0'; > > + else > > + break; > > + } what the above means? how about set the terminal character when setting port_info->vendor_name? > > + > > + memcpy(tmp_vendor, port_info->vendor_name, > > + sizeof(port_info->vendor_name)); > > + snprintf(tmp_str, CAP_INFO_MAX_LEN - 1, > > + "Vendor: %s, %s, length: %um, max_speed: %uGbps", > > + tmp_vendor, port_type, port_info->cable_length, > > + port_info->max_speed); > > + > > + if (port_info->port_type == LINK_PORT_OPTICAL_MM || > > + port_info->port_type == LINK_PORT_AOC) { > > + err = get_port_temperature_power(port_info, tmp_str); > > + if (err) > > + return; > > + } > > + > > + PMD_DRV_LOG(INFO, "Cable information: %s", tmp_str); > > +} > > + > > +static void > > +print_link_info(struct mag_cmd_event_port_info *port_info) > > +{ > > + const char *fec = "None"; > > + const char *speed = "None"; > > + const char *an_state = "None"; > > + > > + if (port_info->fec < HILINK_FEC_MAX_TYPE) > > + fec = g_hw_to_char_fec[port_info->fec]; > > + else > > + PMD_DRV_LOG(INFO, "Unknown fec type: %u", port_info->fec); > > + > > + if (port_info->an_state > PORT_CFG_AN_OFF) { > > + PMD_DRV_LOG(INFO, "an_state %u is invalid", > > + port_info->an_state); > > + return; > > + } > > + > > + an_state = g_hw_to_an_state_info[port_info->an_state]; > > + > > + if (port_info->speed >= PORT_SPEED_UNKNOWN) { > > + PMD_DRV_LOG(INFO, "speed %u is invalid", port_info->speed); > > + return; > > + } > > + > > + speed = g_hw_to_speed_info[port_info->speed]; > > + PMD_DRV_LOG(INFO, "Link information: speed %s, %s, autoneg %s", speed, > > + fec, an_state); there is eth_dump callback, maybe it should in dump API. > > +} > > + > > +static void > > +print_port_info(void *hwdev, struct mag_cmd_event_port_info *port_info, u8 type) > > +{ > > + print_cable_info(port_info); > > + > > + print_link_info(port_info); > > + > > + if (type == RTE_ETH_LINK_UP) > > + return; > > + > > + PMD_DRV_LOG(INFO, "Function %d link down msg:", > > + hinic3_global_func_id(hwdev)); > > + > > + PMD_DRV_LOG(INFO, > > + "PMA ctrl: %s, tx %s, rx %s, PMA fifo reg: 0x%x, " > > + "PMA signal ok reg: 0x%x, RF/LF status reg: 0x%x", > > + port_info->pma_ctrl == 1 ? "off" : "on", > > + port_info->tx_enable ? "enable" : "disable", > > + port_info->rx_enable ? "enable" : "disable", > > + port_info->pma_fifo_reg, port_info->pma_signal_ok_reg, > > + port_info->rf_lf); > > + PMD_DRV_LOG(INFO, > > + "alos: %u, rx_los: %u, PCS 64 66b reg: 0x%x, " > > + "PCS link: 0x%x, MAC link: 0x%x, PCS_err_cnt: 0x%x", > > + port_info->alos, port_info->rx_los, > > + port_info->pcs_64_66b_reg, port_info->pcs_link, > > + port_info->pcs_mac_link, port_info->pcs_err_cnt); > > + PMD_DRV_LOG(INFO, > > + "his_link_machine_state = 0x%08x, " > > + "cur_link_machine_state = 0x%08x", > > + port_info->his_link_machine_state, > > + port_info->cur_link_machine_state); > > +} > > + > > +static void > > +port_info_event_printf(void *hwdev, void *buf_in, __rte_unused u16 in_size, > > + __rte_unused void *buf_out, __rte_unused u16 *out_size) buf_out was used, so no need add unused prefix. > > +{ > > + struct mag_cmd_event_port_info *port_info = buf_in; > > + ((struct mag_cmd_event_port_info *)buf_out)->head.status = 0; > > + enum hinic3_nic_event_type type = port_info->event_type; > > + if (type < RTE_ETH_LINK_DOWN || type > RTE_ETH_LINK_UP) { > > + PMD_DRV_LOG(ERR, "Invalid hilink info report, type: %d", > > + type); > > + return; > > + } > > + > > + print_port_info(hwdev, port_info, type); > > +} > > + > > +struct nic_event_handler { > > + u16 cmd; > > + void (*handler)(void *hwdev, void *buf_in, u16 in_size, void *buf_out, > > + u16 *out_size); > > +}; > > + > > +static const struct nic_event_handler nic_cmd_handler[] = {}; > > + > > +/** > > + * Handle NIC event based on the provided command. > > + * > > + * @param[in] hwdev > > + * Pointer to hardware device structure. > > + * @param[in] cmd > > + * The command associated with the NIC event to be handled. > > + * @param[in] buf_in > > + * The input buffer containing the event data. > > + * @param[in] in_size > > + * The size of the input buffer. > > + * @param[out] buf_out > > + * The output buffer to store the event response. > > + * @param[out] out_size > > + * The size of the output data stored in the output buffer. > > + */ > > +static void > > +nic_event_handler(void *hwdev, u16 cmd, void *buf_in, u16 in_size, > > + void *buf_out, u16 *out_size) > > +{ > > + u32 i, size = ARRAY_LEN(nic_cmd_handler); > > + > > + if (!hwdev) > > + return; > > + > > + *out_size = 0; > > + > > + for (i = 0; i < size; i++) { > > + if (cmd == nic_cmd_handler[i].cmd) { > > + nic_cmd_handler[i].handler(hwdev, buf_in, in_size, > > + buf_out, out_size); > > + break; > > + } > > + } > > + > > + if (i == size) > > + PMD_DRV_LOG(WARNING, "Unsupported nic event cmd(%d) to process", > > + cmd); why not ERROR? > > +} > > + > > +/* > > + * VF handler mbox msg from ppf/pf. > > + * VF link change event. > > + */ > > +int > > +hinic3_vf_event_handler(void *hwdev, __rte_unused void *pri_handle, u16 cmd, > > + void *buf_in, u16 in_size, void *buf_out, u16 *out_size) > > +{ > > + nic_event_handler(hwdev, cmd, buf_in, in_size, buf_out, out_size); > > + return 0; > > +} > > + > > +/* NIC event of PF/PPF handler reported by mgmt cpu. */ > > +void > > +hinic3_pf_event_handler(void *hwdev, __rte_unused void *pri_handle, u16 cmd, > > + void *buf_in, u16 in_size, void *buf_out, u16 *out_size) > > +{ > > + nic_event_handler(hwdev, cmd, buf_in, in_size, buf_out, out_size); > > +} > > + > > +static const struct nic_event_handler mag_cmd_handler[] = { > > + { > > + .cmd = MAG_CMD_GET_LINK_STATUS, > > + .handler = link_status_event_handler, > > + }, > > + { > > + .cmd = MAG_CMD_EVENT_PORT_INFO, > > + .handler = port_info_event_printf, > > + }, > > +}; > > + > > +static int > > +hinic3_mag_event_handler(void *hwdev, u16 cmd, void *buf_in, u16 in_size, > > + void *buf_out, u16 *out_size) > > +{ > > + u32 size = ARRAY_LEN(mag_cmd_handler); > > + u32 i; > > + > > + if (!hwdev) > > + return -EINVAL; > > + > > + *out_size = 0; > > + for (i = 0; i < size; i++) { > > + if (cmd == mag_cmd_handler[i].cmd) { > > + mag_cmd_handler[i].handler(hwdev, buf_in, in_size, > > + buf_out, out_size); > > + break; > > + } > > + } > > + > > + /* Can't find this event cmd. */ > > + if (i == size) > > + PMD_DRV_LOG(ERR, "Unsupported mag event, cmd: %u", cmd); > > + > > + return 0; > > +} > > + > > +int > > +hinic3_vf_mag_event_handler(void *hwdev, __rte_unused void *pri_handle, u16 cmd, > > + void *buf_in, u16 in_size, void *buf_out, > > + u16 *out_size) > > +{ > > + return hinic3_mag_event_handler(hwdev, cmd, buf_in, in_size, buf_out, > > + out_size); > > +} > > + > > +/* pf/ppf handler mgmt cpu report hilink event. */ > > +void > > +hinic3_pf_mag_event_handler(void *hwdev, __rte_unused void *pri_handle, u16 cmd, > > + void *buf_in, u16 in_size, void *buf_out, > > + u16 *out_size) > > +{ > > + hinic3_mag_event_handler(hwdev, cmd, buf_in, in_size, buf_out, > > + out_size); > > +} > > + > > +u8 > > +hinic3_nic_sw_aeqe_handler(__rte_unused void *hwdev, u8 event, u8 *data) > > +{ > > + PMD_DRV_LOG(ERR, > > + "Received nic ucode aeq event type: 0x%x, data: %" PRIu64, > > + event, *((u64 *)data)); > > + > > + return 0; > > +} > > diff --git a/drivers/net/hinic3/base/hinic3_nic_event.h b/drivers/net/hinic3/base/hinic3_nic_event.h > > new file mode 100644 > > index 0000000000..6a792e6af5 > > --- /dev/null > > +++ b/drivers/net/hinic3/base/hinic3_nic_event.h > > @@ -0,0 +1,39 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2025 Huawei Technologies Co., Ltd > > + */ > > + > > +#ifndef _HINIC3_NIC_EVENT_H_ > > +#define _HINIC3_NIC_EVENT_H_ > > + > > +/** > > + * Get the Ethernet port link information based on the link state. > > + * > > + * @param[in] hwdev > > + * The hardware device context. > > + * @param[in] link_state > > + * The current link state (0 = down, non-zero = up). > > + * @param[out] link > > + * Pointer to the `rte_eth_link` structure. > > + */ > > +void get_port_info(struct hinic3_hwdev *hwdev, u8 link_state, > > + struct rte_eth_link *link); > > + > > +int hinic3_vf_event_handler(void *hwdev, __rte_unused void *pri_handle, u16 cmd, > > + void *buf_in, u16 in_size, void *buf_out, > > + u16 *out_size); > > + > > +void hinic3_pf_event_handler(void *hwdev, __rte_unused void *pri_handle, > > + u16 cmd, void *buf_in, u16 in_size, void *buf_out, > > + u16 *out_size); > > + > > +int hinic3_vf_mag_event_handler(void *hwdev, void *pri_handle, u16 cmd, > > + void *buf_in, u16 in_size, void *buf_out, > > + u16 *out_size); > > + > > +void hinic3_pf_mag_event_handler(void *hwdev, void *pri_handle, u16 cmd, > > + void *buf_in, u16 in_size, void *buf_out, > > + u16 *out_size); > > + > > +u8 hinic3_nic_sw_aeqe_handler(__rte_unused void *hwdev, u8 event, u8 *data); > > + > > +#endif /* _HINIC3_NIC_EVENT_H_ */ >