From: Yongseok Koh <yskoh@mellanox.com>
To: Asaf Penso <asafp@mellanox.com>
Cc: dev <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>,
Matan Azrad <matan@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix non-matching parameters documentation
Date: Mon, 17 Sep 2018 21:07:20 +0000 [thread overview]
Message-ID: <99509D4F-E08F-46ED-8F9A-3318D28AC091@mellanox.com> (raw)
In-Reply-To: <1537200189-18241-1-git-send-email-asafp@mellanox.com>
> On Sep 17, 2018, at 9:03 AM, Asaf Penso <asafp@mellanox.com> wrote:
>
> tso and vlan parameters were removed from the signature
> of txq_mbuf_to_swp function.
>
> The documentation of the function was not updated accordingly.
>
> Remove the tso and vlan documentation to match the function signature.
>
> Fixes: 8f6d9e13a98c ("net/mlx5: remove redundant checks")
> Cc: yskoh@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Asaf Penso <asafp@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks and welcome to the DPDK world!
Yongseok
> drivers/net/mlx5/mlx5_rxtx.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
> index d225b9c..f5c1005 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.h
> +++ b/drivers/net/mlx5/mlx5_rxtx.h
> @@ -713,10 +713,6 @@ uint16_t mlx5_rx_burst_vec(void *dpdk_txq, struct rte_mbuf **pkts,
> * Pointer to the Tx queue.
> * @param buf
> * Pointer to the mbuf.
> - * @param tso
> - * TSO offloads enabled.
> - * @param vlan
> - * VLAN offloads enabled
> * @param offsets
> * Pointer to the SWP header offsets.
> * @param swp_types
> --
> 1.8.3.1
>
next parent reply other threads:[~2018-09-17 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1537200189-18241-1-git-send-email-asafp@mellanox.com>
2018-09-17 21:07 ` Yongseok Koh [this message]
2018-09-18 12:51 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-29 11:39 [dpdk-dev] " Asaf Penso
2018-11-29 17:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99509D4F-E08F-46ED-8F9A-3318D28AC091@mellanox.com \
--to=yskoh@mellanox.com \
--cc=asafp@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).