Re: [dpdk-dev] [PATCH] net/mlx5: fix non-matching parameters documentation

Re: [dpdk-dev] [PATCH] net/mlx5: fix non-matching parameters documentation

[Yongseok Koh]

> On Sep 17, 2018, at 9:03 AM, Asaf Penso <asafp@mellanox.com> wrote:
> 
> tso and vlan parameters were removed from the signature
> of txq_mbuf_to_swp function.
> 
> The documentation of the function was not updated accordingly.
> 
> Remove the tso and vlan documentation to match the function signature.
> 
> Fixes: 8f6d9e13a98c ("net/mlx5: remove redundant checks")
> Cc: yskoh@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Asaf Penso <asafp@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>

Thanks and welcome to the DPDK world!
Yongseok

> drivers/net/mlx5/mlx5_rxtx.h | 4 ----
> 1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
> index d225b9c..f5c1005 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.h
> +++ b/drivers/net/mlx5/mlx5_rxtx.h
> @@ -713,10 +713,6 @@ uint16_t mlx5_rx_burst_vec(void *dpdk_txq, struct rte_mbuf **pkts,
>  *   Pointer to the Tx queue.
>  * @param buf
>  *   Pointer to the mbuf.
> - * @param tso
> - *   TSO offloads enabled.
> - * @param vlan
> - *   VLAN offloads enabled
>  * @param offsets
>  *   Pointer to the SWP header offsets.
>  * @param swp_types
> -- 
> 1.8.3.1
> 

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix non-matching parameters documentation

[Ferruh Yigit]

On 9/17/2018 10:07 PM, Yongseok Koh wrote:
> 
>> On Sep 17, 2018, at 9:03 AM, Asaf Penso <asafp@mellanox.com> wrote:
>>
>> tso and vlan parameters were removed from the signature
>> of txq_mbuf_to_swp function.
>>
>> The documentation of the function was not updated accordingly.
>>
>> Remove the tso and vlan documentation to match the function signature.
>>
>> Fixes: 8f6d9e13a98c ("net/mlx5: remove redundant checks")
>> Cc: yskoh@mellanox.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Asaf Penso <asafp@mellanox.com>
>> ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
> 
> Thanks and welcome to the DPDK world!
> Yongseok

Hi Asaf, Yongseok,

Is this patch hit the mail list? I don't see it both in mail list and patchwork.
Perhaps Asaf needs to register to mail list?

btw, welcome Asaf :)

[dpdk-dev] [PATCH] net/mlx5: fix non-matching parameters documentation

[Asaf Penso]

tso and vlan parameters were removed from the signature
of txq_mbuf_to_swp function.

The documentation of the function was not updated accordingly.

Remove the tso and vlan documentation to match the function signature.

Fixes: 8f6d9e13a98c ("net/mlx5: remove redundant checks")
Cc: yskoh@mellanox.com

Signed-off-by: Asaf Penso <asafp@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index f47d327..75194a3 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -733,10 +733,6 @@ uint32_t mlx5_tx_update_ext_mp(struct mlx5_txq_data *txq, uintptr_t addr,
  *   Pointer to the Tx queue.
  * @param buf
  *   Pointer to the mbuf.
- * @param tso
- *   TSO offloads enabled.
- * @param vlan
- *   VLAN offloads enabled
  * @param offsets
  *   Pointer to the SWP header offsets.
  * @param swp_types
-- 
1.7.1

Re: [dpdk-dev] [PATCH] net/mlx5: fix non-matching parameters documentation

[Ferruh Yigit]

On 11/29/2018 11:39 AM, Asaf Penso wrote:
> tso and vlan parameters were removed from the signature
> of txq_mbuf_to_swp function.
> 
> The documentation of the function was not updated accordingly.
> 
> Remove the tso and vlan documentation to match the function signature.
> 
> Fixes: 8f6d9e13a98c ("net/mlx5: remove redundant checks")
> Cc: yskoh@mellanox.com
> 
> Signed-off-by: Asaf Penso <asafp@mellanox.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.