From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 805F4433E8; Tue, 28 Nov 2023 13:11:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1341940E54; Tue, 28 Nov 2023 13:11:08 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id A0128402C2 for ; Tue, 28 Nov 2023 13:11:06 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Sfh9R3lJ3zWhqF; Tue, 28 Nov 2023 20:10:19 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 28 Nov 2023 20:11:01 +0800 Message-ID: <996205d4-05ac-387d-798d-e19e9709b95d@huawei.com> Date: Tue, 28 Nov 2023 20:11:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 02/11] doc: add Traffic Manager feature for iavf To: Ferruh Yigit , CC: , , Jingjing Wu , Beilei Xing References: <20231128060934.2446-1-lihuisong@huawei.com> <20231128060934.2446-3-lihuisong@huawei.com> <80c18c37-4080-4efd-83b3-27cf385cf36f@amd.com> <93148b23-38f1-481c-8c6e-f37a1c90b6f4@amd.com> From: "lihuisong (C)" In-Reply-To: <93148b23-38f1-481c-8c6e-f37a1c90b6f4@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/11/28 19:55, Ferruh Yigit 写道: > On 11/28/2023 11:47 AM, lihuisong (C) wrote: >> 在 2023/11/28 18:35, Ferruh Yigit 写道: >>> On 11/28/2023 6:09 AM, Huisong Li wrote: >>>> Add Traffic Manager feature for iavf. >>>> >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Huisong Li >>>> --- >>>>   doc/guides/nics/features/iavf.ini | 1 + >>>>   1 file changed, 1 insertion(+) >>>> >>>> diff --git a/doc/guides/nics/features/iavf.ini >>>> b/doc/guides/nics/features/iavf.ini >>>> index db4f92ce71..385799c650 100644 >>>> --- a/doc/guides/nics/features/iavf.ini >>>> +++ b/doc/guides/nics/features/iavf.ini >>>> @@ -35,6 +35,7 @@ Inner L4 checksum    = Y >>>>   Packet type parsing  = Y >>>>   Rx descriptor status = Y >>>>   Tx descriptor status = Y >>>> +Traffic manager      = Y >>>>   Inline crypto        = Y >>>>   Basic stats          = Y >>>>   Multiprocess aware   = Y >>> Can you please keep the order in the default.ini and other files same, >>> here 'Inline crypto' seems put into wrong order that is causing the >>> confusion, >>> but new fields seems need to go between 'VLAN filter' & 'CRC offload'. >>> . >> Hi Ferruh, >> >> I find that there are many place which is different from the order of >> default.ini. >> And other drivers also have this problem. >> I want to do it for all drivers after this series. >> What do you think of that? >> > Agree to fix the order later with a separate patch, and keep the order > as best as possible in this series. ok，will adjust the order of this file a little bit. > .