From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60060.outbound.protection.outlook.com [40.107.6.60]) by dpdk.org (Postfix) with ESMTP id E7F971B1FC for ; Thu, 27 Sep 2018 13:13:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5BvQ3OFWeWAS5R2e6ACMxP8Xf87eXM8mPr5tmV9g900=; b=OCAnnIDbdySSD4sZDeH7x+qI0bZuQ3fmRTM/HqvdCRpCkHU4p9HMEUj5vQ+vGPD2Nv3yHB35F6XnIvCxZPovxp3esgQIqyDO4obmbYNaaRhchPRrCUppH25jtNa1BhG/5oW3NcEI92iLQTGC0kIUJepoOA7HBE0jcEbPKBUv6a8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by VI1PR04MB4686.eurprd04.prod.outlook.com (2603:10a6:803:71::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1164.22; Thu, 27 Sep 2018 11:13:16 +0000 To: "Burakov, Anatoly" , dev@dpdk.org Cc: Neil Horman , John McNamara , Marko Kovacevic , Hemant Agrawal , Matan Azrad , Shahaf Shuler , Yongseok Koh , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Bruce Richardson , Olivier Matz , Andrew Rybchenko , laszlo.madarassy@ericsson.com, laszlo.vadkerti@ericsson.com, andras.kovacs@ericsson.com, winnie.tian@ericsson.com, daniel.andrasi@ericsson.com, janos.kobor@ericsson.com, geza.koblo@ericsson.com, srinath.mannam@broadcom.com, scott.branden@broadcom.com, ajit.khaparde@broadcom.com, keith.wiles@intel.com, thomas@monjalon.net, alejandro.lucero@netronome.com References: From: Shreyansh Jain Message-ID: <996b0784-8516-8d89-e5e4-4c3f7bdda50a@nxp.com> Date: Thu, 27 Sep 2018 16:42:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: MAXPR0101CA0034.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::20) To VI1PR04MB4686.eurprd04.prod.outlook.com (2603:10a6:803:71::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 681e5cf7-f8f7-4ffc-844c-08d6246a3fae X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB4686; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4686; 3:xWS0SvNBKE92O/q15of9gabXJM+k20ClwbWwfKOl5te76ZqzcfVa4Gq+3v0N54I1+thKJGrSACeuidXwFltTnfbF1LxapOvFe21XuJTbHVWzeJyE3RT5xuV5xtK5T63oJrpgEF8/9ndQ5RbVnvT3HXwA66xilIhHi3TNsIdD999y4In/94EGYuV48fsM5TzzVwJOH63SJ53Mbzi5GMiY6qJtVoB5Mv0vfE/hM8u92C1n0hVhG8RwgT+erihFfPij; 25:xZfcrIoPXLMaBsdFpzb4Y6jPERVzn6Qj6rCaymkIUs40yVTfCeY9QmnM/hE6GKtXgmAUFqRp5npmjjTMkjfWKw3sMHFTw/idAXIVTYv7gGn53sKNOnx/ZCCh0/lMqLxlYLHbL8VFp1Cw4NjHqoQ3XQdc4p/bY2+9mh5hcbFQE1IThmJr6baRlNesLHH+Qa1sBjJfdQgcd4jJLLSGR1AIOn/9EixRBX7rVekBXbmVG4dASe6OmgfKR6SOQNgTa2mekcBlP795jLSHIcbs4AmHnYEj3sV5pleB3tc9e5YKhGOFltDapyJpRDtzUA1G+OTCFTWMgO9TaIXyyptU1RLVdw==; 31:U2Ef5QfIYj7elulVf2FNN1MztMqBfdxHBVka6EKtRKWr1KExuHWAmbRnj3FLxQQT5+k7qp0MjA3Rbl+eTxLZUucGyQxBpOD/WDzWhjMpeK8/tPzPnD7cX/BbAY3kFxSaExiuPXssa4LuxSW6yUTzTgcRrE6nDUSIhMxgJIqqrW/OJAvA6TP8O0LXrALOvuYCjBjGMfmBR2BDwrV2wRSBOyZertlTpmUdT5RaIHBTC/I= X-MS-TrafficTypeDiagnostic: VI1PR04MB4686: X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4686; 20:Z9wsGpvsnkQa9Uk8ggQkUvf0nzirzm27cQxIkJJ0UZMhtcAS6DpnnhwlcrQT8wsVD4EEYcizh2mD3O6cPh8A48nXrOy2D1ih6QvyC8ONvkiCSht4SXWj2UI9LZKTiR+PkG7PG9LUNQ/6YnXndWPWmR3b8sLMhcYuSI735hBr1riHTlJkPHRZF8xzWWTtgYUz9Ozz/EpRCELmRqEbRAsFcahqJsTkvQhq9BwptGCi6uJDTAEBtSvN0bwNnpDRAtt90ejFqC4Rx+WfIdqOnt/FzgaoC0Xq1gnsh6QV8BYBeVd+DtzivAfj9NLYxnObSaS0or8vNZ3uoRI77C+LuGtqfknf5TotqxkQBcnaubby1RubQPOHE5dJizEGRucfdgcbhzQchPlr0plI1QNMMighsWR9U/hb0PKnbc2adhx0XIVScAy1zGN8nzVDg8gimYuNYIjvr8r2M+xXqzcbFsoT3Vhbe6P0X0ST6DbYyMtKgJ/Bio/W6oK0072GIC6oPmwI; 4:TZ8tceoA9uhFSXvwhBAX74WvoBQTfMClb4I+YILV5HktxH6ejpb78GEHDowi3jkAgII4xZ33d/oQVCKOqwujv0uPlkhsHLFbyfBrmJfBJnGcFmmHUcUm4VA9WflbYThNmkNemRFRP+1/i8WBmq8Ey14AUxufVO7O9PqwVlZq8kS7DCgL7mLR20v3qeC1EnperKUYo865Od2VTolxVrtc6VewkJ0tfUcip5OQ8yms5lTldQzIBIUIyAx5hsWOuicXm9xTPqOy4BuixmMwylu2TFYQH9trlx/sBXaBhttn9Rq6/n3smh8ZNM4qdCs3k7SAz9a47wCDwj64MtB5ILJIjTxxX/r4ZNfe602Bh1KwZKA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231355)(944501410)(52105095)(10201501046)(3002001)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051); SRVR:VI1PR04MB4686; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB4686; X-Forefront-PRVS: 0808323E97 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(39860400002)(396003)(136003)(376002)(366004)(199004)(189003)(31686004)(31696002)(3846002)(6246003)(8676002)(229853002)(11346002)(2616005)(476003)(6486002)(956004)(97736004)(6666003)(8936002)(67846002)(7416002)(446003)(81166006)(81156014)(86362001)(6116002)(26005)(7736002)(34290500001)(52146003)(2486003)(52116002)(305945005)(76176011)(47776003)(23676004)(106356001)(478600001)(105586002)(186003)(386003)(65806001)(53546011)(65956001)(66066001)(16526019)(77096007)(58126008)(16576012)(54906003)(64126003)(55236004)(4326008)(5009440100003)(316002)(230700001)(53936002)(50466002)(68736007)(5660300001)(44832011)(25786009)(65826007)(2906002)(93886005)(36756003)(486006)(39060400002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4686; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0TUI0Njg2OzIzOndaWDZlejFnZnBtcjBRMzNtWWV2dDhPSUpE?= =?utf-8?B?NVdrdXl4NDZzRDlVendlb1VOU2ZRN2dsWWRJUHFydEViVWdidktWMGpsUVpL?= =?utf-8?B?UEhubHR0WGZGcGVXYWcwdlNuRVN2WWVvTHQ4ZUZkOGh6WXlKeUMxQjdkNGgy?= =?utf-8?B?UmxGL1BuR0I2Y1Bta051QTFjTFEwNGh2dURqWUEzRzIrYW1HY0E3cm5xcHZS?= =?utf-8?B?RFZ5NjZxS3EyVUIrUmVqeSsxcjJTWlhDTm5kQ1c0SlhKcTVQTmovWmpTUlFx?= =?utf-8?B?YllFdXkvMnlWeWR1WFBQVXp6R2lVRnEwd3kwTnJ0dzhZZjU1N1QwTGZva0M5?= =?utf-8?B?a05abGpQcFN2a2JvdUJoNXBINXlzMTh1R2IvYi9HTXVmc25rSWVXYTJjWStV?= =?utf-8?B?T2FMclBKdG9nQ0s5MDJ2YVBLR095VmdBSHUrSjhOSEc4Y3pDelM0MlZVK2d5?= =?utf-8?B?ditsY0NuSklENy9rNHRydTAvOUtFRjIzbTNhMGRUZloyZzkwSC9KZHpSR2F0?= =?utf-8?B?Ykc4Vk16OEtsd2dtbGMxQVlNY1duajR4cEpjQ3BPZTA1LzhpUEU0Y2t5b1VC?= =?utf-8?B?Qm9jdFJkVTM0WDRSOFBmOHZ2aXJuYVFYUE10b2ZXM21ocEZUMWZrMGlwOWNx?= =?utf-8?B?TXdjQks1TklVRjFHcXUzbDVRcGZOaU40RVdISlc0djJaT0lEaURsclFYYStH?= =?utf-8?B?US8vZDBQbjE0dFRDWXZxQkRoSk53b3IxTTU3QldFbjJWUDFNL1Erc3BWQ0Iz?= =?utf-8?B?ZTJJRGwzSHg1QmROR2NVcWY1YlFyYXNYVjd1Z3hBSzFUdzk2cEd2M0FYMy9t?= =?utf-8?B?UFBlRHpvbFhqa1lObThEUTZ1U25ocmY4bU1NRnYrTStqbWNmSkkraTNCa2Jk?= =?utf-8?B?MHcxSzVBcmJWTTJPRnAyeXBBbWxiS0JEOEVkYktldE1saWJHd000VjBpOXk0?= =?utf-8?B?T0xhZERuVityZ2xWYmxiS1ZYVmY2RHJiTHBXNzFTWmlUL1JzYTMyTUR6UWMz?= =?utf-8?B?V2dSOEcyWmM2UzYxbEdmSTZXMnBjQi9NR2ZCODJUNXFiZVpmRXprT25pK2dT?= =?utf-8?B?Vm1xaElxNXpvekpGcld3d2RBWUx0blJUa0xJUGdWS0tIZERpdWlwTm1IRjFa?= =?utf-8?B?VW1EUVJHSDZMTENCdmExWmV1WUsyTFVkakxlTHZHQUJVcjg4RExoUnZsYjM4?= =?utf-8?B?UFpzK1l1dzlxL3B3d3hlclkxMzcxc2FhbmtLOW1ZN0dsdnYvNVVON1hCWXRv?= =?utf-8?B?TlZtblp5eHRJMW1zTm5NRFdGeWQ0MW91SnV4SEYwQlNDdlFoaE5MaVk4UHQz?= =?utf-8?B?d0VqSlhlRGtQdE0zemdseUNSQWJXTFNyU0QvNVp2a0tHRllNMDRUR1NES0V5?= =?utf-8?B?N0Y5RStVSk1pL2lBTm95NlJaK0JieWlDQzhGVXRBVHhzSmRRNmJ2Y0luVjJM?= =?utf-8?B?eGhpSmY4dzZGRldkQXNSL3pwZUI5OG11UFN1aUVqNGxvTlQvZVVSK3ZSZVBR?= =?utf-8?B?UU01SmNIZ2JQTUIvRXM3bGZ4UUlsVnlRbktDZTlneG4zL3djczRWbWxnMUtl?= =?utf-8?B?Z0Fvdk1KcEUwNmxvQzdpdDJ0ZXhxQmZWcXVrMHpZYkVDSmd2TEtxMWV5c2Vo?= =?utf-8?B?enFvUy91WDF1bEZ3WG41ZW1jQzhjZnB2R0RXSjZjUzRhNFczVlNzTWpiaU1a?= =?utf-8?B?Q2JpcnM0NWEza3RUTWtPVHRjNE1xdEoyY1RMTFJubFVqZ2lvUUtzRzM5REV3?= =?utf-8?B?NlJ0emtrdTlJbXJKWWNQYmoxRnRoeXhaeVByZ0h3U2pvQlRPWHV0eXA2Uzdn?= =?utf-8?B?cFpuTWFJV0o4eVhKU3NCU29PZEF1TVMxUzZMOTNSNWxDRS9YalRWWmxrV0RQ?= =?utf-8?B?V2syMXRIUnVlU2h5MXZuZUNmdUVoU1ZHbkRabmZtSlhtYllJSjV3WHJwektI?= =?utf-8?B?b2VxWllyUU5Fby9GaEl0QittMXI4U2Raa1kveUNhTHFIbTd1REh3a0pyUm1C?= =?utf-8?B?NTB1dzJCNnRJcEVWZUNBNUd3ODRxUTlVeW1ON2lLYWphczNuU2FjVlhmZU42?= =?utf-8?B?Rk5vUTFrSm9jNFJ4a0kvZnErSlRndDJKZk9oOUxHVnJXN29TMEF6ajg4NXBw?= =?utf-8?B?cnR4bWRDc3pwbFVVaFNXczl1OUgrNG9wN3p6TWlHck9hV2FOTm9tQ1FrM0FB?= =?utf-8?B?bzFBMGcyOXcxdndrVG55M0M1QkdRPT0=?= X-Microsoft-Antispam-Message-Info: em0Pmu4ddy3IZvCKKbzWS/NY+w0J8ZfVzxrhQMtXlkU5IxoeAdlHjOl3rqlrMjZX4GE4bfAN3mMwODQnJbMfq/FjxHjpUUXfSCenVMnGuFlWfsxHoBTenHor7v/ZXcr8FskGeD2fYZkahJ+F+VoM22Rlj72Hmmy3vEb1+7csKG1HRC75hv3dkGzMV37n7ziHLa3BHpVmEggKbQntRkZ8oe5/L7WX+5CIYNJ8whMHWn1o3yBwMbysmpmCf5fLjItwgaAdmEiQd9oHPZJNA8UVKAXzhx9aZOBk2afzF261y+jzS3b4eONwqi5njPE8038bsTr+JZnTGJHn3yGAUtSfRbjxy920qhJbco9Z5gqyjx4= X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4686; 6:4+MvNkwPrtp07UWgMWz24+miCkrae68XgVoakW/DnVF94211YfZq+GsHarEbTe20a7BA5XLhImg1PI42FpB8YXHbVi5ATkPBEci5SsYu/Oa381rFUlGksQWU52B9LCEroVkIL8BsgN/o5wqMV4b9zZsjjAF3Wg9QKxrlhwuNy1zUc28lwUuBjgRlGGemousIfX6wSXQaXYpOG15z1+AsbcPFFb0UEQ4zIfmah/yxVVNpVp37J45l/l9ZtO2q76we1IoXCtk7021GtWo1/GYGTL2X/lJ2k65Q5W4T72sWH8gur1P9G3/Z7N96CRyCxpc9yXP1zwOk0KBKIVfH9i/v/cjwUwTwMvM2RCN3NCPszZM2n4odCV3nVFcXlM6ADi9sfn9EB3Plj0FJ7NLtKm+srAO0whKU8vkKGLYNxuKPb6co0keqsIuXwJxcZHXGRYHmFWxZ7oveOF0mVtrKka4KDQ==; 5:Va81VL70RXs5k0xr+20nJz9Oj/KKrhpWF3bQZom8r3bOTJFCrWGMjfN8ALTAvjEZAkwXsyji9cEe8Wzjaudq7OqkkZjIXZcLOk54ANULHwWFUkAwvkHRDmt/BDvFbqjteHv3Yifp1lefLh4H+NqAzIX8aJxOUJyGHu2Wp3TwHN8=; 7:294ifeNsmZxm+QF2jiPyz5nDJ0zz2tmxTWxpT8ByvCsmolZxz2ljJBbyAoSeZlzjIcxpw3PKd2ff4yL8WiNg/8JN7y0Cg0DuJ5AyqHAyzvsuRUJtkgzT25CQmf/Deyib0qVWrTMRUP6TJDC9wGbH/+eBcTSptPw+0u3exoZXovaoFOGzc9kEruAXD1n4qlqEAs5rJHwRtoqd5hPN0MLIQuakR/fsKciA4zcbFmOKRHPXYdaELzUYBYslgjJ7fb4l SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2018 11:13:16.7223 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 681e5cf7-f8f7-4ffc-844c-08d6246a3fae X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4686 Subject: Re: [dpdk-dev] [PATCH v6 02/21] mem: allow memseg lists to be marked as external X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 11:13:30 -0000 On Thursday 27 September 2018 04:38 PM, Burakov, Anatoly wrote: > On 27-Sep-18 12:03 PM, Shreyansh Jain wrote: >> On Thursday 27 September 2018 04:10 PM, Anatoly Burakov wrote: >>> When we allocate and use DPDK memory, we need to be able to >>> differentiate between DPDK hugepage segments and segments that >>> were made part of DPDK but are externally allocated. Add such >>> a property to memseg lists. >>> >>> This breaks the ABI, so bump the EAL library ABI version and >>> document the change in release notes. This also breaks a few >>> internal assumptions about memory contiguousness, so adjust >>> malloc code in a few places. >>> >>> All current calls for memseg walk functions were adjusted to >>> ignore external segments where it made sense. >>> >>> Mempools is a special case, because we may be asked to allocate >>> a mempool on a specific socket, and we need to ignore all page >>> sizes on other heaps or other sockets. Previously, this >>> assumption of knowing all page sizes was not a problem, but it >>> will be now, so we have to match socket ID with page size when >>> calculating minimum page size for a mempool. >>> >>> Signed-off-by: Anatoly Burakov >>> Acked-by: Andrew Rybchenko >>> --- >>> >> >> Specifically for bus/fslmc perspective and generically for others: >> >> Acked-by: Shreyansh Jain >> >> > > Actually, this patch may need some further adjustment, since it makes > assumption about not wanting to map external memory for DMA. > > Specifically - there's an fslmc dma map function that now skips external > memory segments. Are you sure that's how it's supposed to be? > I thought over that. For now yes. If we need to map external memory, and there is an event that would be called back, it should be handled separately. So, for example, a PMD level API to handle such requests from applications. The point is that how the external memory is handled is use-case specific - the need to have its events reported back is definitely there, but its handling is still a grey area. Once the patches make their way in, I can always come back and tune that.