Re: [dpdk-dev] [PATCH v4] build: add platform meson option

["Juraj Linkeš" <juraj.linkes@pantheon.tech>]

> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Wednesday, March 31, 2021 2:39 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: thomas@monjalon.net; david.marchand@redhat.com;
> Honnappa.Nagarahalli@arm.com; dev@dpdk.org
> Subject: Re: [PATCH v4] build: add platform meson option
> 
> On Wed, Mar 31, 2021 at 12:16:59PM +0000, Juraj Linkeš wrote:
> > Bruce, what do you think of the patch now? Do we need to add/change
> anything else, like documentation?
> >
> > One thing to note is that we're changing the default behavior in this patch
> from machine=native to machine=generic (or more accurately, to
> cpu_instruction_set=generic). Do we want to do that?
> >
> The patch in general looks ok, but I am uncertain about this change indeed.
> Especially since the -march flag we mirror to the pkg-config file. I'd like to see
> something like [1] included along with such a change. It allows us per-arch to
> select the flags to send to the pkg-config file, rather than just always using
> machine_args blindly.
> 
> Feedback appreciated.
> 

I'm not sure what feedback do you want here. I'm not that familiar with pkg-config files. I think this is about DPDK being built a set of instructions and an app using DPDK being able to be built another set of instructions and the pkg-config file bridges these? Could you expand a bit? I read the other commit msg (in [1]) as well and I don't know how it's related to this patch.

> /Bruce
> 
> [1] http://patches.dpdk.org/project/dpdk/patch/20201211155111.145279-1-
> bruce.richardson@intel.com/