From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <radu.nicolau@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 26B4F1B248 for <dev@dpdk.org>; Thu, 26 Oct 2017 14:28:14 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2017 05:28:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,434,1503385200"; d="scan'208";a="914004078" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.73]) ([10.237.221.73]) by FMSMGA003.fm.intel.com with ESMTP; 26 Oct 2017 05:28:10 -0700 To: Thomas Monjalon <thomas@monjalon.net>, David Marchand <david.marchand@6wind.com> Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, borisp@mellanox.com, aviadye@mellanox.com, sandeep.malik@nxp.com, Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, shahafs@mellanox.com, Olivier Matz <olivier.matz@6wind.com>, Akhil Goyal <akhil.goyal@nxp.com> References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <36c6304e-cd1b-9bd9-2c5d-c6e20eff85e8@intel.com> <CALwxeUsLoVMxZLXy2YZXXgmzu22y6A3J5EnQy1YvGWyrrd1WEA@mail.gmail.com> <2193963.B775pDLU5T@xps> From: Radu Nicolau <radu.nicolau@intel.com> Message-ID: <99778dc4-9fea-e859-71b8-c1ff910eebd2@intel.com> Date: Thu, 26 Oct 2017 13:28:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <2193963.B775pDLU5T@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 26 Oct 2017 12:28:15 -0000 On 10/26/2017 12:39 PM, Thomas Monjalon wrote: > 26/10/2017 13:27, David Marchand: >> On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau <radu.nicolau@intel.com> wrote: >>> On 10/26/2017 11:36 AM, David Marchand wrote: >>>> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau <radu.nicolau@intel.com> >>>> wrote: >>>>> --- a/drivers/net/ixgbe/Makefile >>>>> +++ b/drivers/net/ixgbe/Makefile >>>>> +ifneq ($(MAKECMDGOALS),clean) >>>>> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y) >>>>> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD") >>>>> +endif >>>>> +endif >>>> This is a no go for me unless you explain how it is impossible to >>>> disable it in the code. >>>> >>>> >>> It can be disabled in the code, but as far as I know there is a general push >>> back against having conditionally compiled code. I originally had the >>> security sections in ixgbe PMD isolated, but the feedback was to have them >>> always on. >> In my mind, this was to stop having features enabled per pmd (and stop >> the nightmare with 10 options in a pmd). >> Having features globally enabled for all or nothing is still >> acceptable, is it not ? > Yes there is a config option for rte_security, > and it is acceptable. > The code depending on it must be ifdef'ed. Given that both ixgbe and dpaa2_sec are now security enabled PMDs, I would go with Konstantin's proposal, have rte_security listed as a dependency (instead of the explicit check). Any other PMD is not affected. For ipsec sample I would keep the explicit check.