From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
dev@dpdk.org, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field
Date: Wed, 01 Mar 2023 12:37:56 +0100 [thread overview]
Message-ID: <9988058.nnTZe4vzsl@thomas> (raw)
In-Reply-To: <20230228180230.3066738-1-ferruh.yigit@amd.com>
28/02/2023 19:02, Ferruh Yigit:
> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
> which is exposed via ehtdev stat APIs.
>
> But telemetry exposes this field to user via "/ethdev/info",
> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
>
> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
>
> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
> - rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
> - eth_dev->data->rx_mbuf_alloc_failed);
Good catch, thanks.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2023-03-01 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 18:02 Ferruh Yigit
2023-03-01 11:37 ` Thomas Monjalon [this message]
2023-03-01 14:08 ` Andrew Rybchenko
2023-03-02 15:27 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9988058.nnTZe4vzsl@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=gmuthukrishn@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).