From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AE7E41DAA; Wed, 1 Mar 2023 12:38:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BB154114A; Wed, 1 Mar 2023 12:38:02 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 719604113C; Wed, 1 Mar 2023 12:38:00 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 10F343200949; Wed, 1 Mar 2023 06:37:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 01 Mar 2023 06:37:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677670678; x= 1677757078; bh=Bygl4vkmuUjXzmfpuTEGrC+QXhbP5lkFcQp3UQMRkIM=; b=I Rv1lSeXcI3WbeKp+qFBJcpwPUI/M+qZqH5jO8n+Dce84dntE4yiKkd22jc9g7fSm yUKsCJGRPd4oMAtC7vdB/Vb4nvOLNozYeh/4p19Q8iEFr1I66nfe6KmMT5AFDYMO q6hBBtQEUOcjFQXHBzE4nlJ89KBNmv+YKZoM5SzELiPwKKvqmdImhoaVIjXs9eAy gtiYUX15aEW6LO1Gle8jH0ctlK8HuTkIplO+M0+UaUDJgkKw5mhC37VyXY7RzwPe oYJ9LVKeGMiA9TosfBlrMUwsY6SWtlnk7JFauEm2bEm1pYd+mKLgwc69e/rc90h3 TwqXRGmBlJjdAk7g1e0SQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677670678; x= 1677757078; bh=Bygl4vkmuUjXzmfpuTEGrC+QXhbP5lkFcQp3UQMRkIM=; b=g cBFLSP9kqVqu8+fe3M7WNfB0YzezPKiHytF/3bsI649SUD6oyJcthODoqMlJ1hio 8gP8203C6Fu87EhPKs2hBWvQvztCWcRbzH3nMv3rTmK9E5NHBDIA/QuwY2z7Dx4p 7KQlYdeBAid/vYQshasZIuacwq+fbGRA4cMTL5B8dKgRayBBp+vgO9mmfSZCp1wm f+lXuEo4CGLhX3Upv/QCwQDG30OQL4nQDSOZAEfPkUANffNOn/S9tTEpAH8ieQif rStJFw3FcVcSVUoVW4GAF/+ExuErreYCJGDY+OFil5OIL3OK/feOFKS3seGC62Cd +oCg+eymZ/QUHhKZo0peg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelhedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Mar 2023 06:37:57 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Andrew Rybchenko , Gowrishankar Muthukrishnan , dev@dpdk.org, stable@dpdk.org, Bruce Richardson , Qi Zhang Subject: Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field Date: Wed, 01 Mar 2023 12:37:56 +0100 Message-ID: <9988058.nnTZe4vzsl@thomas> In-Reply-To: <20230228180230.3066738-1-ferruh.yigit@amd.com> References: <20230228180230.3066738-1-ferruh.yigit@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/02/2023 19:02, Ferruh Yigit: > 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to > user via ethdev APIs but it is used internally to set "stats->rx_nombuf' > which is exposed via ehtdev stat APIs. > > But telemetry exposes this field to user via "/ethdev/info", > instead user can get 'rx_nombuf' value from stats via "/ethdev/stats". > > Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs > > Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > - rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail", > - eth_dev->data->rx_mbuf_alloc_failed); Good catch, thanks. Acked-by: Thomas Monjalon